[PATCH] LDAP: Don't reuse a single tevent callback for multiple requests

[Jakub Hrozek]

Hi,

the attached patch fixes a bug that was present since 1.6 at least, but
was only recently uncovered by the fix to skip referrals.

Please see the commit message for details.

[Michal Židek]

On 09/02/2014 05:28 PM, Jakub Hrozek wrote:
>  Hi,
>
>  the attached patch fixes a bug that was present since 1.6 at least, but
>  was only recently uncovered by the fix to skip referrals.
>
>  Please see the commit message for details.
>  
Thanks Jakub for catching this. Patch works for me.

ACK.

Michal

[Jakub Hrozek]

On Fri, Sep 05, 2014 at 02:11:26PM +0200, Michal Židek wrote:
>  On 09/02/2014 05:28 PM, Jakub Hrozek wrote:
>  >Hi,
>  >
>  >the attached patch fixes a bug that was present since 1.6 at least, but
>  >was only recently uncovered by the fix to skip referrals.
>  >
>  >Please see the commit message for details.
>  >
>  
>  Thanks Jakub for catching this. Patch works for me.
>  
>  ACK.
>  
>  Michal 
Thank you for the review, pushed to master:
    7ec88ea204c0d1db40a93502c70c7bc0491ec262

I will prepare a 1.11 version separately (sadly, the bug is also there)

[Jakub Hrozek]

On Fri, Sep 05, 2014 at 04:28:00PM +0200, Jakub Hrozek wrote:
>  I will prepare a 1.11 version separately (sadly, the bug is also
> there) 
Luckily it is not :-)

but the referrals are not ignored in sssd-1-11 for deref and ASQ, which
is what this patch implements.

[Jakub Hrozek]

On Wed, Sep 10, 2014 at 11:59:55AM +0200, Jakub Hrozek wrote:
>  On Fri, Sep 05, 2014 at 04:28:00PM +0200, Jakub Hrozek wrote:
>  > I will prepare a 1.11 version separately (sadly, the bug is also there)
>  
>  Luckily it is not :-)
>  
>  but the referrals are not ignored in sssd-1-11 for deref and ASQ, which
>  is what this patch implements. 
Sorry, I forgot to squash in one more change.

[Michal Židek]

On 09/10/2014 12:17 PM, Jakub Hrozek wrote:
>  On Wed, Sep 10, 2014 at 11:59:55AM +0200, Jakub Hrozek wrote:
> > On Fri, Sep 05, 2014 at 04:28:00PM +0200, Jakub Hrozek wrote:
> >> I will prepare a 1.11 version separately (sadly, the bug is also there)
> >
> > Luckily it is not :-)
> >
> > but the referrals are not ignored in sssd-1-11 for deref and ASQ, which
> > is what this patch implements.
>
>  Sorry, I forgot to squash in one more change.
>
>
>  
ACK for sssd-1-11.

Michal

[Jakub Hrozek]

On Wed, Sep 10, 2014 at 02:37:14PM +0200, Michal Židek wrote:
>  On 09/10/2014 12:17 PM, Jakub Hrozek wrote:
>  >On Wed, Sep 10, 2014 at 11:59:55AM +0200, Jakub Hrozek wrote:
>  >>On Fri, Sep 05, 2014 at 04:28:00PM +0200, Jakub Hrozek wrote:
>  >>>I will prepare a 1.11 version separately (sadly, the bug is also there)
>  >>
>  >>Luckily it is not :-)
>  >>
>  >>but the referrals are not ignored in sssd-1-11 for deref and ASQ, which
>  >>is what this patch implements.
>  >
>  >Sorry, I forgot to squash in one more change.
>  >
>  >
>  >
>  
>  ACK for sssd-1-11.
>  
>  Michal 
* sssd-1-11: 3f855784cbdd0b1909ec7f560114e9a107b15ca5