This results when running 'make check' with $SSS_ERROR set:
../src/tests/cmocka/test_authtok.c: In function ‘test_sss_authtok_password’: ../src/tests/cmocka/test_authtok.c:98:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *)data, len); ^ ../src/tests/cmocka/test_authtok.c: In function ‘test_sss_authtok_ccfile’: ../src/tests/cmocka/test_authtok.c:137:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *)data, len); ^ ../src/tests/cmocka/test_authtok.c:161:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *) data, 0); ^ ../src/tests/cmocka/test_authtok.c: In function ‘test_sss_authtok_wipe_password’: ../src/tests/cmocka/test_authtok.c:239:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *)data, len); ^ ../src/tests/cmocka/test_authtok.c: In function ‘test_sss_authtok_copy’: ../src/tests/cmocka/test_authtok.c:271:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *)data, len); ^ ../src/tests/cmocka/test_authtok.c:278:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *)data, len); ^
Cheers,
Stef
On Fri, Jan 10, 2014 at 08:15:43AM +0100, Stef Walter wrote:
This results when running 'make check' with $SSS_ERROR set:
../src/tests/cmocka/test_authtok.c: In function ‘test_sss_authtok_password’: ../src/tests/cmocka/test_authtok.c:98:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *)data, len);
Hm, I wonder why I don't see these warnings despite -Wall -Wextra in my CFLAGS. Anyway, the patch looks good and builds fine.
ACK
On (10/01/14 10:17), Jakub Hrozek wrote:
On Fri, Jan 10, 2014 at 08:15:43AM +0100, Stef Walter wrote:
This results when running 'make check' with $SSS_ERROR set:
../src/tests/cmocka/test_authtok.c: In function ‘test_sss_authtok_password’: ../src/tests/cmocka/test_authtok.c:98:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *)data, len);
Hm, I wonder why I don't see these warnings despite -Wall -Wextra in my CFLAGS. Anyway, the patch looks good and builds fine.
there weren't warnings with clang :-) this is a reason why you didn't see any. warnings are gone with gcc.
ACK++
LS
On Fri, Jan 10, 2014 at 02:18:07PM +0100, Lukas Slebodnik wrote:
On (10/01/14 10:17), Jakub Hrozek wrote:
On Fri, Jan 10, 2014 at 08:15:43AM +0100, Stef Walter wrote:
This results when running 'make check' with $SSS_ERROR set:
../src/tests/cmocka/test_authtok.c: In function ‘test_sss_authtok_password’: ../src/tests/cmocka/test_authtok.c:98:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *)data, len);
Hm, I wonder why I don't see these warnings despite -Wall -Wextra in my CFLAGS. Anyway, the patch looks good and builds fine.
there weren't warnings with clang :-) this is a reason why you didn't see any. warnings are gone with gcc.
Ah, I haven't used gcc on my devel laptop for quite some time now..thanks for checking! (Also, bad clang, bad..)
On Fri, Jan 10, 2014 at 02:37:22PM +0100, Jakub Hrozek wrote:
On Fri, Jan 10, 2014 at 02:18:07PM +0100, Lukas Slebodnik wrote:
On (10/01/14 10:17), Jakub Hrozek wrote:
On Fri, Jan 10, 2014 at 08:15:43AM +0100, Stef Walter wrote:
This results when running 'make check' with $SSS_ERROR set:
../src/tests/cmocka/test_authtok.c: In function ‘test_sss_authtok_password’: ../src/tests/cmocka/test_authtok.c:98:48: error: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Werror=cast-qual] ret = sss_authtok_set(ts->authtoken, type, (uint8_t *)data, len);
Hm, I wonder why I don't see these warnings despite -Wall -Wextra in my CFLAGS. Anyway, the patch looks good and builds fine.
there weren't warnings with clang :-) this is a reason why you didn't see any. warnings are gone with gcc.
Ah, I haven't used gcc on my devel laptop for quite some time now..thanks for checking! (Also, bad clang, bad..)
Pushed to master.
sssd-devel@lists.fedorahosted.org