[sssd PR#591][opened] Remove spaces after comment delimiters in the example config file

[amitkumar50]

   URL: https://github.com/SSSD/sssd/pull/591
Author: amitkumar50
 Title: #591: Remove spaces after comment delimiters in the example config file
Action: opened

PR body:
"""
If sssd.conf file contains configuration directives
preceded with whitespace characters sss_obfuscate generates traceback.

How Fix is tested?
# vim /usr/lib/python2.7/site-packages/SSSDConfig/ipachangeconf.py
Updated: r'(?P<option>[^:=\s][^:=]*)'
to: r'\s*(?P<option>[^:=\s][^:=]*)'

# /usr/local/sbin/sss_obfuscate --domain gsslab.pnq.redhat.com
Enter password:
Re-enter password:
<<<<<<<<<No traceback
seen>>>>>>>>>>

Resolves: https://pagure.io/SSSD/sssd/issue/1391
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/591/head:pr591
git checkout pr591

[sssd PR#591][comment] Remove spaces after comment delimiters in the example config file

[centos-ci]

  URL: https://github.com/SSSD/sssd/pull/591
Title: #591: Remove spaces after comment delimiters in the example config file

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/591#issuecomment-394635843

[sssd PR#591][comment] Remove spaces after comment delimiters in the example config file

[centos-ci]

  URL: https://github.com/SSSD/sssd/pull/591
Title: #591: Remove spaces after comment delimiters in the example config file

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/591#issuecomment-394635844

[sssd PR#591][edited] Remove spaces after comment delimiters in the example config file

[amitkumar50]

   URL: https://github.com/SSSD/sssd/pull/591
Author: amitkumar50
 Title: #591: Remove spaces after comment delimiters in the example config file
Action: edited

 Changed field: body
Original value:
"""
If sssd.conf file contains configuration directives
preceded with whitespace characters sss_obfuscate generates traceback.

How Fix is tested?
# vim /usr/lib/python2.7/site-packages/SSSDConfig/ipachangeconf.py
Updated: r'(?P<option>[^:=\s][^:=]*)'
to: r'\s*(?P<option>[^:=\s][^:=]*)'

# /usr/local/sbin/sss_obfuscate --domain gsslab.pnq.redhat.com
Enter password:
Re-enter password:
<<<<<<<<<No traceback
seen>>>>>>>>>>

Resolves: https://pagure.io/SSSD/sssd/issue/1391
"""

[sssd PR#591][comment] Remove spaces after comment delimiters in the example config file

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/591
Title: #591: Remove spaces after comment delimiters in the example config file

sumit-bose commented:
"""
ok to test
"""

See the full comment at https://github.com/SSSD/sssd/pull/591#issuecomment-394649795

[sssd PR#591][comment] Remove spaces after comment delimiters in the example config file

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/591
Title: #591: Remove spaces after comment delimiters in the example config file

jhrozek commented:
"""
I don't think the patch is correct, at the very least the title is confusing. I know
the upstream ticket is also confusing and doesn't say what should be done, but if you
look at the linked bugzilla, in particular
https://bugzilla.redhat.com/show_bug.cgi?id=835073#c2 I hope it's clearer that
it's really about removing the leading spaces from sssd-example.com, not relaxing the
regular expression.
"""

See the full comment at https://github.com/SSSD/sssd/pull/591#issuecomment-396231845

[sssd PR#591][+Changes requested] Remove spaces after comment delimiters in the example config file

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/591
Title: #591: Remove spaces after comment delimiters in the example config file

Label: +Changes requested

[sssd PR#591][edited] sss_obuscate: Fix traceback while reading space in sssd.conf

[amitkumar50]

   URL: https://github.com/SSSD/sssd/pull/591
Author: amitkumar50
 Title: #591: sss_obuscate: Fix traceback while reading space in sssd.conf
Action: edited

 Changed field: title
Original value:
"""
Remove spaces after comment delimiters in the example config file
"""

[sssd PR#591][comment] sss_obuscate: Fix traceback while reading space in sssd.conf

[amitkumar50]

  URL: https://github.com/SSSD/sssd/pull/591
Title: #591: sss_obuscate: Fix traceback while reading space in sssd.conf

amitkumar50 commented:
"""
@jhrozek I corrected the Title. Issue is same as mentioned in upstream.
If we place space before any option in sssd.conf. And run sss_obfuscate, it produces
traceback. 

With this fix sss_obfuscate does not produces traceback also removes space from front of
option.
"""

See the full comment at https://github.com/SSSD/sssd/pull/591#issuecomment-396241392

[sssd PR#591][comment] sss_obuscate: Fix traceback while reading space in sssd.conf

[mzidek-rh]

  URL: https://github.com/SSSD/sssd/pull/591
Title: #591: sss_obuscate: Fix traceback while reading space in sssd.conf

mzidek-rh commented:
"""
@amitkumar50 How did you test the patch? I can see the traceback even with the patch
applied when I put spaces at the beginning of the lines and run sss_obfuscate. Can you
send example config file that breaks the sss_obfuscate without the patch but works with
the patch? Maybe I am testing it wrong.

Also this may need to be aligned with the multi-line value support in ding-libs. But I
just tried the multi-line feature and did not work for me either. I could not find any
tests for the multi-line value feature in ding-libs (other then one that tests multi-line
value space trimming). The only documentation I could find was in the header files that
states that multi-line values must start with a space at the beginning of every new line
(which is why I am mentioning it here), which is what I was trying to do, but it did not
work. Am I missing something?
"""

See the full comment at https://github.com/SSSD/sssd/pull/591#issuecomment-397046488

[sssd PR#591][comment] sss_obuscate: Fix traceback while reading space in sssd.conf

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/591
Title: #591: sss_obuscate: Fix traceback while reading space in sssd.conf

jhrozek commented:
"""
Since there was no reply for over a month, I'm closing this PR. Feel free to reopen
later.
"""

See the full comment at https://github.com/SSSD/sssd/pull/591#issuecomment-406647151

[sssd PR#591][closed] sss_obuscate: Fix traceback while reading space in sssd.conf

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/591
Author: amitkumar50
 Title: #591: sss_obuscate: Fix traceback while reading space in sssd.conf
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/591/head:pr591
git checkout pr591

[sssd PR#591][+Rejected] sss_obuscate: Fix traceback while reading space in sssd.conf

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/591
Title: #591: sss_obuscate: Fix traceback while reading space in sssd.conf

Label: +Rejected