-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
This patch fixes the following issues: * man page issues (#395) * show info on MPGs (#396) * recursively print indirect members (#397) * the list of groupnames is comma separated (#398) * output inconsistencies (#399)
On Mon, Feb 08, 2010 at 09:01:29PM +0100, Jakub Hrozek wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
This patch fixes the following issues: * man page issues (#395) * show info on MPGs (#396) * recursively print indirect members (#397) * the list of groupnames is comma separated (#398) * output inconsistencies (#399) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAktwbZkACgkQHsardTLnvCUl6gCffDSrlRrfr955H9o8Y55PteLz Kk8AoOk4Y1CgJuXXT4KcVulQDfMrkCko =38ve -----END PGP SIGNATURE-----
NACK
- if (state->recursive == false) {
/* if not recursive, just fill in names */state->root->group_members = talloc_array(state->root,struct group_info *,nmembers+1);for (i=0; group_members[i]; i++) {state->root->group_members[i] = talloc_zero(state->root,struct group_info);
if there are no group members group_members==NULL.
bye, Sumit
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/09/2010 12:20 PM, Sumit Bose wrote:
On Mon, Feb 08, 2010 at 09:01:29PM +0100, Jakub Hrozek wrote: This patch fixes the following issues: * man page issues (#395) * show info on MPGs (#396) * recursively print indirect members (#397) * the list of groupnames is comma separated (#398) * output inconsistencies (#399)
NACK if there are no group members group_members==NULL.
Although I did not manage to reproduce the segfault, the backtrace looked like an uninitialized "nmembers" variable..new patch is attached.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/09/2010 02:08 PM, Jakub Hrozek wrote:
Although I did not manage to reproduce the segfault, the backtrace looked like an uninitialized "nmembers" variable..new patch is attached.
Several other improvements related to the way we display info about the MPGs were discussed off-list, this patch factors them in.
Jakub
On Tue, Feb 09, 2010 at 10:39:28PM +0100, Jakub Hrozek wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/09/2010 02:08 PM, Jakub Hrozek wrote:
Although I did not manage to reproduce the segfault, the backtrace looked like an uninitialized "nmembers" variable..new patch is attached.
Several other improvements related to the way we display info about the MPGs were discussed off-list, this patch factors them in.
Jakub -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAktx1hAACgkQHsardTLnvCVXNwCfedeYn+IVQg0TAGBwSbn1svcA AToAoJ97bOeTXJCmSwOgJavGFbWZc2Cm =2tqm -----END PGP SIGNATURE-----
- subreq = group_show_recurse_send(state->root, state,
state->root,group_members,nmembers);- if (ret != EOK) {
tevent_req_error(req, ret);return;- }
- tevent_req_set_callback(subreq, group_show_recurse_done, req);
+}
I think 'if (!subreq)' fits better here.
bye, Sumit
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/10/2010 11:40 AM, Sumit Bose wrote: + + subreq = group_show_recurse_send(state->root, state, + state->root, + group_members, + nmembers); + if (ret != EOK) { + tevent_req_error(req, ret); + return; + } + tevent_req_set_callback(subreq, group_show_recurse_done, req); +} +
I think 'if (!subreq)' fits better here.
bye, Sumit
Yes, a copy'n'paste error..thanks for catching that.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Yet another iteration to fix yet another bug..
On Wed, Feb 10, 2010 at 05:29:04PM +0100, Jakub Hrozek wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Yet another iteration to fix yet another bug.. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkty3tAACgkQHsardTLnvCXgtACfV5Ij7XoWGMI4hCmXQHG4IOnZ 4vYAnjWHG9wZ5d2ABlTQ7gfr9VYSnbJu =jaeY -----END PGP SIGNATURE-----
ACK
bye, Sumit
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/10/2010 11:48 AM, Sumit Bose wrote:
On Wed, Feb 10, 2010 at 05:29:04PM +0100, Jakub Hrozek wrote: Yet another iteration to fix yet another bug..
ACK
Pushed to master.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Stephen Gallagher -
Sumit Bose