[sssd PR#733][opened] providers/ldap: abort unsecure authentication requests

[alexey-tikhonov]

   URL: https://github.com/SSSD/sssd/pull/733
Author: alexey-tikhonov
 Title: #733: providers/ldap: abort unsecure authentication requests
Action: opened

PR body:
"""
Abort LDAP authentication if the connection is not authenticated and
SDAP_DISABLE_AUTH_TLS is off.

Resolves: https://pagure.io/SSSD/sssd/issue/3889
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/733/head:pr733
git checkout pr733

[sssd PR#733][synchronized] providers/ldap: abort unsecure authentication requests

[alexey-tikhonov]

   URL: https://github.com/SSSD/sssd/pull/733
Author: alexey-tikhonov
 Title: #733: providers/ldap: abort unsecure authentication requests
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/733/head:pr733
git checkout pr733

[sssd PR#733][comment] providers/ldap: abort unsecure authentication requests

[alexey-tikhonov]

  URL: https://github.com/SSSD/sssd/pull/733
Title: #733: providers/ldap: abort unsecure authentication requests

alexey-tikhonov commented:
"""
Re-pushed as a set of patches.
Also [added missed
`return`](https://github.com/SSSD/sssd/pull/733/commits/cccc61e80b2d5e2c2932885147989210c46c5dd8#diff-b3b8241614c32941c76e1ea1610cfc89R812)
inside of `!check_encryption_used` check.
"""

See the full comment at https://github.com/SSSD/sssd/pull/733#issuecomment-456336814

[sssd PR#733][comment] providers/ldap: abort unsecure authentication requests

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/733
Title: #733: providers/ldap: abort unsecure authentication requests

jhrozek commented:
"""
Coverity came clean, CI passes here and I tested a patch by returning 0 from the function
from within a gdb session.

-> ACK
"""

See the full comment at https://github.com/SSSD/sssd/pull/733#issuecomment-458908197

[sssd PR#733][+Accepted] providers/ldap: abort unsecure authentication requests

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/733
Title: #733: providers/ldap: abort unsecure authentication requests

Label: +Accepted

[sssd PR#733][comment] providers/ldap: abort unsecure authentication requests

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/733
Title: #733: providers/ldap: abort unsecure authentication requests

jhrozek commented:
"""
* master:
 * a04d088d99f953c7b98c16cf23eedff62e9483bf
 * 53cc1187daee486bf4ba80dc3475944995ef4df6
 * 49c13e9aa84f1889cd2b50397b6a4f74c9dfba57
"""

See the full comment at https://github.com/SSSD/sssd/pull/733#issuecomment-459507008

[sssd PR#733][+Pushed] providers/ldap: abort unsecure authentication requests

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/733
Title: #733: providers/ldap: abort unsecure authentication requests

Label: +Pushed