On (15/08/16 11:09), Lukas Slebodnik wrote:
>On (12/08/16 10:35), Pavel Březina wrote:
>>On 08/11/2016 04:03 PM, Lukas Slebodnik wrote:
>>> On (20/07/16 11:10), Pavel Březina wrote:
>>> > CI:
http://sssd-ci.duckdns.org/logs/job/50/01/summary.html
>>> >
>>> > The failure is about missing dependencies, unrelated to these patches.
>>> >
>>> > It depends on the sssctl failover patches due to changes in attaching
dbus
>>> > message to a talloc context. Now it is possible to also free the message
with
>>> > both dbus_message_unref() and talloc_free(). Since the sssctl patches
are
>>> > already in late review process I didn't want to change them.
>>>
>>> > From cc00161e956c998f2ae8e7b7aa42042f0a9d3b04 Mon Sep 17 00:00:00 2001
>>> > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
>>> > Date: Fri, 15 Jul 2016 14:50:41 +0200
>>> > Subject: [PATCH 1/4] sbus: allow freeing msg through dbus api when
using
>>> > talloc
>>> >
>>> > When a talloc-bound message was freed by removing all references
>>> > to it with dbus_message_unref we failed to free the talloc context
>>> > and thus leaking memory or unreferencing invalid message when
>>> > the parent context is freed.
>>> >
>>> > This patch allows to bound dbus message to talloc in the way that
>>> > allows us to free the message by both talloc and dbus api.
>>> > ---
>>> > src/sbus/sssd_dbus_utils.c | 51
++++++++++++++++++++++++++++++++++++++++++++++
>>> > 1 file changed, 51 insertions(+)
>>> >
>>> I think this patchset is not complete/
>>> I cannot find the file src/sbus/sssd_dbus_utils.c in git master
>>>
>>> I was able to apply rest of patches but they cannot be compiled
>>> doe to undefined functions.
>>>
>>> BTW sorry for late review.
>>>
>>> LS
>>
>>Hi, thank you. It depends on "sssctl: print active server and server
list".
>>It is written in the first sentence.
>The 1st sentence says "It depends on the sssctl failover patches"
>Which I could not match with the thread :-)
>
>Anyway, patches dod not broke anyting according to tests :-)
>LGTM, because it's blocked by other thread.
>
blocker is gone.
LGTM -> ACK
http://sssd-ci.duckdns.org/logs/job/51/59/summary.html
master:
* f31610a9ba26b46de9eeab2b0719ff6ad8961104
* 04e870d99e72aa3160bdb6ab05d986fb4005c3ed
* e07d700ed9daf0cf96607fa2d72978cb2431b794
* 5d556f70f00c43864d8495d7caacfadf962799df
LS