[PATCH] resolv_gethostbyname_send: talloc_strdup hostname on state

[Pavel Březina]

If we provide a hostname that was allocated on stack, it may contain
invalid data in the time when it is actually resolved.

[Stephen Gallagher]

On Mon, 2012-07-16 at 15:59 +0200, Pavel Březina wrote:
>  If we provide a hostname that was allocated on stack, it may contain
>  invalid data in the time when it is actually resolved. 
Nack.

Please test for NULL after talloc_strdup() in the case of ENOMEM.

[Pavel Březina]

On 07/16/2012 04:00 PM, Stephen Gallagher wrote:
>  On Mon, 2012-07-16 at 15:59 +0200, Pavel Březina wrote:
> > If we provide a hostname that was allocated on stack, it may contain
> > invalid data in the time when it is actually resolved.
>
>  Nack.
>
>  Please test for NULL after talloc_strdup() in the case of ENOMEM. 
Oops, right. New patch is attached.
Thanks.

[Stephen Gallagher]

On Mon, 2012-07-16 at 16:10 +0200, Pavel Březina wrote:
>  On 07/16/2012 04:00 PM, Stephen Gallagher wrote:
>  > On Mon, 2012-07-16 at 15:59 +0200, Pavel Březina wrote:
>  >> If we provide a hostname that was allocated on stack, it may contain
>  >> invalid data in the time when it is actually resolved.
>  >
>  > Nack.
>  >
>  > Please test for NULL after talloc_strdup() in the case of ENOMEM.
>  
>  Oops, right. New patch is attached.
>  Thanks. 
Nack. Please keep the allocation and check together.

[Pavel Březina]

On 07/16/2012 04:15 PM, Stephen Gallagher wrote:
>  On Mon, 2012-07-16 at 16:10 +0200, Pavel Březina wrote:
> > On 07/16/2012 04:00 PM, Stephen Gallagher wrote:
> >> On Mon, 2012-07-16 at 15:59 +0200, Pavel Březina wrote:
> >>> If we provide a hostname that was allocated on stack, it may contain
> >>> invalid data in the time when it is actually resolved.
> >>
> >> Nack.
> >>
> >> Please test for NULL after talloc_strdup() in the case of ENOMEM.
> >
> > Oops, right. New patch is attached.
> > Thanks.
>
>  Nack. Please keep the allocation and check together. 
New patch attached.

[Stephen Gallagher]

On Mon, 2012-07-16 at 16:19 +0200, Pavel Březina wrote:
>  On 07/16/2012 04:15 PM, Stephen Gallagher wrote:
>  > On Mon, 2012-07-16 at 16:10 +0200, Pavel Březina wrote:
>  >> On 07/16/2012 04:00 PM, Stephen Gallagher wrote:
>  >>> On Mon, 2012-07-16 at 15:59 +0200, Pavel Březina wrote:
>  >>>> If we provide a hostname that was allocated on stack, it may contain
>  >>>> invalid data in the time when it is actually resolved.
>  >>>
>  >>> Nack.
>  >>>
>  >>> Please test for NULL after talloc_strdup() in the case of ENOMEM.
>  >>
>  >> Oops, right. New patch is attached.
>  >> Thanks.
>  >
>  > Nack. Please keep the allocation and check together.
>  
>  New patch attached. 

Ack!

[Stephen Gallagher]

On Mon, 2012-07-16 at 10:22 -0400, Stephen Gallagher wrote:
>  On Mon, 2012-07-16 at 16:19 +0200, Pavel Březina wrote:
>  > On 07/16/2012 04:15 PM, Stephen Gallagher wrote:
>  > > On Mon, 2012-07-16 at 16:10 +0200, Pavel Březina wrote:
>  > >> On 07/16/2012 04:00 PM, Stephen Gallagher wrote:
>  > >>> On Mon, 2012-07-16 at 15:59 +0200, Pavel Březina wrote:
>  > >>>> If we provide a hostname that was allocated on stack, it may
> contain
>  > >>>> invalid data in the time when it is actually resolved.
>  > >>>
>  > >>> Nack.
>  > >>>
>  > >>> Please test for NULL after talloc_strdup() in the case of ENOMEM.
>  > >>
>  > >> Oops, right. New patch is attached.
>  > >> Thanks.
>  > >
>  > > Nack. Please keep the allocation and check together.
>  > 
>  > New patch attached.
>  
>  
>  Ack! 
Pushed to master.