ehlo,
There are some unused function parameters.
I split change to three patches for easier review, but I can squash them to only one patch.
LS
On Thu, 2013-08-29 at 14:05 +0200, Lukas Slebodnik wrote:
ehlo,
There are some unused function parameters.
I split change to three patches for easier review, but I can squash them to only one patch.
Please do not push these patches I am working in that area and I am completely changed for example the function in patch 2 [1] anyway (and yeah I also noticed princ was not used :)
The other patches are probably going to be in the way as well.
Simo.
[1] http://fedorapeople.org/cgit/simo/public_git/sssd.git/commit/?h=ccname&i...
On (29/08/13 09:17), Simo Sorce wrote:
On Thu, 2013-08-29 at 14:05 +0200, Lukas Slebodnik wrote:
ehlo,
There are some unused function parameters.
I split change to three patches for easier review, but I can squash them to only one patch.
Please do not push these patches I am working in that area and I am completely changed for example the function in patch 2 [1] anyway (and yeah I also noticed princ was not used :)
The other patches are probably going to be in the way as well.
Simo.
[1] http://fedorapeople.org/cgit/simo/public_git/sssd.git/commit/?h=ccname&i...
In this case, feel free to include patches to your work.
LS
On Thu, 2013-08-29 at 16:15 +0200, Lukas Slebodnik wrote:
On (29/08/13 09:17), Simo Sorce wrote:
On Thu, 2013-08-29 at 14:05 +0200, Lukas Slebodnik wrote:
ehlo,
There are some unused function parameters.
I split change to three patches for easier review, but I can squash them to only one patch.
Please do not push these patches I am working in that area and I am completely changed for example the function in patch 2 [1] anyway (and yeah I also noticed princ was not used :)
The other patches are probably going to be in the way as well.
Simo.
[1] http://fedorapeople.org/cgit/simo/public_git/sssd.git/commit/?h=ccname&i...
In this case, feel free to include patches to your work.
ok
Simo.
On (29/08/13 10:22), Simo Sorce wrote:
On Thu, 2013-08-29 at 16:15 +0200, Lukas Slebodnik wrote:
On (29/08/13 09:17), Simo Sorce wrote:
On Thu, 2013-08-29 at 14:05 +0200, Lukas Slebodnik wrote:
ehlo,
There are some unused function parameters.
I split change to three patches for easier review, but I can squash them to only one patch.
Please do not push these patches I am working in that area and I am completely changed for example the function in patch 2 [1] anyway (and yeah I also noticed princ was not used :)
The other patches are probably going to be in the way as well.
Simo.
[1] http://fedorapeople.org/cgit/simo/public_git/sssd.git/commit/?h=ccname&i...
In this case, feel free to include patches to your work.
ok
Simo.
Updated patches are attached.
LS
On Thu, 2013-09-12 at 11:20 +0200, Lukas Slebodnik wrote:
On (29/08/13 10:22), Simo Sorce wrote:
On Thu, 2013-08-29 at 16:15 +0200, Lukas Slebodnik wrote:
On (29/08/13 09:17), Simo Sorce wrote:
On Thu, 2013-08-29 at 14:05 +0200, Lukas Slebodnik wrote:
ehlo,
There are some unused function parameters.
I split change to three patches for easier review, but I can squash them to only one patch.
Please do not push these patches I am working in that area and I am completely changed for example the function in patch 2 [1] anyway (and yeah I also noticed princ was not used :)
The other patches are probably going to be in the way as well.
Simo.
[1] http://fedorapeople.org/cgit/simo/public_git/sssd.git/commit/?h=ccname&i...
In this case, feel free to include patches to your work.
ok
Simo.
Updated patches are attached.
ACK
Simo.
On Thu, Sep 12, 2013 at 11:47:34AM -0400, Simo Sorce wrote:
On Thu, 2013-09-12 at 11:20 +0200, Lukas Slebodnik wrote:
On (29/08/13 10:22), Simo Sorce wrote:
On Thu, 2013-08-29 at 16:15 +0200, Lukas Slebodnik wrote:
On (29/08/13 09:17), Simo Sorce wrote:
On Thu, 2013-08-29 at 14:05 +0200, Lukas Slebodnik wrote:
ehlo,
There are some unused function parameters.
I split change to three patches for easier review, but I can squash them to only one patch.
Please do not push these patches I am working in that area and I am completely changed for example the function in patch 2 [1] anyway (and yeah I also noticed princ was not used :)
The other patches are probably going to be in the way as well.
Simo.
[1] http://fedorapeople.org/cgit/simo/public_git/sssd.git/commit/?h=ccname&i...
In this case, feel free to include patches to your work.
ok
Simo.
Updated patches are attached.
ACK
Simo.
Pushed both to master.
sssd-devel@lists.fedorahosted.org