URL: https://github.com/SSSD/sssd/pull/685 Author: jhrozek Title: #685: Hi, Action: opened
PR body: """ this PR allows the administrator to only restart the KCM service in order to apply changes in sssd.conf's [kcm] section.
I think this would be nice for admins, but the code feels already a bit hackish to me. I think we should keep on working on the static files with the read-only configuration, because then: - we could get rid of the special case to remove the section, because the section would always be there - we could remove different cases for adding/replacing sections - ..and of course the other things like config-show or running with no config file, just snippets
I also didn't enable this functionality for the other responders. I don't know if it makes sense without more testing and in general I don't think there are too many users of socket activated responders except kcm. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/685/head:pr685 git checkout pr685
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
mzidek-rh commented: """ One of the patches generates whitespace warning:
Applying: SYSTEMD: Re-read KCM configuration on systemctl restart kcm .git/rebase-apply/patch:17: trailing whitespace. The sssd-kcm service is typically socket-activated warning: 1 line adds whitespace errors. """
See the full comment at https://github.com/SSSD/sssd/pull/685#issuecomment-435019945
URL: https://github.com/SSSD/sssd/pull/685 Author: jhrozek Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/685/head:pr685 git checkout pr685
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
jhrozek commented: """ The whitespace error should be fixed now. There is also one bug fixed in the tests which I showed Michal during a tmate session. """
See the full comment at https://github.com/SSSD/sssd/pull/685#issuecomment-435374671
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
jhrozek commented: """ ugh, the CI is still failing. Let me check in our internal CI what's up. Changes requested in the meantime. """
See the full comment at https://github.com/SSSD/sssd/pull/685#issuecomment-435376155
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
jhrozek commented: """ the internal CI passed (except one unrelated issue on debian), so let me re-run the centos CI again """
See the full comment at https://github.com/SSSD/sssd/pull/685#issuecomment-435782442
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
jhrozek commented: """ retest this please """
See the full comment at https://github.com/SSSD/sssd/pull/685#issuecomment-435782474
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
jhrozek commented: """ finally, the CI passed. @mzidek-rh can you ack? """
See the full comment at https://github.com/SSSD/sssd/pull/685#issuecomment-435807415
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
mzidek-rh commented: """ ACK. Thanks. """
See the full comment at https://github.com/SSSD/sssd/pull/685#issuecomment-436562376
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
jhrozek commented: """ * master: * 66da9d9db7bd85a17be51af610d9cfbbe4d4391c * fc25224ea1a127081bf342053d1f189c10d3772d * c53fc08a70679b181b0eff6422f199a51d527e67 * 92b8f8d404bfe72abe8cd324f5569be5ba2c6db1 * 4b52ed0610e399a0fe27cfab3601419acb6aff3d * 8007d6150a37c39881418e7f2b32129a5e4cb9e7 """
See the full comment at https://github.com/SSSD/sssd/pull/685#issuecomment-436769575
URL: https://github.com/SSSD/sssd/pull/685 Author: jhrozek Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/685/head:pr685 git checkout pr685
URL: https://github.com/SSSD/sssd/pull/685 Title: #685: Allow re-reading kcm configuration by just restarting the sssd-kcm service
Label: +Pushed
sssd-devel@lists.fedorahosted.org