[PATCH] Make PAM responses more compatible with D-BUS spec

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Previously, the PAM responses could contain an arbitrary number of
arguments. This is not acceptable by the D-BUS protocol, as there
is no way to introspect it. This patch converts the response
objects to be an array of D-BUS structs.

It also fixes two potential memory leaks by not unref'ing the
reply object if we get an error.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkt1vmAACgkQeiVVYja6o6PAXACfRVdVlc0/L8/on2sjAh7fKSXM
> PowAoJgRVQUcxMvGnj/FkrJZRegZYNbh
> =oX+3
> -----END PGP SIGNATURE-----

[Sumit Bose]

On Fri, Feb 12, 2010 at 03:47:28PM -0500, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Previously, the PAM responses could contain an arbitrary number of
> arguments. This is not acceptable by the D-BUS protocol, as there
> is no way to introspect it. This patch converts the response
> objects to be an array of D-BUS structs.
>
> It also fixes two potential memory leaks by not unref'ing the
> reply object if we get an error.
>
> Stephen Gallagher
> RHCE 804006346421761
>
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkt1vmAACgkQeiVVYja6o6PAXACfRVdVlc0/L8/on2sjAh7fKSXM
> PowAoJgRVQUcxMvGnj/FkrJZRegZYNbh
> =oX+3
> -----END PGP SIGNATURE-----

ACK

bye,
Sumit

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/15/2010 07:58 AM, Sumit Bose wrote:
> On Fri, Feb 12, 2010 at 03:47:28PM -0500, Stephen Gallagher wrote:
> Previously, the PAM responses could contain an arbitrary number of
> arguments. This is not acceptable by the D-BUS protocol, as there
> is no way to introspect it. This patch converts the response
> objects to be an array of D-BUS structs.
>
> It also fixes two potential memory leaks by not unref'ing the
> reply object if we get an error.
> ACK

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkt5SlwACgkQeiVVYja6o6PglwCeMImpwEzcM56SURXUI+HaJuns
> ivkAn3ahf6ClNKH6xAzFScEXIx7itdmT
> =d8V2
> -----END PGP SIGNATURE-----