URL:
https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes
lslebodn commented:
"""
On (02/05/17 02:57), fidencio wrote:
- SPEC: Update processing of translation in %install - ACK
- SPEC: Move systemd service sssd-ifp.service to right package - Please, remove the
"Explanation" word from the commit message
- SPEC: Add missing scriptlets for package sssd-dbus - ACK
- SPEC: Use correct package for translated sssd-ifp man page - ACK
- SPEC: Move man page for sss_rpcidmapd to the right package - ACK
- SPEC: Use correct package for translated sss_ssh* man pages - ACK
- SPEC: Use correct package for translated sssctl man pages - ACK
- SPEC: Use correct package for translated idmap_sss man pages - ACK
- SPEC: Use correct package for translated sss_certmap man pages - ACK
- SPEC: Use correct package for translated sssd-kcm man pages - ACK
- SPEC: Move files provider files within package - Please, first line of the commit
message fits in the 74 chars, no need to put it in a different line
- SPEC: Move kcm scriptlets to systemd section - ACK
- SPEC: Call ldconfig in libsss_certmap scriptlets - ACK
- SPEC: Use macro python_provide conditionally - There are a few typos in the commit
message:
- This is a reason -> This is the reason
- defind -> defined
- This is a reason why it need to be use conditionaly (...) -> This is the reason
why it has to be used conditionally (...)
- SPEC: Use %license macro - In which Fedora/CentOS version we have it introduced?
I'm just asking to be sure it won't cause any issue with people building our git
master with ancient (but still supported) systems.
The rpm macro %license was introduced in rpm-4.11.0[1]
and rpm-4.11.1 was in rhel7.0. (In fedora it is there since f19)
But the latest patch provides fallback implementation for el6.
[1]
http://rpm.org/wiki/Releases/4.11.0
"""
See the full comment at
https://github.com/SSSD/sssd/pull/191#issuecomment-298652684