[sssd PR#191][opened] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Author: lslebodn
 Title: #191: Few spec file fixes
Action: opened

PR body:
"""
Mostly related to https://pagure.io/SSSD/sssd/issue/3327
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/191/head:pr191
git checkout pr191

[sssd PR#191][synchronized] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Author: lslebodn
 Title: #191: Few spec file fixes
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/191/head:pr191
git checkout pr191

[sssd PR#191][synchronized] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Author: lslebodn
 Title: #191: Few spec file fixes
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/191/head:pr191
git checkout pr191

[sssd PR#191][comment] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

lslebodn commented:
"""
http://sssd-ci.duckdns.org/logs/job/64/40/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/191#issuecomment-285725610

[sssd PR#191][synchronized] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Author: lslebodn
 Title: #191: Few spec file fixes
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/191/head:pr191
git checkout pr191

[sssd PR#191][comment] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

lslebodn commented:
"""
Patches were updated due to sssd-kcm and libsss_certmap.
"""

See the full comment at https://github.com/SSSD/sssd/pull/191#issuecomment-292531702

[sssd PR#191][comment] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

lslebodn commented:
"""
http://sssd-ci.duckdns.org/logs/job/67/57/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/191#issuecomment-292553972

[sssd PR#191][synchronized] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Author: lslebodn
 Title: #191: Few spec file fixes
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/191/head:pr191
git checkout pr191

[sssd PR#191][comment] Few spec file fixes

[fidencio]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

fidencio commented:
"""
-  SPEC: Update processing of translation in %install - ACK
-  SPEC: Move systemd service sssd-ifp.service to right package - Please, remove the "Explanation" word from the commit message
-  SPEC: Add missing scriptlets for package sssd-dbus - ACK
-  SPEC: Use correct package for translated sssd-ifp man page - ACK
-  SPEC: Move man page for sss_rpcidmapd to the right package - ACK
-  SPEC: Use correct package for translated sss_ssh* man pages - ACK
-  SPEC: Use correct package for translated sssctl man pages - ACK
-  SPEC: Use correct package for translated idmap_sss man pages - ACK
-  SPEC: Use correct package for translated sss_certmap man pages - ACK
-  SPEC: Use correct package for translated sssd-kcm man pages - ACK
-  SPEC: Move files provider files within package - Please, first line of the commit message fits in the 74 chars, no need to put it in a different line
-  SPEC: Move kcm scriptlets to systemd section - ACK
-  SPEC: Call ldconfig in libsss_certmap scriptlets - ACK
-  SPEC: Use macro python_provide conditionally - There are a few typos in the commit message:
    - This is a reason -> This is the reason
    - defind -> defined
    - This is a reason why it need to be use conditionaly (...) -> This is the reason why it has to be used conditionally (...)
  -  SPEC: Use %license macro - In which Fedora/CentOS version we have it introduced? I'm just asking to be sure it won't cause any issue with people building our git master with ancient (but still supported) systems.
"""

See the full comment at https://github.com/SSSD/sssd/pull/191#issuecomment-298585647

[sssd PR#191][+Changes requested] Few spec file fixes

[fidencio]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

Label: +Changes requested

[sssd PR#191][comment] Few spec file fixes

[fidencio]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

fidencio commented:
"""
Setting the label "Changes requested" accordingly to the review.

Thanks for the patch set, quite nice one!
"""

See the full comment at https://github.com/SSSD/sssd/pull/191#issuecomment-298585950

[sssd PR#191][synchronized] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Author: lslebodn
 Title: #191: Few spec file fixes
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/191/head:pr191
git checkout pr191

[sssd PR#191][comment] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

lslebodn commented:
"""
On (02/05/17 02:57), fidencio wrote:
> SPEC: Update processing of translation in %install - ACK
> SPEC: Move systemd service sssd-ifp.service to right package - Please, remove the "Explanation" word from the commit message
> SPEC: Add missing scriptlets for package sssd-dbus - ACK
> SPEC: Use correct package for translated sssd-ifp man page - ACK
> SPEC: Move man page for sss_rpcidmapd to the right package - ACK
> SPEC: Use correct package for translated sss_ssh* man pages - ACK
> SPEC: Use correct package for translated sssctl man pages - ACK
> SPEC: Use correct package for translated idmap_sss man pages - ACK
> SPEC: Use correct package for translated sss_certmap man pages - ACK
> SPEC: Use correct package for translated sssd-kcm man pages - ACK
> SPEC: Move files provider files within package - Please, first line of the commit message fits in the 74 chars, no need to put it in a different line
> SPEC: Move kcm scriptlets to systemd section - ACK
> SPEC: Call ldconfig in libsss_certmap scriptlets - ACK
> SPEC: Use macro python_provide conditionally - There are a few typos in the commit message:
> This is a reason -> This is the reason
> defind -> defined
> This is a reason why it need to be use conditionaly (...) -> This is the reason why it has to be used conditionally (...)
> SPEC: Use %license macro - In which Fedora/CentOS version we have it introduced? I'm just asking to be sure it won't cause any issue with people building our git master with ancient (but still supported) systems.

The rpm macro %license was introduced in rpm-4.11.0[1]
and rpm-4.11.1 was in rhel7.0. (In fedora it is there since f19)

But the latest patch provides fallback implementation for el6.

[1] http://rpm.org/wiki/Releases/4.11.0

"""

See the full comment at https://github.com/SSSD/sssd/pull/191#issuecomment-298652684

[sssd PR#191][comment] Few spec file fixes

[fidencio]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

fidencio commented:
"""
-  SPEC: Move files provider files within package - There's a typo in the commit message that I didn't notice before (sorry). it simplify -> It simplifies ... 
-  SPEC: Use %license macro - In the patch ... "must be define alter ..." -> "must be defined after ..."

Please, just change those typos before pushing, there's no need to resend the series because of this change.
"""

See the full comment at https://github.com/SSSD/sssd/pull/191#issuecomment-298717186

[sssd PR#191][-Changes requested] Few spec file fixes

[fidencio]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

Label: -Changes requested

[sssd PR#191][+Accepted] Few spec file fixes

[fidencio]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

Label: +Accepted

[sssd PR#191][comment] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

lslebodn commented:
"""
> SPEC: Use %license macro - In the patch ... "must be define alter ..." -> "must be defined after ..."

I found another typo in this patch `occurence` vs `occurrence`

master:
* 708f0497d1bdb2c0ec100587796b90f22971c698
* 1cfbec5668a283bf078ac4a8e168e8bd16b74dbf
* 9055ed29ae58ad2f2123880edd41b1905813a5d7
* fa1cea86740dd7217bb733eb845f1da7095ccfa6
* 8bbe26cfc686eae35c99899314c15016b2cce817
* 8843feb6f2fa0b3922599c5ed347b64121e674fc
* 2915214bab5a1ce26119c462b2e1dc7d05a850ee
* b2175f271d834bb416960ab270db1b02c62093af
* fc57f91b4ecccd594ef18387a99519257a675d57
* 60327984ab2bcf2fae73dff50f0bb919dc20219e
* e821ed50711b5c683363ae2e812f3cc8b6395ed1
* dd71288719d98038b9a2f008f30bbcbbf8e67ed5
* 1b1a89c2866413776f7bdf2d76064e206cc4756c
* ffa05d220218db1a293ead23430144954af8deab
* 386a978207d8f8ad67d2df5fa29a8714d46c30c4
"""

See the full comment at https://github.com/SSSD/sssd/pull/191#issuecomment-298879179

[sssd PR#191][+Pushed] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Title: #191: Few spec file fixes

Label: +Pushed

[sssd PR#191][closed] Few spec file fixes

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/191
Author: lslebodn
 Title: #191: Few spec file fixes
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/191/head:pr191
git checkout pr191