Do not start multiple backends for the same domain

[Pavel Reichl]

Hello,

please see attached patch.

PR

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/16/2014 12:11 PM, Pavel Reichl wrote:
>  Hello,
>  
>  please see attached patch.
>   
I'd prefer if this was logged as a fatal failure (and logged to
syslog) and then failed to start up. Ignoring it silently may lead to
domains being checked in inconsistent order (they might be earlier in
the list to check than expected).

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iEYEARECAAYFAlLYFLYACgkQeiVVYja6o6NRQwCgonzyBiAZHsYQk/oD2hWAzz0V
> 9IMAnRfYv8Ty0Wa2Cinej/e8Qfcy/Dmv
> =zOfJ
> -----END PGP SIGNATURE-----

[Pavel Reichl]

On Thu, 2014-01-16 at 12:19 -0500, Stephen Gallagher wrote:
>  On 01/16/2014 12:11 PM, Pavel Reichl wrote:
>  > Hello,
>  > 
>  > please see attached patch.
>  > 
>  
>  I'd prefer if this was logged as a fatal failure (and logged to
>  syslog) and then failed to start up. Ignoring it silently may lead to
>  domains being checked in inconsistent order (they might be earlier in
>  the list to check than expected).
>   
Hello Stephen,

thanks for review. New patch addressing your concerns is attached.

PR

[Jakub Hrozek]

On Fri, Jan 17, 2014 at 03:40:35PM +0100, Pavel Reichl wrote:
>  +                DEBUG(SSSDBG_FATAL_FAILURE,
>  +                      ("Domain '%s' has too similar name to domain
> '%s'.\n",
>  +                       domlist[i], domain->name));
>  +                sss_log(SSS_LOG_CRIT,
>  +                        "Domain '%s' has too similar name to domain
> '%s'.\n",
>  +                        domlist[i], domain->name); 
I think we can just say that 'dom X differs from dom Y in case only'
unless we plan on adding more similar checks later.

[Pavel Reichl]

On Fri, 2014-01-17 at 19:47 +0100, Jakub Hrozek wrote:
>  On Fri, Jan 17, 2014 at 03:40:35PM +0100, Pavel Reichl wrote:
>  > +                DEBUG(SSSDBG_FATAL_FAILURE,
>  > +                      ("Domain '%s' has too similar name to domain
> '%s'.\n",
>  > +                       domlist[i], domain->name));
>  > +                sss_log(SSS_LOG_CRIT,
>  > +                        "Domain '%s' has too similar name to domain
> '%s'.\n",
>  > +                        domlist[i], domain->name);
>  
>  I think we can just say that 'dom X differs from dom Y in case only'
>  unless we plan on adding more similar checks later.
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sssd-devel 
Hello Jakub,

I updated the string as you suggested.

BTW I was wondering if it is OK if I stored this string into local
constant variable and used it in both DEBUG and sss_log as I hate code
duplication on every level:-).

PR

[Pavel Reichl]

On Mon, 2014-01-20 at 18:07 +0100, Pavel Reichl wrote:
>  On Fri, 2014-01-17 at 19:47 +0100, Jakub Hrozek wrote:
>  > On Fri, Jan 17, 2014 at 03:40:35PM +0100, Pavel Reichl wrote:
>  > > +                DEBUG(SSSDBG_FATAL_FAILURE,
>  > > +                      ("Domain '%s' has too similar name to
> domain '%s'.\n",
>  > > +                       domlist[i], domain->name));
>  > > +                sss_log(SSS_LOG_CRIT,
>  > > +                        "Domain '%s' has too similar name to
> domain '%s'.\n",
>  > > +                        domlist[i], domain->name);
>  > 
>  > I think we can just say that 'dom X differs from dom Y in case only'
>  > unless we plan on adding more similar checks later.
>  > _______________________________________________
>  > sssd-devel mailing list
>  > sssd-devel(a)lists.fedorahosted.org
>  > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>  
>  Hello Jakub,
>  
>  I updated the string as you suggested.
>  
>  BTW I was wondering if it is OK if I stored this string into local
>  constant variable and used it in both DEBUG and sss_log as I hate code
>  duplication on every level:-).
>  
>  PR
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sssd-devel 
Sorry I attached previously wrong patch.

[Pavel Reichl]

Hello,

in another thread Stephen Gallagher asked me to use static string to
avoid code duplication. I've considered same thing for this patch in
previous mail but probably nobody noticed. 

So I did it now. Please see new patch.

PR

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/06/2014 04:50 PM, Pavel Reichl wrote:
>  Hello,
>  
>  in another thread Stephen Gallagher asked me to use static string
>  to avoid code duplication. I've considered same thing for this
>  patch in previous mail but probably nobody noticed.
>  
>  So I did it now. Please see new patch.
>   
Looks just about right. One minor grammar change:

"Domain '%s' is the same *as* or differs..."


> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iEYEARECAAYFAlLzs5kACgkQeiVVYja6o6PM/gCgqGOxMdpAWxWucjDfpNSMIsjz
> g58AoJfGyFQ0Loqs3VozXrjT0cIWM9+/
> =n7Yg
> -----END PGP SIGNATURE-----

[Pavel Reichl]

On Thu, 2014-02-06 at 17:08 +0100, Stephen Gallagher wrote:
>  On 02/06/2014 04:50 PM, Pavel Reichl wrote:
>  > Hello,
>  > 
>  > in another thread Stephen Gallagher asked me to use static string
>  > to avoid code duplication. I've considered same thing for this
>  > patch in previous mail but probably nobody noticed.
>  > 
>  > So I did it now. Please see new patch.
>  > 
>  
>  Looks just about right. One minor grammar change:
>  
>  "Domain '%s' is the same *as* or differs..."
>  
>  
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sssd-devel 
Hello, 

thank for quick review. Fixed patch is attached.

PR

[Stephen Gallagher]

----- Original Message -----
From: "Pavel Reichl" <preichl(a)redhat.com&gt;
To: sssd-devel(a)lists.fedorahosted.org
Sent: Thursday, February 6, 2014 5:22:42 PM
Subject: Re: [SSSD] Do not start multiple backends for the same domain

On Thu, 2014-02-06 at 17:08 +0100, Stephen Gallagher wrote:
>  On 02/06/2014 04:50 PM, Pavel Reichl wrote:
>  > Hello,
>  > 
>  > in another thread Stephen Gallagher asked me to use static string
>  > to avoid code duplication. I've considered same thing for this
>  > patch in previous mail but probably nobody noticed.
>  > 
>  > So I did it now. Please see new patch.
>  > 
>  
>  Looks just about right. One minor grammar change:
>  
>  "Domain '%s' is the same *as* or differs..."
>   
Hello, 

thank for quick review. Fixed patch is attached.




Ack

[Jakub Hrozek]

On Sun, 2014-02-09 at 06:09 -0500, Stephen Gallagher wrote:
>  Hello, 
>  
>  thank for quick review. Fixed patch is attached.
>  
>  
>  
>  
>  Ack 
Pushed to master.