[stratis-devel] Re: Options for dealing with devicemapper context
On 03/19/2018 12:18 PM, Andy Grover wrote:
On 03/19/2018 10:02 AM, Andy Grover wrote:
>> On 03/19/2018 11:02 AM, Tony Asleson wrote:
>>> My preference is what you refer to as class II, with placing much of
>>> the
>>> base functionality into devicemapper.rs and limiting or removing dm
>>> reference passing to functions and methods.
I also like II, but I'm not convinced of the benefits of implementing
this in dm-rs rather than just in stratisd. If stratisd uses DM so much
we want to make it a singleton that's cool, but is it useful for other
users of dm? (Hard to say, since there are currently no other users.)
Adding singleton functionality to devicemapper.rs doesn't require end
library users to utilize, at least from what I was thinking WRT
implementation. I see this as an addition to the API, not a replacement
or API feature removal. Nothing should prevent a user from utilizing
the API as it is today and instantiating and using a dm context as
before, but I haven't looked closely at any proposed changes to dm to
support this yet to see if this is indeed true.
Regards,
Tony