The VPN role allows for the user to specify a hostname or an IP address
for the connection
https://github.com/linux-system-roles/vpn/pull/2#pullrequestreview-538046482
I wanted to open this discussion up to a wider audience.
We have some precedence in system roles for a field that can take a
hostname or IP address. The logging role has a field `server_host` in
the elasticsearch and relp outputs
https://github.com/linux-system-roles/logging/blob/master/README.md#logging…
- The documentation says "Host name" but this can be an IP address.
Also the `target` field for the forwards output - it says "Target host
(fqdn)." but it can be an IP address.
The metrics role has
https://github.com/linux-system-roles/metrics/blob/master/README.md#role-va…
`metrics_monitored_hosts` which I believe takes IP addresses as well as
hostnames.
There may be other examples in some of the other roles
Does it matter what is the name that the VPN role uses for this field?
Is `host` ok?
We are currently having a problem with Travis CI. You may have noticed
that your recent PRs are not being tested with Travis, that they seem
never to start. I think that is my fault for not signing up for the
open-source plan for linux-system-roles earlier. I have done so, but I
have no idea when they will respond.
In the meantime, I have been investigating using Github Actions.
https://github.com/linux-system-roles/ci-testing/pull/3
Here is the workflow definition file:
https://github.com/linux-system-roles/ci-testing/blob/06d3f91151bcd7de1a5d2…
There was a good bit of hackery to support py26 since Github Actions
Workflows (actions/setup-python@v2) doesn't support it natively.
The other missing piece is tox-travis, which allows you to have fine
grained control of which tox tests are run for a specific version of
python. So right now we run all of the default tox jobs for all of the
python versions (e.g. we run black, flake8, etc. on all versions of
python). If we wanted to do the same in GHA, we would have to define an
explicit job for each version of python (instead of using the matrix
feature) - AFAIK (I'm quite new to GA so if anyone has a better way to
do this, let me know). IMO this is not a blocker to move to GHA.
What do you think?