On 09/22/2016 10:23 AM, Ritesh Raj Sarraf wrote:
On Sun, 2016-09-18 at 20:00 +0200, Christophe Vu-Brugier wrote:
>
>> That all said, there's one major issue that isn't resolved here:
>
> There's no startup logic! I see neither init script nor systemd
> service file. There was something upstream (that was minimally
> patched in Debian) in the old version, but that's gone now, as
> far as I can tell. In that case, the correct course of action for
> Debian packaging would be to add this in the debian/ directory and
> install it from there. I don't have time to fix that today, and I
> think this is something that can wait until after the packaging
> is imported into Alioth. But just to keep in mind that this needs
> to be done before the package can enter Debian.
As you observe, there is no startup logic in targetcli-fb. The startup
logic is provided by rtslib-fb which contains a utility named
"targetctl".
I may not be well up on the conversation, but could you please be specific on
what startup logic is not more in the new repos ?
The Datera init script ensured that the supporting infrastructure was enabled
and active. Like configfs, kernel modules etc.
Given that LIO is a service, wouldn't you want it to act that way ?
rtslib-fb loads modules (if needed) and mounts configfs (if it isn't
already) so the init script should be just calling 'targetctl restore'.
HTH -- Regards -- Andy