Hi Ritesh,
On Fri, 26 Aug 2016 15:04:03 +0200, Christophe Vu-Brugier wrote :
On Wed, 24 Aug 2016 14:32:38 +0530, Ritesh Raj Sarraf wrote :
> You can contribute to the upstream repo. We'll have a look when we work on it
> again.
I created a pull request upstream on GitHub:
https://github.com/open-iscsi/configshell-fb/pull/25
I wrote similar patches to improve Debian packaging in targetcli-fb as
well:
https://github.com/open-iscsi/targetcli-fb/pull/68
Did you have the opportunity to look at the changes? Are these changes
good enough to be part of the configshell-fb and targetcli-fb packages
you maintain for Debian?
With best regards,
There are some questions left in the pull request that I copy paste
here. Feel free to join the discussion on GitHub or discuss the changes
by email.
With best regards,
===
The purpose of this patch serie is to improve our Debian packaging so
that Debian can leverage our work to properly integrate configshell-fb.
Most of the patches are inspired by what @thomasgoirand did to package
rtslib-fb in Debian.
To @agrover, please do not merge my patches immediately because I would
like @rickysarraf to have enough time to review my changes.
The changes are quite straightforward. I will just describe what is
missing and what Debian developers may do in addition.
# Parts that should be discussed
## Content of debian/copyright
The copyright file should be updated. As reported by `lintian`, the
format is wrong and should follow the [Debian copyright
format](http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/).
More importantly, the content is probably wrong but I am not sure who
the copyright holders are and what to put exactly in this file. Some
help would be appreciated.
## Version in debian/changelog
Upstream version numbers in rtslib-fb, configshell-fb and targetcli-fb
follow this scheme: **X.Y.fbZ**. However, the rtslib-fb package in
Debian drops the **fb** string from the version number (e.g. version
**2.1.57** instead of **2.1.fb57**).
I did the same in configshell-fb's fake changelog, but I have no strong
opinion.
## Presence of the debian directory upstream
The Debian package maintainer of rtslib-fb reported that having a
debian directory upstream causes [some pain to Debian
packagers](https://github.com/open-iscsi/rtslib-fb/issues/59)
For now, I think it is easier to keep the debian directory until the
configshell-fb package lands in Debian stable or testing. At that
point, we may instruct people to simply use or rebuild Debian packages
and rename or remove the debian directory.
# Parts that are not included and that Debian packagers should add
## Vcs-Browser and Vcs-Git in debian/control
Our upstream control file does not contain Vcs-Browser and Vcs-Git tags
but the final control file in Debian should have them pointing to
anonscm.debian.org.
## Git-buildpackage configuration file
There is no **gbp.conf** file in this patch serie since it makes no
sense upstream.
===
--
Christophe Vu-Brugier