Re: Debian packaging: targetcli-fb review (was: Re: Debian packaging: plan)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On Sun, 2016-09-18 at 20:00 +0200, Christophe Vu-Brugier wrote:
> That all said, there's one major issue that isn't resolved here:
There's no startup logic! I see neither init script nor systemd
service file. There was something upstream (that was minimally
patched in Debian) in the old version, but that's gone now, as
far as I can tell. In that case, the correct course of action for
Debian packaging would be to add this in the debian/ directory and
install it from there. I don't have time to fix that today, and I
think this is something that can wait until after the packaging
is imported into Alioth. But just to keep in mind that this needs
to be done before the package can enter Debian.
As you observe, there is no startup logic in targetcli-fb. The startup
logic is provided by rtslib-fb which contains a utility named
"targetctl".
I may not be well up on the conversation, but could you please be specific on
what startup logic is not more in the new repos ?
The Datera init script ensured that the supporting infrastructure was enabled
and active. Like configfs, kernel modules etc.
Given that LIO is a service, wouldn't you want it to act that way ?
- --
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCgAGBQJX5BOgAAoJEKY6WKPy4XVp5J8P/jF/WOSi88niGW2lfux1R8EF
P+JMdtYD5Gm8bY2ewEKOPOHbG69VGn0QvyIHHTN5HVYO+3xSM9GS01AYCrHikgHO
2b661/6ssFCALu4CsC24EyZglQx0lBRUFY1Z0FfGUVoBQaNBSYa9tkrkZJDtGQyx
GYTGHnVurUVMxkHcjTnKlfqQxRaAs3n/fGY0FDzyJpaCumtQO+4sU2w53WuRbKIn
iIsl0vJ09rGhMdefziddLEr2JQ5ECf3d0yxX8Y2sPwGZ1Q4A+JspVqDkQyFBv0I9
sc7TRNJAPK9sIDxzjhEQwwAsz4d4wYPR34C0+6eoB+ezJpHXjewUfcZzBwLV6xGi
WFaP8cbv+YzGCInyR3aYEBPRUj9ceIlgSbRcaclHDfa3DthlzGZPZAeHjdEJHQMw
mCoGvfwPz7J875FDt65k6GRk4k3RVylmvmhtWafAhkkvB4IRZatqn9RrqhHLnB46
n+vmp+2ZiBV7MDNLGAazzabCOtl0Rbde88cJaD9fbzKdBESou4FauchkJFKG1YJl
fVrRnzQ2mgtN3teNF34mCXXslVLHot0SojAJXDXDIe09hU1O1sg9Xkjo+AjjFnu9
1sr2QW/x140U2WD6uosPHu0cjo1mTs9TtjHMOmn9m33ZNZQoITlnKcJwj+r6IC6b
870l2K4OGK/fg3oVQjPw
=43AW
-----END PGP SIGNATURE-----