[PATCH v2 0/7] tuna gui porting to Gtk 3.0

[Federico Pellegrin]

Hi all,
I've made some effort to make the tuna gui work properly with Gtk 3.0
(tested using CentOS 8.x) and additionally included also some fixes that
are related to the porting to Python 3.
As far as I can see now the situation is much better and the UI is pretty
much usable. Probably some other details may come out (I will keep fixing
while finding other details during usage) but I think applying those could
already make the tool very well usable now.

Hope they are fine and can be merged!

Thanks!
Federico


Federico Pellegrin (7):
  tuna: multiple fixes for Gtk-3.0 UI interface
  config: make configuration files consistently text only
  profileview: disable cursor_changed handler when manipulating list
  cpuview: a few more improvements for Gtk 3.0
  tuna_gui: handle destroy handler to prevent error messages on startup
  tuna: fix mnemonic accelerators for Gtk 3.0
  profileview: fix text entry retrieval

 tuna/config.py          |  4 ++--
 tuna/gui/commonview.py  | 13 +++++++------
 tuna/gui/cpuview.py     | 29 +++++++++++++----------------
 tuna/gui/irqview.py     | 11 ++++++-----
 tuna/gui/procview.py    | 24 ++++++++++++------------
 tuna/gui/profileview.py | 19 +++++++++++++------
 tuna/tuna.py            |  2 +-
 tuna/tuna_gui.glade     |  7 +++----
 tuna/tuna_gui.py        |  4 +++-
 9 files changed, 60 insertions(+), 53 deletions(-)

-- 
2.26.2

[PATCH v2 1/7] tuna: multiple fixes for Gtk-3.0 UI interface

[Federico Pellegrin]

Multiple fixes to make tuna compatible with Gtk-3.0 library. The UI
should be now mostly working, some warnings are still present and
may be still addressed in the future.

Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
---
 tuna/gui/commonview.py  | 13 +++++++------
 tuna/gui/cpuview.py     | 15 ++++++---------
 tuna/gui/irqview.py     |  5 +++--
 tuna/gui/procview.py    |  6 +++---
 tuna/gui/profileview.py |  8 ++++----
 tuna/tuna.py            |  2 +-
 tuna/tuna_gui.glade     |  6 +++---
 tuna/tuna_gui.py        |  2 +-
 8 files changed, 28 insertions(+), 29 deletions(-)

diff --git a/tuna/gui/commonview.py b/tuna/gui/commonview.py
index 59ca244..cc8f913 100644
--- a/tuna/gui/commonview.py
+++ b/tuna/gui/commonview.py
@@ -13,9 +13,9 @@ class commonview:
 
     def cleanUp(self):
         for value in self.contentTable.get_children():
-            if value.get_name() == "controls":
+            if Gtk.Buildable.get_name(value) == "controls":
                 self.ctrl = value
-            if value.get_name() == "profileSelectorBox":
+            if Gtk.Buildable.get_name(value) == "profileSelectorBox":
                 self.selector = value
             self.contentTable.remove(value)
 
@@ -79,12 +79,13 @@ class commonview:
                         # scale control
                         frameContent[catCntr]['texts'][contentCntr] =
Gtk.HScale()
                        
frameContent[catCntr]['texts'][contentCntr].set_range(self.config.ctlGuiParams[catCntr][val][0],
self.config.ctlGuiParams[catCntr][val][1])
-                       
frameContent[catCntr]['texts'][contentCntr].set_update_policy(Gtk.UPDATE_CONTINUOUS)
+                       
#frameContent[catCntr]['texts'][contentCntr].set_update_policy(Gtk.UPDATE_CONTINUOUS)
                        
frameContent[catCntr]['texts'][contentCntr].set_value(int(self.config.ctlParams[catCntr][val]))
                        
frameContent[catCntr]['texts'][contentCntr].set_digits(0)
                     else:
                         # input field
-                        frameContent[catCntr]['texts'][contentCntr] =
Gtk.Entry(256)
+                        frameContent[catCntr]['texts'][contentCntr] =
Gtk.Entry()
+                       
frameContent[catCntr]['texts'][contentCntr].set_max_length(256)
                        
frameContent[catCntr]['texts'][contentCntr].set_alignment(0)
                        
frameContent[catCntr]['texts'][contentCntr].set_text(self.config.ctlParams[catCntr][val])
                    
frameContent[catCntr]['texts'][contentCntr].connect("button-release-event",
self.checkStar, catCntr, contentCntr, val,
frameContent[catCntr]['labels'][contentCntr])
@@ -105,7 +106,7 @@ class commonview:
         self.ret = {}
         self.property_cntr = 0
         for value in self.contentTable.get_children():
-            if value.get_name() == "controls" or value.get_name() ==
"profileSelectorBox":
+            if Gtk.Buildable.get_name(value) == "controls" or
Gtk.Buildable.get_name(value) == "profileSelectorBox":
                 continue
             self.ret[value.get_label()] = {}
             for content in value:
@@ -128,7 +129,7 @@ class commonview:
         self.ret = {}
         self.property_cntr = 0
         for value in self.contentTable.get_children():
-            if value.get_name() == "controls" or value.get_name() ==
"profileSelectorBox":
+            if Gtk.Buildable.get_name(value) == "controls" or
Gtk.Buildable.get_name(value) == "profileSelectorBox":
                 continue
             self.ret[value.get_label()] = {}
             for content in value:
diff --git a/tuna/gui/cpuview.py b/tuna/gui/cpuview.py
index ec19149..7f00bf5 100755
--- a/tuna/gui/cpuview.py
+++ b/tuna/gui/cpuview.py
@@ -47,10 +47,9 @@ class cpu_socket_frame(Gtk.Frame):
 
     def __init__(self, socket, cpus, creator):
 
+        GObject.GObject.__init__(self)
         if creator.nr_sockets > 1:
-            GObject.GObject.__init__(self, _("Socket %s") % socket)
-        else:
-            GObject.GObject.__init__(self)
+            self.set_label(_("Socket %s") % socket)
 
         self.socket = socket
         self.cpus = cpus
@@ -268,7 +267,7 @@ class cpuview:
             columns = math.ceil(math.sqrt(self.nr_sockets))
             rows = math.ceil(self.nr_sockets / columns)
             box = Gtk.HBox()
-            vbox.pack_start(box, True, True)
+            vbox.pack_start(box, True, True, 0)
         else:
             box = vbox
 
@@ -281,7 +280,7 @@ class cpuview:
             if self.nr_sockets > 1:
                 if column == columns:
                     box = Gtk.HBox()
-                    vbox.pack_start(box, True, True)
+                    vbox.pack_start(box, True, True, 0)
                     column = 1
                 else:
                     column += 1
@@ -298,10 +297,8 @@ class cpuview:
         req = frame.get_preferred_size()
         # FIXME: what is the slack we have
         # to add to every row and column?
-        #width = req[0] + 16
-        width = 16
-        #height = req[1] + 20
-        height = 20
+        width = req.minimum_size.width + 16
+        height = req.minimum_size.height + 40
         if self.nr_sockets > 1:
             width *= columns
             height *= rows
diff --git a/tuna/gui/irqview.py b/tuna/gui/irqview.py
index ea5c2f5..fddb977 100755
--- a/tuna/gui/irqview.py
+++ b/tuna/gui/irqview.py
@@ -20,7 +20,8 @@ class irq_druid:
         self.irqs = irqs
         self.ps = ps
         self.irq = irq
-        self.window = Gtk.Builder(gladefile)
+        self.window = Gtk.Builder()
+        self.window.add_objects_from_file(gladefile, ("set_irq_attributes",
"tuna"))
         #self.window = Gtk.glade.XML(gladefile, "set_irq_attributes",
"tuna")
         self.dialog = self.window.get_object("set_irq_attributes")
         pixbuf = self.dialog.render_icon(Gtk.STOCK_PREFERENCES,
@@ -322,7 +323,7 @@ class irqview:
         setattr.show()
         refresh.show()
 
-        menu.popup(None, None, None, event.button, event.time)
+        menu.popup(None, None, None, event, event.button, event.time)
 
     def toggle_mask_cpu(self, cpu, enabled):
         if not enabled:
diff --git a/tuna/gui/procview.py b/tuna/gui/procview.py
index f897fdd..d2abc13 100755
--- a/tuna/gui/procview.py
+++ b/tuna/gui/procview.py
@@ -1,4 +1,5 @@
 import re
+import os
 import tuna.tuna_sched as tuna_sched
 
 import gi
@@ -29,7 +30,7 @@ class process_druid:
         self.pid_info = pid_info
         self.nr_cpus = nr_cpus
         self.window = Gtk.Builder()
-        self.window.add_from_file(gladefile)
+        self.window.add_objects_from_file(gladefile, ("set_process_attributes",
"tuna"))
 #        self.window = Gtk.glade.XML(gladefile, "set_process_attributes",
"tuna")
         self.dialog = self.window.get_object("set_process_attributes")
         pixbuf = self.dialog.render_icon(Gtk.STOCK_PREFERENCES,
@@ -410,7 +411,6 @@ class procview:
             pass
 
         new_value[self.COL_CMDLINE] = procfs.process_cmdline(thread_info)
-
         gui.set_store_columns(self.tree_store, iter, new_value)
 
     def show(self, force_refresh=False):
@@ -671,7 +671,7 @@ class procview:
         uthreads.show()
         help.show()
 
-        menu.popup(None, None, None, event.button, event.time)
+        menu.popup(None, None, None, event, event.button, event.time)
 
     def toggle_mask_cpu(self, cpu, enabled):
         if not enabled:
diff --git a/tuna/gui/profileview.py b/tuna/gui/profileview.py
index 4f68bf4..c65f92e 100644
--- a/tuna/gui/profileview.py
+++ b/tuna/gui/profileview.py
@@ -87,7 +87,7 @@ class profileview:
             temp = f.read()
             f.close()
             self.profileContentBuffer = self.profileContent.get_buffer()
-            buff =
self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
self.profileContentBuffer.get_end_iter())
+            buff =
self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
self.profileContentBuffer.get_end_iter(), False)
             if temp != buff:
                 dialog = Gtk.MessageDialog(None, \
                     Gtk.DialogFlags.MODAL \
@@ -114,14 +114,14 @@ class profileview:
     def on_SaveButton_clicked(self, widget):
         try:
             self.profileContentBuffer = self.profileContent.get_buffer()
-            self.config.cache =
self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
self.profileContentBuffer.get_end_iter())
+            self.config.cache =
self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
self.profileContentBuffer.get_end_iter(), False)
             self.config.cacheToFile(self.config.cacheFileName)
         except IOError as e:
             self.show_mbox_warning(_("Cannot write to config file: %s") %
(self.config.cacheFileName))
 
     def on_UpdateButton_clicked(self, widget):
         self.profileContentBuffer = self.profileContent.get_buffer()
-        self.temp =
self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
self.profileContentBuffer.get_end_iter())
+        self.temp =
self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
self.profileContentBuffer.get_end_iter(), False)
         try:
             if not self.config.loadDirect(self.temp):
                 self.commonview.updateCommonView()
@@ -215,7 +215,7 @@ class profileview:
                 context.append(item)
 
                 context.show_all()
-                context.popup(None, None, None, event.button, time)
+                context.popup(None, None, None, event, event.button, time)
             return True
 
     def get_current_tree_selection(self):
diff --git a/tuna/tuna.py b/tuna/tuna.py
index 614a825..1e39222 100755
--- a/tuna/tuna.py
+++ b/tuna/tuna.py
@@ -530,7 +530,7 @@ def thread_filtered(tid, cpus_filtered, show_kthreads,
show_uthreads):
                 return False
             raise err
 
-        if set(cpus_filtered + affinity) == set(cpus_filtered):
+        if set(cpus_filtered + list(affinity)) == set(cpus_filtered):
             return True
 
     if not (show_kthreads and show_uthreads):
diff --git a/tuna/tuna_gui.glade b/tuna/tuna_gui.glade
index 2b572ca..65b38b1 100644
--- a/tuna/tuna_gui.glade
+++ b/tuna/tuna_gui.glade
@@ -129,7 +129,7 @@
                 </child>
               </object>
             </child>
-            <child>
+            <child type="tab">
               <object class="GtkLabel" id="monitor_tab_label">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
@@ -455,7 +455,7 @@
                 <property name="position">1</property>
               </packing>
             </child>
-            <child>
+            <child type="tab">
               <object class="GtkLabel" id="common_tab_l">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
@@ -757,7 +757,7 @@
                 <property name="position">2</property>
               </packing>
             </child>
-            <child>
+            <child type="tab">
               <object class="GtkLabel" id="profile_tab_l">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
diff --git a/tuna/tuna_gui.py b/tuna/tuna_gui.py
index 2360f53..6c2e05d 100755
--- a/tuna/tuna_gui.py
+++ b/tuna/tuna_gui.py
@@ -37,7 +37,7 @@ class main_gui:
             if os.access(tuna_glade, os.F_OK):
                 break
         self.wtree = Gtk.Builder()
-        self.wtree.add_from_file(tuna_glade)
+        self.wtree.add_objects_from_file(tuna_glade, ("mainbig_window",
"tuna"))
         #self.wtree = Gtk.glade.XML(tuna_glade, "mainbig_window",
"tuna")
         self.ps = procfs.pidstats()
         self.irqs = procfs.interrupts()
-- 
2.26.2

[PATCH v2 1/7] tuna: multiple fixes for Gtk-3.0 UI interface

[John Kacur]

On Sun, 14 Mar 2021, Federico Pellegrin wrote:

>  Multiple fixes to make tuna compatible with Gtk-3.0 library. The UI
>  should be now mostly working, some warnings are still present and
>  may be still addressed in the future.
>  
>  Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
>  ---
>   tuna/gui/commonview.py  | 13 +++++++------
>   tuna/gui/cpuview.py     | 15 ++++++---------
>   tuna/gui/irqview.py     |  5 +++--
>   tuna/gui/procview.py    |  6 +++---
>   tuna/gui/profileview.py |  8 ++++----
>   tuna/tuna.py            |  2 +-
>   tuna/tuna_gui.glade     |  6 +++---
>   tuna/tuna_gui.py        |  2 +-
>   8 files changed, 28 insertions(+), 29 deletions(-)
>  
>  diff --git a/tuna/gui/commonview.py b/tuna/gui/commonview.py
>  index 59ca244..cc8f913 100644
>  --- a/tuna/gui/commonview.py
>  +++ b/tuna/gui/commonview.py
>  @@ -13,9 +13,9 @@ class commonview:
>   
>       def cleanUp(self):
>           for value in self.contentTable.get_children():
>  -            if value.get_name() == "controls":
>  +            if Gtk.Buildable.get_name(value) == "controls":
>                   self.ctrl = value
>  -            if value.get_name() == "profileSelectorBox":
>  +            if Gtk.Buildable.get_name(value) == "profileSelectorBox":
>                   self.selector = value
>               self.contentTable.remove(value)
>   
>  @@ -79,12 +79,13 @@ class commonview:
>                           # scale control
>                           frameContent[catCntr]['texts'][contentCntr] =
> Gtk.HScale()
>                          
> frameContent[catCntr]['texts'][contentCntr].set_range(self.config.ctlGuiParams[catCntr][val][0],
> self.config.ctlGuiParams[catCntr][val][1])
>  -                       
> frameContent[catCntr]['texts'][contentCntr].set_update_policy(Gtk.UPDATE_CONTINUOUS)
>  +                       
> #frameContent[catCntr]['texts'][contentCntr].set_update_policy(Gtk.UPDATE_CONTINUOUS)
>                          
> frameContent[catCntr]['texts'][contentCntr].set_value(int(self.config.ctlParams[catCntr][val]))
>                          
> frameContent[catCntr]['texts'][contentCntr].set_digits(0)
>                       else:
>                           # input field
>  -                        frameContent[catCntr]['texts'][contentCntr] =
> Gtk.Entry(256)
>  +                        frameContent[catCntr]['texts'][contentCntr] =
> Gtk.Entry()
>  +                       
> frameContent[catCntr]['texts'][contentCntr].set_max_length(256)
>                          
> frameContent[catCntr]['texts'][contentCntr].set_alignment(0)
>                          
> frameContent[catCntr]['texts'][contentCntr].set_text(self.config.ctlParams[catCntr][val])
>                      
> frameContent[catCntr]['texts'][contentCntr].connect("button-release-event",
> self.checkStar, catCntr, contentCntr, val,
> frameContent[catCntr]['labels'][contentCntr])
>  @@ -105,7 +106,7 @@ class commonview:
>           self.ret = {}
>           self.property_cntr = 0
>           for value in self.contentTable.get_children():
>  -            if value.get_name() == "controls" or value.get_name() ==
> "profileSelectorBox":
>  +            if Gtk.Buildable.get_name(value) == "controls" or
> Gtk.Buildable.get_name(value) == "profileSelectorBox":
>                   continue
>               self.ret[value.get_label()] = {}
>               for content in value:
>  @@ -128,7 +129,7 @@ class commonview:
>           self.ret = {}
>           self.property_cntr = 0
>           for value in self.contentTable.get_children():
>  -            if value.get_name() == "controls" or value.get_name() ==
> "profileSelectorBox":
>  +            if Gtk.Buildable.get_name(value) == "controls" or
> Gtk.Buildable.get_name(value) == "profileSelectorBox":
>                   continue
>               self.ret[value.get_label()] = {}
>               for content in value:
>  diff --git a/tuna/gui/cpuview.py b/tuna/gui/cpuview.py
>  index ec19149..7f00bf5 100755
>  --- a/tuna/gui/cpuview.py
>  +++ b/tuna/gui/cpuview.py
>  @@ -47,10 +47,9 @@ class cpu_socket_frame(Gtk.Frame):
>   
>       def __init__(self, socket, cpus, creator):
>   
>  +        GObject.GObject.__init__(self)
>           if creator.nr_sockets > 1:
>  -            GObject.GObject.__init__(self, _("Socket %s") % socket)
>  -        else:
>  -            GObject.GObject.__init__(self)
>  +            self.set_label(_("Socket %s") % socket)
>   
>           self.socket = socket
>           self.cpus = cpus
>  @@ -268,7 +267,7 @@ class cpuview:
>               columns = math.ceil(math.sqrt(self.nr_sockets))
>               rows = math.ceil(self.nr_sockets / columns)
>               box = Gtk.HBox()
>  -            vbox.pack_start(box, True, True)
>  +            vbox.pack_start(box, True, True, 0)
>           else:
>               box = vbox
>   
>  @@ -281,7 +280,7 @@ class cpuview:
>               if self.nr_sockets > 1:
>                   if column == columns:
>                       box = Gtk.HBox()
>  -                    vbox.pack_start(box, True, True)
>  +                    vbox.pack_start(box, True, True, 0)
>                       column = 1
>                   else:
>                       column += 1
>  @@ -298,10 +297,8 @@ class cpuview:
>           req = frame.get_preferred_size()
>           # FIXME: what is the slack we have
>           # to add to every row and column?
>  -        #width = req[0] + 16
>  -        width = 16
>  -        #height = req[1] + 20
>  -        height = 20
>  +        width = req.minimum_size.width + 16
>  +        height = req.minimum_size.height + 40
>           if self.nr_sockets > 1:
>               width *= columns
>               height *= rows
>  diff --git a/tuna/gui/irqview.py b/tuna/gui/irqview.py
>  index ea5c2f5..fddb977 100755
>  --- a/tuna/gui/irqview.py
>  +++ b/tuna/gui/irqview.py
>  @@ -20,7 +20,8 @@ class irq_druid:
>           self.irqs = irqs
>           self.ps = ps
>           self.irq = irq
>  -        self.window = Gtk.Builder(gladefile)
>  +        self.window = Gtk.Builder()
>  +        self.window.add_objects_from_file(gladefile, ("set_irq_attributes",
> "tuna"))
>           #self.window = Gtk.glade.XML(gladefile, "set_irq_attributes",
> "tuna")
>           self.dialog = self.window.get_object("set_irq_attributes")
>           pixbuf = self.dialog.render_icon(Gtk.STOCK_PREFERENCES,
>  @@ -322,7 +323,7 @@ class irqview:
>           setattr.show()
>           refresh.show()
>   
>  -        menu.popup(None, None, None, event.button, event.time)
>  +        menu.popup(None, None, None, event, event.button, event.time)
>   
>       def toggle_mask_cpu(self, cpu, enabled):
>           if not enabled:
>  diff --git a/tuna/gui/procview.py b/tuna/gui/procview.py
>  index f897fdd..d2abc13 100755
>  --- a/tuna/gui/procview.py
>  +++ b/tuna/gui/procview.py
>  @@ -1,4 +1,5 @@
>   import re
>  +import os
>   import tuna.tuna_sched as tuna_sched
>   
>   import gi
>  @@ -29,7 +30,7 @@ class process_druid:
>           self.pid_info = pid_info
>           self.nr_cpus = nr_cpus
>           self.window = Gtk.Builder()
>  -        self.window.add_from_file(gladefile)
>  +        self.window.add_objects_from_file(gladefile,
> ("set_process_attributes", "tuna"))
>   #        self.window = Gtk.glade.XML(gladefile, "set_process_attributes",
> "tuna")
>           self.dialog = self.window.get_object("set_process_attributes")
>           pixbuf = self.dialog.render_icon(Gtk.STOCK_PREFERENCES,
>  @@ -410,7 +411,6 @@ class procview:
>               pass
>   
>           new_value[self.COL_CMDLINE] = procfs.process_cmdline(thread_info)
>  -
>           gui.set_store_columns(self.tree_store, iter, new_value)
>   
>       def show(self, force_refresh=False):
>  @@ -671,7 +671,7 @@ class procview:
>           uthreads.show()
>           help.show()
>   
>  -        menu.popup(None, None, None, event.button, event.time)
>  +        menu.popup(None, None, None, event, event.button, event.time)
>   
>       def toggle_mask_cpu(self, cpu, enabled):
>           if not enabled:
>  diff --git a/tuna/gui/profileview.py b/tuna/gui/profileview.py
>  index 4f68bf4..c65f92e 100644
>  --- a/tuna/gui/profileview.py
>  +++ b/tuna/gui/profileview.py
>  @@ -87,7 +87,7 @@ class profileview:
>               temp = f.read()
>               f.close()
>               self.profileContentBuffer = self.profileContent.get_buffer()
>  -            buff =
> self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
> self.profileContentBuffer.get_end_iter())
>  +            buff =
> self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
> self.profileContentBuffer.get_end_iter(), False)
>               if temp != buff:
>                   dialog = Gtk.MessageDialog(None, \
>                       Gtk.DialogFlags.MODAL \
>  @@ -114,14 +114,14 @@ class profileview:
>       def on_SaveButton_clicked(self, widget):
>           try:
>               self.profileContentBuffer = self.profileContent.get_buffer()
>  -            self.config.cache =
> self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
> self.profileContentBuffer.get_end_iter())
>  +            self.config.cache =
> self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
> self.profileContentBuffer.get_end_iter(), False)
>               self.config.cacheToFile(self.config.cacheFileName)
>           except IOError as e:
>               self.show_mbox_warning(_("Cannot write to config file: %s") %
> (self.config.cacheFileName))
>   
>       def on_UpdateButton_clicked(self, widget):
>           self.profileContentBuffer = self.profileContent.get_buffer()
>  -        self.temp =
> self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
> self.profileContentBuffer.get_end_iter())
>  +        self.temp =
> self.profileContentBuffer.get_text(self.profileContentBuffer.get_start_iter(),
> self.profileContentBuffer.get_end_iter(), False)
>           try:
>               if not self.config.loadDirect(self.temp):
>                   self.commonview.updateCommonView()
>  @@ -215,7 +215,7 @@ class profileview:
>                   context.append(item)
>   
>                   context.show_all()
>  -                context.popup(None, None, None, event.button, time)
>  +                context.popup(None, None, None, event, event.button, time)
>               return True
>   
>       def get_current_tree_selection(self):
>  diff --git a/tuna/tuna.py b/tuna/tuna.py
>  index 614a825..1e39222 100755
>  --- a/tuna/tuna.py
>  +++ b/tuna/tuna.py
>  @@ -530,7 +530,7 @@ def thread_filtered(tid, cpus_filtered, show_kthreads,
> show_uthreads):
>                   return False
>               raise err
>   
>  -        if set(cpus_filtered + affinity) == set(cpus_filtered):
>  +        if set(cpus_filtered + list(affinity)) == set(cpus_filtered):
>               return True
>   
>       if not (show_kthreads and show_uthreads):
>  diff --git a/tuna/tuna_gui.glade b/tuna/tuna_gui.glade
>  index 2b572ca..65b38b1 100644
>  --- a/tuna/tuna_gui.glade
>  +++ b/tuna/tuna_gui.glade
>  @@ -129,7 +129,7 @@
>                   </child>
>                 </object>
>               </child>
>  -            <child>
>  +            <child type="tab">
>                 <object class="GtkLabel"
> id="monitor_tab_label">
>                   <property name="visible">True</property>
>                   <property name="can_focus">False</property>
>  @@ -455,7 +455,7 @@
>                   <property name="position">1</property>
>                 </packing>
>               </child>
>  -            <child>
>  +            <child type="tab">
>                 <object class="GtkLabel" id="common_tab_l">
>                   <property name="visible">True</property>
>                   <property name="can_focus">False</property>
>  @@ -757,7 +757,7 @@
>                   <property name="position">2</property>
>                 </packing>
>               </child>
>  -            <child>
>  +            <child type="tab">
>                 <object class="GtkLabel" id="profile_tab_l">
>                   <property name="visible">True</property>
>                   <property name="can_focus">False</property>
>  diff --git a/tuna/tuna_gui.py b/tuna/tuna_gui.py
>  index 2360f53..6c2e05d 100755
>  --- a/tuna/tuna_gui.py
>  +++ b/tuna/tuna_gui.py
>  @@ -37,7 +37,7 @@ class main_gui:
>               if os.access(tuna_glade, os.F_OK):
>                   break
>           self.wtree = Gtk.Builder()
>  -        self.wtree.add_from_file(tuna_glade)
>  +        self.wtree.add_objects_from_file(tuna_glade, ("mainbig_window",
> "tuna"))
>           #self.wtree = Gtk.glade.XML(tuna_glade, "mainbig_window",
> "tuna")
>           self.ps = procfs.pidstats()
>           self.irqs = procfs.interrupts()
>  -- 
>  2.26.2 

Signed-off-by: John Kacur <jkacur(a)redhat.com&gt;

[PATCH v2 2/7] config: make configuration files consistently text only

[Federico Pellegrin]

Make all configuration file access consistently text only to avoid
failures when accessed as binary. This fixes errors on writing a
default tuna.conf configuration file and on save of snapshots in
the profile management tab.

Signed-off-by: Federico	Pellegrin <fede(a)evolware.org&gt;
---
 tuna/config.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tuna/config.py b/tuna/config.py
index 03dc479..5d6848c 100644
--- a/tuna/config.py
+++ b/tuna/config.py
@@ -47,7 +47,7 @@ class Config:
             self.temp = configparser.RawConfigParser()
             self.temp.read(self.configFile)
             self.temp.set('global', 'lastFile', filename)
-            with open(self.configFile, 'wb') as cfgfile:
+            with open(self.configFile, 'w') as cfgfile:
                 self.temp.write(cfgfile)
             self.config['lastfile'] = filename
 
@@ -317,7 +317,7 @@ class Config:
 
     def saveSnapshot(self, data):
         tempconfig = configparser.RawConfigParser()
-        tempconfig.readfp(io.BytesIO(self.cache))
+        tempconfig.readfp(io.StringIO(self.cache))
         snapcat = tempconfig.items('categories')
         out = {}
         for opt, val in snapcat:
-- 
2.26.2

[PATCH v2 2/7] config: make configuration files consistently text only

[John Kacur]

On Sun, 14 Mar 2021, Federico Pellegrin wrote:

>  Make all configuration file access consistently text only to avoid
>  failures when accessed as binary. This fixes errors on writing a
>  default tuna.conf configuration file and on save of snapshots in
>  the profile management tab.
>  
>  Signed-off-by: Federico	Pellegrin <fede(a)evolware.org&gt;
>  ---
>   tuna/config.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>  
>  diff --git a/tuna/config.py b/tuna/config.py
>  index 03dc479..5d6848c 100644
>  --- a/tuna/config.py
>  +++ b/tuna/config.py
>  @@ -47,7 +47,7 @@ class Config:
>               self.temp = configparser.RawConfigParser()
>               self.temp.read(self.configFile)
>               self.temp.set('global', 'lastFile', filename)
>  -            with open(self.configFile, 'wb') as cfgfile:
>  +            with open(self.configFile, 'w') as cfgfile:
>                   self.temp.write(cfgfile)
>               self.config['lastfile'] = filename
>   
>  @@ -317,7 +317,7 @@ class Config:
>   
>       def saveSnapshot(self, data):
>           tempconfig = configparser.RawConfigParser()
>  -        tempconfig.readfp(io.BytesIO(self.cache))
>  +        tempconfig.readfp(io.StringIO(self.cache))
>           snapcat = tempconfig.items('categories')
>           out = {}
>           for opt, val in snapcat:
>  -- 
>  2.26.2 
Signed-off-by: John Kacur <jkacur(a)redhat.com&gt;

[PATCH v2 3/7] profileview: disable cursor_changed handler when manipulating list

[Federico Pellegrin]

Temporarily disable cursor_changed signal when emptying and
manipulating the list to prevent massive number of (useless) reloads
of configuration that make the operation very slow (especially if
many configurations present) and errors thrown (when the list is
totally empty)

Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
---
 tuna/gui/profileview.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tuna/gui/profileview.py b/tuna/gui/profileview.py
index c65f92e..b1bc7e4 100644
--- a/tuna/gui/profileview.py
+++ b/tuna/gui/profileview.py
@@ -54,8 +54,11 @@ class profileview:
 
     def clearConfig(self):
         try:
+            if self.configHandler:
+                self.configs.disconnect(self.configHandler)
             self.config_store.clear()
             self.combo_store.clear()
+            self.configHandler = self.configs.connect('cursor_changed',
self.changeProfile)
         except:
             pass
 
@@ -66,19 +69,23 @@ class profileview:
             self.configs
             self.configFileCombo
         except AttributeError:
+            self.configHandler = None
             self.config_store = Gtk.ListStore(str)
             self.configs = self.configFileTree
             self.configFileTree.append_column(Gtk.TreeViewColumn('Profile Name',
Gtk.CellRendererText(), text=0))
-            self.configHandler = self.configs.connect('cursor_changed',
self.changeProfile)
             self.configs.set_model(self.config_store)
             self.combo_store = Gtk.ListStore(str)
             self.configFileCombo.set_model(self.combo_store)
             cell = Gtk.CellRendererText()
             self.configFileCombo.pack_start(cell, True)
             self.configFileCombo.add_attribute(cell, "text", 0)
+
+        if self.configHandler:
+            self.configs.disconnect(self.configHandler)
         self.config_store.append([config])
         self.configs.show()
         self.combo_store.append([config])
+        self.configHandler = self.configs.connect('cursor_changed',
self.changeProfile)
         self.configFileCombo.show()
 
     def changeProfile(self, config):
-- 
2.26.2

[PATCH v2 3/7] profileview: disable cursor_changed handler when manipulating list

[John Kacur]

On Sun, 14 Mar 2021, Federico Pellegrin wrote:

>  Temporarily disable cursor_changed signal when emptying and
>  manipulating the list to prevent massive number of (useless) reloads
>  of configuration that make the operation very slow (especially if
>  many configurations present) and errors thrown (when the list is
>  totally empty)
>  
>  Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
>  ---
>   tuna/gui/profileview.py | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>  
>  diff --git a/tuna/gui/profileview.py b/tuna/gui/profileview.py
>  index c65f92e..b1bc7e4 100644
>  --- a/tuna/gui/profileview.py
>  +++ b/tuna/gui/profileview.py
>  @@ -54,8 +54,11 @@ class profileview:
>   
>       def clearConfig(self):
>           try:
>  +            if self.configHandler:
>  +                self.configs.disconnect(self.configHandler)
>               self.config_store.clear()
>               self.combo_store.clear()
>  +            self.configHandler = self.configs.connect('cursor_changed',
> self.changeProfile)
>           except:
>               pass
>   
>  @@ -66,19 +69,23 @@ class profileview:
>               self.configs
>               self.configFileCombo
>           except AttributeError:
>  +            self.configHandler = None
>               self.config_store = Gtk.ListStore(str)
>               self.configs = self.configFileTree
>               self.configFileTree.append_column(Gtk.TreeViewColumn('Profile Name',
> Gtk.CellRendererText(), text=0))
>  -            self.configHandler = self.configs.connect('cursor_changed',
> self.changeProfile)
>               self.configs.set_model(self.config_store)
>               self.combo_store = Gtk.ListStore(str)
>               self.configFileCombo.set_model(self.combo_store)
>               cell = Gtk.CellRendererText()
>               self.configFileCombo.pack_start(cell, True)
>               self.configFileCombo.add_attribute(cell, "text", 0)
>  +
>  +        if self.configHandler:
>  +            self.configs.disconnect(self.configHandler)
>           self.config_store.append([config])
>           self.configs.show()
>           self.combo_store.append([config])
>  +        self.configHandler = self.configs.connect('cursor_changed',
> self.changeProfile)
>           self.configFileCombo.show()
>   
>       def changeProfile(self, config):
>  -- 
>  2.26.2 
Signed-off-by: John Kacur <jkacur(a)redhat.com&gt;

[PATCH v2 4/7] cpuview: a few more improvements for Gtk 3.0

[Federico Pellegrin]

- Add a bit of padding so socket boxes are not totally sticked
- Fix popup menu click
- Remove popup click event from glade file as it is handled manually

Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
---
 tuna/gui/cpuview.py | 4 ++--
 tuna/tuna_gui.glade | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/tuna/gui/cpuview.py b/tuna/gui/cpuview.py
index 7f00bf5..87144fb 100755
--- a/tuna/gui/cpuview.py
+++ b/tuna/gui/cpuview.py
@@ -229,7 +229,7 @@ class cpu_socket_frame(Gtk.Frame):
             isolate_socket.show()
         restore.show()
 
-        menu.popup(None, None, None, event.button, event.time)
+        menu.popup(None, None, None, event, event.button, event.time)
 
     def filter_toggled(self, cell, path, model):
         # get toggled iter
@@ -275,7 +275,7 @@ class cpuview:
         for socket_id in socket_ids:
             frame = cpu_socket_frame(socket_id,
                                      self.cpus.sockets[str(socket_id)], self)
-            box.pack_start(frame, False, False, 0)
+            box.pack_start(frame, False, False, 2)
             self.socket_frames[socket_id] = frame
             if self.nr_sockets > 1:
                 if column == columns:
diff --git a/tuna/tuna_gui.glade b/tuna/tuna_gui.glade
index 65b38b1..d02a06a 100644
--- a/tuna/tuna_gui.glade
+++ b/tuna/tuna_gui.glade
@@ -53,7 +53,6 @@
                                         <property
name="visible">True</property>
                                         <property
name="can_focus">True</property>
                                         <property
name="border_width">2</property>
-                                        <signal name="button-press-event"
handler="on_cpuview_button_press_event" swapped="no"/>
                                         <child>
                                           <placeholder/>
                                         </child>
-- 
2.26.2

[PATCH v2 4/7] cpuview: a few more improvements for Gtk 3.0

[John Kacur]

On Sun, 14 Mar 2021, Federico Pellegrin wrote:

>  - Add a bit of padding so socket boxes are not totally sticked
>  - Fix popup menu click
>  - Remove popup click event from glade file as it is handled manually
>  
>  Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
>  ---
>   tuna/gui/cpuview.py | 4 ++--
>   tuna/tuna_gui.glade | 1 -
>   2 files changed, 2 insertions(+), 3 deletions(-)
>  
>  diff --git a/tuna/gui/cpuview.py b/tuna/gui/cpuview.py
>  index 7f00bf5..87144fb 100755
>  --- a/tuna/gui/cpuview.py
>  +++ b/tuna/gui/cpuview.py
>  @@ -229,7 +229,7 @@ class cpu_socket_frame(Gtk.Frame):
>               isolate_socket.show()
>           restore.show()
>   
>  -        menu.popup(None, None, None, event.button, event.time)
>  +        menu.popup(None, None, None, event, event.button, event.time)
>   
>       def filter_toggled(self, cell, path, model):
>           # get toggled iter
>  @@ -275,7 +275,7 @@ class cpuview:
>           for socket_id in socket_ids:
>               frame = cpu_socket_frame(socket_id,
>                                        self.cpus.sockets[str(socket_id)], self)
>  -            box.pack_start(frame, False, False, 0)
>  +            box.pack_start(frame, False, False, 2)
>               self.socket_frames[socket_id] = frame
>               if self.nr_sockets > 1:
>                   if column == columns:
>  diff --git a/tuna/tuna_gui.glade b/tuna/tuna_gui.glade
>  index 65b38b1..d02a06a 100644
>  --- a/tuna/tuna_gui.glade
>  +++ b/tuna/tuna_gui.glade
>  @@ -53,7 +53,6 @@
>                                           <property
> name="visible">True</property>
>                                           <property
> name="can_focus">True</property>
>                                           <property
> name="border_width">2</property>
>  -                                        <signal name="button-press-event"
> handler="on_cpuview_button_press_event" swapped="no"/>
>                                           <child>
>                                             <placeholder/>
>                                           </child>
>  -- 
>  2.26.2 
Signed-off-by: John Kacur <jkacur(a)redhat.com&gt;

[PATCH v2 5/7] tuna_gui: handle destroy handler to prevent error messages on startup

[Federico Pellegrin]

Not vital, but to prevent spurious error messages that can easily
worry users.

Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
---
 tuna/tuna_gui.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tuna/tuna_gui.py b/tuna/tuna_gui.py
index 6c2e05d..5c3276c 100755
--- a/tuna/tuna_gui.py
+++ b/tuna/tuna_gui.py
@@ -75,6 +75,8 @@ class main_gui:
         event_handlers = {
             "on_mainbig_window_delete_event"
             : self.on_mainbig_window_delete_event,
+            "on_mainbig_window_destroy_event"
+            : self.on_mainbig_window_delete_event,
             "on_processlist_button_press_event"
             : self.procview.on_processlist_button_press_event,
             "on_irqlist_button_press_event"
-- 
2.26.2

[PATCH v2 5/7] tuna_gui: handle destroy handler to prevent error messages on startup

[John Kacur]

On Sun, 14 Mar 2021, Federico Pellegrin wrote:

>  Not vital, but to prevent spurious error messages that can easily
>  worry users.
>  
>  Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
>  ---
>   tuna/tuna_gui.py | 2 ++
>   1 file changed, 2 insertions(+)
>  
>  diff --git a/tuna/tuna_gui.py b/tuna/tuna_gui.py
>  index 6c2e05d..5c3276c 100755
>  --- a/tuna/tuna_gui.py
>  +++ b/tuna/tuna_gui.py
>  @@ -75,6 +75,8 @@ class main_gui:
>           event_handlers = {
>               "on_mainbig_window_delete_event"
>               : self.on_mainbig_window_delete_event,
>  +            "on_mainbig_window_destroy_event"
>  +            : self.on_mainbig_window_delete_event,
>               "on_processlist_button_press_event"
>               : self.procview.on_processlist_button_press_event,
>               "on_irqlist_button_press_event"
>  -- 
>  2.26.2 
Signed-off-by: John Kacur <jkacur(a)redhat.com&gt;

[PATCH v2 6/7] tuna: fix mnemonic accelerators for Gtk 3.0

[Federico Pellegrin]

Fix the mnemonic accellarators (key shortcuts to access a menu entry)
for present choices in GUI. Previously just a wrong underscore would
be displayed and not action taken.

Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
---
 tuna/gui/cpuview.py  | 10 +++++-----
 tuna/gui/irqview.py  |  6 +++---
 tuna/gui/procview.py | 18 +++++++++---------
 3 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/tuna/gui/cpuview.py b/tuna/gui/cpuview.py
index 87144fb..eeabf2a 100755
--- a/tuna/gui/cpuview.py
+++ b/tuna/gui/cpuview.py
@@ -196,12 +196,12 @@ class cpu_socket_frame(Gtk.Frame):
 
         menu = Gtk.Menu()
 
-        include = Gtk.MenuItem(_("I_nclude CPU"))
-        isolate = Gtk.MenuItem(_("_Isolate CPU"))
+        include = Gtk.MenuItem(_("I_nclude CPU"), use_underline = True)
+        isolate = Gtk.MenuItem(_("_Isolate CPU"), use_underline = True)
         if self.creator.nr_sockets > 1:
-            include_socket = Gtk.MenuItem(_("I_nclude CPU Socket"))
-            isolate_socket = Gtk.MenuItem(_("_Isolate CPU Socket"))
-        restore = Gtk.MenuItem(_("_Restore CPU"))
+            include_socket = Gtk.MenuItem(_("I_nclude CPU Socket"),
use_underline = True)
+            isolate_socket = Gtk.MenuItem(_("_Isolate CPU Socket"),
use_underline = True)
+        restore = Gtk.MenuItem(_("_Restore CPU"), use_underline = True)
 
         menu.add(include)
         menu.add(isolate)
diff --git a/tuna/gui/irqview.py b/tuna/gui/irqview.py
index fddb977..32aad6f 100755
--- a/tuna/gui/irqview.py
+++ b/tuna/gui/irqview.py
@@ -308,11 +308,11 @@ class irqview:
 
         menu = Gtk.Menu()
 
-        setattr = Gtk.MenuItem(_("_Set IRQ attributes"))
+        setattr = Gtk.MenuItem(_("_Set IRQ attributes"), use_underline = True)
         if self.refreshing:
-            refresh = Gtk.MenuItem(_("Sto_p refreshing the IRQ list"))
+            refresh = Gtk.MenuItem(_("Sto_p refreshing the IRQ list"),
use_underline = True)
         else:
-            refresh = Gtk.MenuItem(_("_Refresh the IRQ list"))
+            refresh = Gtk.MenuItem(_("_Refresh the IRQ list"), use_underline =
True)
 
         menu.add(setattr)
         menu.add(refresh)
diff --git a/tuna/gui/procview.py b/tuna/gui/procview.py
index d2abc13..d5685b5 100755
--- a/tuna/gui/procview.py
+++ b/tuna/gui/procview.py
@@ -629,25 +629,25 @@ class procview:
 
         menu = Gtk.Menu()
 
-        setattr = Gtk.MenuItem(_("_Set process attributes"))
+        setattr = Gtk.MenuItem(_("_Set process attributes"), use_underline =
True)
         if self.refreshing:
-            refresh = Gtk.MenuItem(_("Sto_p refreshing the process list"))
+            refresh = Gtk.MenuItem(_("Sto_p refreshing the process list"),
use_underline = True)
         else:
-            refresh = Gtk.MenuItem(_("_Refresh the process list"))
+            refresh = Gtk.MenuItem(_("_Refresh the process list"),
use_underline = True)
 
         if self.show_kthreads:
-            kthreads = Gtk.MenuItem(_("_Hide kernel threads"))
+            kthreads = Gtk.MenuItem(_("_Hide kernel threads"), use_underline =
True)
         else:
-            kthreads = Gtk.MenuItem(_("_Show kernel threads"))
+            kthreads = Gtk.MenuItem(_("_Show kernel threads"), use_underline =
True)
 
         if self.show_uthreads:
-            uthreads = Gtk.MenuItem(_("_Hide user threads"))
+            uthreads = Gtk.MenuItem(_("_Hide user threads"), use_underline =
True)
         else:
-            uthreads = Gtk.MenuItem(_("_Show user threads"))
+            uthreads = Gtk.MenuItem(_("_Show user threads"), use_underline =
True)
 
-        help = Gtk.MenuItem(_("_What is this?"))
+        help = Gtk.MenuItem(_("_What is this?"), use_underline = True)
 
-        save_kthreads_tunings = Gtk.MenuItem(_("_Save kthreads tunings"))
+        save_kthreads_tunings = Gtk.MenuItem(_("_Save kthreads tunings"),
use_underline = True)
 
         menu.add(save_kthreads_tunings)
         menu.add(setattr)
-- 
2.26.2

[PATCH v2 6/7] tuna: fix mnemonic accelerators for Gtk 3.0

[John Kacur]

On Sun, 14 Mar 2021, Federico Pellegrin wrote:

>  Fix the mnemonic accellarators (key shortcuts to access a menu
> entry)
>  for present choices in GUI. Previously just a wrong underscore would
>  be displayed and not action taken.
>  
>  Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
>  ---
>   tuna/gui/cpuview.py  | 10 +++++-----
>   tuna/gui/irqview.py  |  6 +++---
>   tuna/gui/procview.py | 18 +++++++++---------
>   3 files changed, 17 insertions(+), 17 deletions(-)
>  
>  diff --git a/tuna/gui/cpuview.py b/tuna/gui/cpuview.py
>  index 87144fb..eeabf2a 100755
>  --- a/tuna/gui/cpuview.py
>  +++ b/tuna/gui/cpuview.py
>  @@ -196,12 +196,12 @@ class cpu_socket_frame(Gtk.Frame):
>   
>           menu = Gtk.Menu()
>   
>  -        include = Gtk.MenuItem(_("I_nclude CPU"))
>  -        isolate = Gtk.MenuItem(_("_Isolate CPU"))
>  +        include = Gtk.MenuItem(_("I_nclude CPU"), use_underline = True)
>  +        isolate = Gtk.MenuItem(_("_Isolate CPU"), use_underline = True)
>           if self.creator.nr_sockets > 1:
>  -            include_socket = Gtk.MenuItem(_("I_nclude CPU Socket"))
>  -            isolate_socket = Gtk.MenuItem(_("_Isolate CPU Socket"))
>  -        restore = Gtk.MenuItem(_("_Restore CPU"))
>  +            include_socket = Gtk.MenuItem(_("I_nclude CPU Socket"),
> use_underline = True)
>  +            isolate_socket = Gtk.MenuItem(_("_Isolate CPU Socket"),
> use_underline = True)
>  +        restore = Gtk.MenuItem(_("_Restore CPU"), use_underline = True)
>   
>           menu.add(include)
>           menu.add(isolate)
>  diff --git a/tuna/gui/irqview.py b/tuna/gui/irqview.py
>  index fddb977..32aad6f 100755
>  --- a/tuna/gui/irqview.py
>  +++ b/tuna/gui/irqview.py
>  @@ -308,11 +308,11 @@ class irqview:
>   
>           menu = Gtk.Menu()
>   
>  -        setattr = Gtk.MenuItem(_("_Set IRQ attributes"))
>  +        setattr = Gtk.MenuItem(_("_Set IRQ attributes"), use_underline =
> True)
>           if self.refreshing:
>  -            refresh = Gtk.MenuItem(_("Sto_p refreshing the IRQ list"))
>  +            refresh = Gtk.MenuItem(_("Sto_p refreshing the IRQ list"),
> use_underline = True)
>           else:
>  -            refresh = Gtk.MenuItem(_("_Refresh the IRQ list"))
>  +            refresh = Gtk.MenuItem(_("_Refresh the IRQ list"), use_underline =
> True)
>   
>           menu.add(setattr)
>           menu.add(refresh)
>  diff --git a/tuna/gui/procview.py b/tuna/gui/procview.py
>  index d2abc13..d5685b5 100755
>  --- a/tuna/gui/procview.py
>  +++ b/tuna/gui/procview.py
>  @@ -629,25 +629,25 @@ class procview:
>   
>           menu = Gtk.Menu()
>   
>  -        setattr = Gtk.MenuItem(_("_Set process attributes"))
>  +        setattr = Gtk.MenuItem(_("_Set process attributes"), use_underline =
> True)
>           if self.refreshing:
>  -            refresh = Gtk.MenuItem(_("Sto_p refreshing the process list"))
>  +            refresh = Gtk.MenuItem(_("Sto_p refreshing the process list"),
> use_underline = True)
>           else:
>  -            refresh = Gtk.MenuItem(_("_Refresh the process list"))
>  +            refresh = Gtk.MenuItem(_("_Refresh the process list"),
> use_underline = True)
>   
>           if self.show_kthreads:
>  -            kthreads = Gtk.MenuItem(_("_Hide kernel threads"))
>  +            kthreads = Gtk.MenuItem(_("_Hide kernel threads"), use_underline =
> True)
>           else:
>  -            kthreads = Gtk.MenuItem(_("_Show kernel threads"))
>  +            kthreads = Gtk.MenuItem(_("_Show kernel threads"), use_underline =
> True)
>   
>           if self.show_uthreads:
>  -            uthreads = Gtk.MenuItem(_("_Hide user threads"))
>  +            uthreads = Gtk.MenuItem(_("_Hide user threads"), use_underline =
> True)
>           else:
>  -            uthreads = Gtk.MenuItem(_("_Show user threads"))
>  +            uthreads = Gtk.MenuItem(_("_Show user threads"), use_underline =
> True)
>   
>  -        help = Gtk.MenuItem(_("_What is this?"))
>  +        help = Gtk.MenuItem(_("_What is this?"), use_underline = True)
>   
>  -        save_kthreads_tunings = Gtk.MenuItem(_("_Save kthreads tunings"))
>  +        save_kthreads_tunings = Gtk.MenuItem(_("_Save kthreads tunings"),
> use_underline = True)
>   
>           menu.add(save_kthreads_tunings)
>           menu.add(setattr)
>  -- 
>  2.26.2 
Signed-off-by: John Kacur <jkacur(a)redhat.com&gt;

[PATCH v2 7/7] profileview: fix text entry retrieval

[Federico Pellegrin]

With Python 3 we don't need to have the UTF-8 decoding explicitly,
that will fail.

Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
---
 tuna/gui/profileview.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tuna/gui/profileview.py b/tuna/gui/profileview.py
index b1bc7e4..26f58cb 100644
--- a/tuna/gui/profileview.py
+++ b/tuna/gui/profileview.py
@@ -352,7 +352,7 @@ class profileview:
         entry.connect('activate', lambda _: d.response(Gtk.ResponseType.OK))
         d.set_default_response(Gtk.ResponseType.OK)
         r = d.run()
-        text = entry.get_text().decode('utf8')
+        text = entry.get_text()
         d.destroy()
         if r == Gtk.ResponseType.OK:
             return text
-- 
2.26.2

[PATCH v2 7/7] profileview: fix text entry retrieval

[John Kacur]

On Sun, 14 Mar 2021, Federico Pellegrin wrote:

>  With Python 3 we don't need to have the UTF-8 decoding
> explicitly,
>  that will fail.
>  
>  Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
>  ---
>   tuna/gui/profileview.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>  
>  diff --git a/tuna/gui/profileview.py b/tuna/gui/profileview.py
>  index b1bc7e4..26f58cb 100644
>  --- a/tuna/gui/profileview.py
>  +++ b/tuna/gui/profileview.py
>  @@ -352,7 +352,7 @@ class profileview:
>           entry.connect('activate', lambda _: d.response(Gtk.ResponseType.OK))
>           d.set_default_response(Gtk.ResponseType.OK)
>           r = d.run()
>  -        text = entry.get_text().decode('utf8')
>  +        text = entry.get_text()
>           d.destroy()
>           if r == Gtk.ResponseType.OK:
>               return text
>  -- 
>  2.26.2 
Signed-off-by: John Kacur <jkacur(a)redhat.com&gt;

[John Kacur]

On Sun, 14 Mar 2021, Federico Pellegrin wrote:

>  Hi all,
>  I've made some effort to make the tuna gui work properly with Gtk 3.0
>  (tested using CentOS 8.x) and additionally included also some fixes that
>  are related to the porting to Python 3.
>  As far as I can see now the situation is much better and the UI is pretty
>  much usable. Probably some other details may come out (I will keep fixing
>  while finding other details during usage) but I think applying those could
>  already make the tool very well usable now.
>  
>  Hope they are fine and can be merged!
>  
>  Thanks!
>  Federico 
Thanks!

John

> 
> 
> Federico Pellegrin (7):
>   tuna: multiple fixes for Gtk-3.0 UI interface
>   config: make configuration files consistently text only
>   profileview: disable cursor_changed handler when manipulating list
>   cpuview: a few more improvements for Gtk 3.0
>   tuna_gui: handle destroy handler to prevent error messages on startup
>   tuna: fix mnemonic accelerators for Gtk 3.0
>   profileview: fix text entry retrieval
> 
>  tuna/config.py          |  4 ++--
>  tuna/gui/commonview.py  | 13 +++++++------
>  tuna/gui/cpuview.py     | 29 +++++++++++++----------------
>  tuna/gui/irqview.py     | 11 ++++++-----
>  tuna/gui/procview.py    | 24 ++++++++++++------------
>  tuna/gui/profileview.py | 19 +++++++++++++------
>  tuna/tuna.py            |  2 +-
>  tuna/tuna_gui.glade     |  7 +++----
>  tuna/tuna_gui.py        |  4 +++-
>  9 files changed, 60 insertions(+), 53 deletions(-)
> 
> -- 
> 2.26.2
> _______________________________________________
> tuna-devel mailing list -- tuna-devel(a)lists.fedorahosted.org
> To unsubscribe send an email to tuna-devel-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedorahosted.org/archives/list/[e-mail]...
> Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
>