Re: [PATCH v2 6/7] tuna: fix mnemonic accelerators for Gtk 3.0

[John Kacur]

On Sun, 14 Mar 2021, Federico Pellegrin wrote:

>  Fix the mnemonic accellarators (key shortcuts to access a menu
> entry)
>  for present choices in GUI. Previously just a wrong underscore would
>  be displayed and not action taken.
>  
>  Signed-off-by: Federico Pellegrin <fede(a)evolware.org&gt;
>  ---
>   tuna/gui/cpuview.py  | 10 +++++-----
>   tuna/gui/irqview.py  |  6 +++---
>   tuna/gui/procview.py | 18 +++++++++---------
>   3 files changed, 17 insertions(+), 17 deletions(-)
>  
>  diff --git a/tuna/gui/cpuview.py b/tuna/gui/cpuview.py
>  index 87144fb..eeabf2a 100755
>  --- a/tuna/gui/cpuview.py
>  +++ b/tuna/gui/cpuview.py
>  @@ -196,12 +196,12 @@ class cpu_socket_frame(Gtk.Frame):
>   
>           menu = Gtk.Menu()
>   
>  -        include = Gtk.MenuItem(_("I_nclude CPU"))
>  -        isolate = Gtk.MenuItem(_("_Isolate CPU"))
>  +        include = Gtk.MenuItem(_("I_nclude CPU"), use_underline = True)
>  +        isolate = Gtk.MenuItem(_("_Isolate CPU"), use_underline = True)
>           if self.creator.nr_sockets > 1:
>  -            include_socket = Gtk.MenuItem(_("I_nclude CPU Socket"))
>  -            isolate_socket = Gtk.MenuItem(_("_Isolate CPU Socket"))
>  -        restore = Gtk.MenuItem(_("_Restore CPU"))
>  +            include_socket = Gtk.MenuItem(_("I_nclude CPU Socket"),
> use_underline = True)
>  +            isolate_socket = Gtk.MenuItem(_("_Isolate CPU Socket"),
> use_underline = True)
>  +        restore = Gtk.MenuItem(_("_Restore CPU"), use_underline = True)
>   
>           menu.add(include)
>           menu.add(isolate)
>  diff --git a/tuna/gui/irqview.py b/tuna/gui/irqview.py
>  index fddb977..32aad6f 100755
>  --- a/tuna/gui/irqview.py
>  +++ b/tuna/gui/irqview.py
>  @@ -308,11 +308,11 @@ class irqview:
>   
>           menu = Gtk.Menu()
>   
>  -        setattr = Gtk.MenuItem(_("_Set IRQ attributes"))
>  +        setattr = Gtk.MenuItem(_("_Set IRQ attributes"), use_underline =
> True)
>           if self.refreshing:
>  -            refresh = Gtk.MenuItem(_("Sto_p refreshing the IRQ list"))
>  +            refresh = Gtk.MenuItem(_("Sto_p refreshing the IRQ list"),
> use_underline = True)
>           else:
>  -            refresh = Gtk.MenuItem(_("_Refresh the IRQ list"))
>  +            refresh = Gtk.MenuItem(_("_Refresh the IRQ list"), use_underline =
> True)
>   
>           menu.add(setattr)
>           menu.add(refresh)
>  diff --git a/tuna/gui/procview.py b/tuna/gui/procview.py
>  index d2abc13..d5685b5 100755
>  --- a/tuna/gui/procview.py
>  +++ b/tuna/gui/procview.py
>  @@ -629,25 +629,25 @@ class procview:
>   
>           menu = Gtk.Menu()
>   
>  -        setattr = Gtk.MenuItem(_("_Set process attributes"))
>  +        setattr = Gtk.MenuItem(_("_Set process attributes"), use_underline =
> True)
>           if self.refreshing:
>  -            refresh = Gtk.MenuItem(_("Sto_p refreshing the process list"))
>  +            refresh = Gtk.MenuItem(_("Sto_p refreshing the process list"),
> use_underline = True)
>           else:
>  -            refresh = Gtk.MenuItem(_("_Refresh the process list"))
>  +            refresh = Gtk.MenuItem(_("_Refresh the process list"),
> use_underline = True)
>   
>           if self.show_kthreads:
>  -            kthreads = Gtk.MenuItem(_("_Hide kernel threads"))
>  +            kthreads = Gtk.MenuItem(_("_Hide kernel threads"), use_underline =
> True)
>           else:
>  -            kthreads = Gtk.MenuItem(_("_Show kernel threads"))
>  +            kthreads = Gtk.MenuItem(_("_Show kernel threads"), use_underline =
> True)
>   
>           if self.show_uthreads:
>  -            uthreads = Gtk.MenuItem(_("_Hide user threads"))
>  +            uthreads = Gtk.MenuItem(_("_Hide user threads"), use_underline =
> True)
>           else:
>  -            uthreads = Gtk.MenuItem(_("_Show user threads"))
>  +            uthreads = Gtk.MenuItem(_("_Show user threads"), use_underline =
> True)
>   
>  -        help = Gtk.MenuItem(_("_What is this?"))
>  +        help = Gtk.MenuItem(_("_What is this?"), use_underline = True)
>   
>  -        save_kthreads_tunings = Gtk.MenuItem(_("_Save kthreads tunings"))
>  +        save_kthreads_tunings = Gtk.MenuItem(_("_Save kthreads tunings"),
> use_underline = True)
>   
>           menu.add(save_kthreads_tunings)
>           menu.add(setattr)
>  -- 
>  2.26.2 
Signed-off-by: John Kacur <jkacur(a)redhat.com&gt;