Re: [vdsm] Change in vdsm[master]: faqemu: remove the fake /dev/kvm after vdsmd stops
* zhshzhou(a)linux.vnet.ibm.com <zhshzhou(a)linux.vnet.ibm.com> [2012-09-12 20:59]:
Zhou Zheng Sheng has posted comments on this change.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
......................................................................
Patch Set 1:
Thanks very much Ryan. If it is a bug of Fedora and is not easily to
fix quickly, then this patch is useful. To avoid the race, could vdsm
create the /dev/kvm when it starts and delete when it stops? These two
actions can be injected using hooks.
Replying via email as I can't quote or reply to your comment in gerrit.
*sigh*.
I have to admit I didn't notice this was a hook on vdsmd exit; as it, no
more vms will be running.
I was concerned about removing it between VM starts/stops.
I actually think removing on vdsmd shutdown is file. Looking at your
code as well, we rightly only remove /dev/kvm if it is a file, rather
than a char device.
I'll update my comments and review in gerrit.
Mark,
Thanks for finding out the udev issue; I may yet submit a fix for that;
it's likely to be a debatable issue on how udev should handle existing
files in /dev.
yes, nested is much cooler, but I have hosts which do not have
kernels new enough to run nested (see RHEL6.x) so faqemu is still
needed.
--
To view, visit http://gerrit.ovirt.org/7885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c1183acf90cd32444b1c26fa20aa843e4a0556d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh(a)us.ibm.com