----- Original Message -----
From: "Ryan Harper" <ryanh(a)us.ibm.com>
To: vdsm-devel(a)lists.fedorahosted.org
Cc: "Mark Wu" <wudxw(a)linux.vnet.ibm.com>, "Dan Kenigsberg"
<danken(a)redhat.com>, "Greg Padgett" <gpadgett(a)redhat.com>,
"Doron Fediuck" <dfediuck(a)redhat.com>, "Alon Bar-Lev"
<alonbl(a)redhat.com>
Sent: Monday, October 1, 2012 10:24:08 PM
Subject: Re: Change in vdsm[master]: Use 'yum clean expire-cache' instead of
'yum clean all'
* Alon Bar-Lev <alonbl(a)redhat.com> [2012-09-27 13:38]:
> Alon Bar-Lev has posted comments on this change.
>
> Change subject: Use 'yum clean expire-cache' instead of 'yum clean
> all'
> ......................................................................
>
>
> Patch Set 2:
>
> Ok... I was discussing... I think that if you don't get +1 from
> parties you should wait... :)
>
> I see -1 as final decision... for the entire change... or if
> contributer is not cooperating.
>
I'm interested in a little clarity here.
As I see it, -1 means you don't want the current version submitted.
I like the idea of putting a patch on hold while various issues are
discussed, and it seems like a -1 is the right idea here since the
submitter can reply and original reviewer can re-review and remove a
-1
if the submitter has fully explained the issue. Additionaly the
submitter can resubmit with changes (and the -1 is removed anyhow).
This is exactly the problem... you cannot rely on -1 as it clears if a new patchset is
pushed.
Only +1 is to be considered before merge.
What is the maintainer view of how best to use -1? And if we
don't
use
a -1, how does one do the above?
I think that this is fairly new to have proper procedure set.
There are people who use -1 as labelling of what they reviewed.
There are people who use -1 if they have any comment.
There are people who use -1 if they feel patch (the idea, mean and description) should not
be submitted.
My view is that among the -2, -1, 0, +1, +2 there is a proper room for 0, 0 is a number
just like any other number, removing it from scale means narrowing the scale.
My personal view is that:
0 - discussion taking place (initial state).
+1 - approved for submission by reviewer.
+2 - approve for submission by maintainer.
-1 - either the change (principal) is rejected, or the patch is so bad that need a major
rework, or contributor is not cooperating.
-2 - final rejection by maintainer.
But this is only my view...
BTW: it works fine at engine patches... all discussion takes place at '0' until a
decision of -1 or +1 and then final decision of -2 or +2.
Regards,
Alon.