Igor Lvovsky has posted comments on this change.
Change subject: dir is a builtin, overriding it is not nice
......................................................................
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1087
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I292cd9d5b47bb1051b765c02b55f351807316ea7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#750528 - pool refresh should not change metadatata.
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1082
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12e3e700ff67a527c367533bf9f5654e8760a118
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#751629 - Avoid migrate master if MSD is obsolete.
......................................................................
BZ#751629 - Avoid migrate master if MSD is obsolete.
In addition deactivate the (block) domain if it's unreloadable.
Change-Id: I995b86f62ee9026875b966d66f216d295aac9eba
---
M vdsm/storage/sp.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg:
Igor Lvovsky: Looks good to me, but someone else must approve
Haim Ateya: Verified
Ayal Baron: Looks good to me, approved
Objections:
Dan Kenigsberg: I would prefer that you didn't submit this
--
To view, visit http://gerrit.usersys/1091
To unsubscribe, visit http://gerrit.usersys/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I995b86f62ee9026875b966d66f216d295aac9eba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has posted comments on this change.
Change subject: BZ#751629 - Avoid migrate master if MSD is obsolete.
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1110: if new_msdUUID != BLANK_POOL_UUID:
Line 1111: #Trying to migrate master failed to reach actual msd.
Line 1112: raise se.StorageDomainAccessError(sdUUID)
Line 1113: else:
Line 1114: if self.masterDomain.sdUUID == sdUUID:
Edu is right,
But let's consider to change isMaster() to verify master version in additionally to role
Line 1115: #Maybe there should be information in the exception that the UUID is
Line 1116: #not invalid because of its format but because it is equal to the SD. Will be less confusing.
Line 1117: #TODO: verify in masterMigrate().
Line 1118: if sdUUID == new_msdUUID:
--
To view, visit http://gerrit.usersys.redhat.com/1091
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I995b86f62ee9026875b966d66f216d295aac9eba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Eduardo Warszawski has posted comments on this change.
Change subject: BZ#751629 - Avoid migrate master if MSD is obsolete.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1110: if new_msdUUID != BLANK_POOL_UUID:
Line 1111: #Trying to migrate master failed to reach actual msd.
Line 1112: raise se.StorageDomainAccessError(sdUUID)
Line 1113: else:
Line 1114: if self.masterDomain.sdUUID == sdUUID:
MSD is lost.
RHEV-M does reconstruct master and after that tries to deactivate the outdated (former) MSD.
If the outdated MSD is still unreachable AttributeError is raised.
If meanwhile the outdated MSD was reconnected, isMaster() will be true and masterMigrate() will be triggered with BLANK_UUID as the new master, going to _unmountLastMaster() and below.
Line 1115: #Maybe there should be information in the exception that the UUID is
Line 1116: #not invalid because of its format but because it is equal to the SD. Will be less confusing.
Line 1117: #TODO: verify in masterMigrate().
Line 1118: if sdUUID == new_msdUUID:
--
To view, visit http://gerrit.usersys/1091
To unsubscribe, visit http://gerrit.usersys/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I995b86f62ee9026875b966d66f216d295aac9eba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#751629 - Avoid migrate master if MSD is obsolete.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1110: if new_msdUUID != BLANK_POOL_UUID:
Line 1111: #Trying to migrate master failed to reach actual msd.
Line 1112: raise se.StorageDomainAccessError(sdUUID)
Line 1113: else:
Line 1114: if self.masterDomain.sdUUID == sdUUID:
why not use isMaster()? is the change related in any way?
p.s. I do not understand the comment below. what is "the exception" mentioned there?
Line 1115: #Maybe there should be information in the exception that the UUID is
Line 1116: #not invalid because of its format but because it is equal to the SD. Will be less confusing.
Line 1117: #TODO: verify in masterMigrate().
Line 1118: if sdUUID == new_msdUUID:
--
To view, visit http://gerrit.usersys/1091
To unsubscribe, visit http://gerrit.usersys/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I995b86f62ee9026875b966d66f216d295aac9eba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#750528 - pool refresh should not change metadatata.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(6 inline comments)
....................................................
File vdsm/storage/sp.py
Line 274: StatsThread.onDomainConnectivityStateChange.unregister(self._upgradePoolDomain)
Line 275: except KeyError:
Line 276: pass
Line 277:
Line 278: def getDomainsReady(self):
What does it mean?
Line 279: """
Line 280: Get domains ready for use.
Line 281:
Line 282: Activate, plant master trees, etc as needed.
Line 287: #MSD is already done
Line 288: continue
Line 289: dom = sdCache.produce(sdUUID)
Line 290: domMD = dom.getMetadata()
Line 291: if domMD[sd.DMDK_CLASS] == sd.BACKUP_DOMAIN:
Use accessor
Line 292: # Recreate master tree if needed.
Line 293: dom.makeMasterTree()
Line 294: #Stale master domain?
Line 295: elif domMD[sd.DMDK_CLASS] == sd.DATA_DOMAIN \
Line 292: # Recreate master tree if needed.
Line 293: dom.makeMasterTree()
Line 294: #Stale master domain?
Line 295: elif domMD[sd.DMDK_CLASS] == sd.DATA_DOMAIN \
Line 296: and domMD[sd.DMDK_ROLE] == sd.MASTER_DOMAIN:
Use accessor
Line 297: self._setRegularSD(dom)
Line 298:
Line 299: @unsecured
Line 300: def startSpm(self, prevID, prevLVER, scsiFencing, maxHostID, expectedDomVersion=None):
Line 1004: dom.acquireClusterLock(self.id)
Line 1005: try:
Line 1006: domMD = dom.getMetadata()
Line 1007: #If you remove this condition, remove it from public_createStoragePool too.
Line 1008: if domMD[sd.DMDK_CLASS] == sd.DATA_DOMAIN and domMD[sd.DMDK_VERSION] != self.masterDomain.getVersion():
Use acessor
Line 1009: raise se.MixedSDVersionError(dom.sdUUID, domMD[sd.DMDK_VERSION], self.masterDomain.sdUUID, self.masterDomain.getVersion())
Line 1010:
Line 1011: dom.attach(self.spUUID)
Line 1012: if domMD[sd.DMDK_CLASS] == sd.DATA_DOMAIN and domMD[sd.DMDK_ROLE] == sd.MASTER_DOMAIN:
Line 1087: if PMDK_MASTER_VER not in domPoolMD.iterkeys():
Line 1088: self.log.error("Domain %s is marked master but lacks %s",
Line 1089: domain.sdUUID, PMDK_MASTER_VER)
Line 1090: elif domPoolMD[PMDK_MASTER_VER] >= self.getMasterVersion():
Line 1091: self.log.error("VDSM PANIC! Domain %s has pool ver %s \
User warning
Line 1092: ge than this pool %s version", domain.sdUUID, self.getMasterVersion())
Line 1093: #Deprecated master: change role to regular
Line 1094: else:
Line 1095: with domPoolMD.transaction():
Line 1113: if domainStatuses[sdUUID] == sd.DOM_ACTIVE_STATUS:
Line 1114: return True
Line 1115:
Line 1116: domMD = dom.getMetadata()
Line 1117: if domMD[sd.DMDK_CLASS] == sd.DATA_DOMAIN:
User accessor
Line 1118: #Fix (eventual) stale master ROLE keys in SD MD.
Line 1119: if domMD[sd.DMDK_ROLE] == sd.MASTER_DOMAIN:
Line 1120: self._setRegularSD(dom)
Line 1121: dom.upgrade(self.getVersion())
--
To view, visit http://gerrit.usersys/1082
To unsubscribe, visit http://gerrit.usersys/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12e3e700ff67a527c367533bf9f5654e8760a118
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has posted comments on this change.
Change subject: Renamed backup domain make master tree.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1070: return True
Line 1071:
Line 1072: if dom.getDomainClass() == sd.DATA_DOMAIN:
Line 1073: dom.upgrade(self.getVersion())
Line 1074: elif domMD[sd.DMDK_CLASS] == sd.BACKUP_DOMAIN:
Use accessor
Line 1075: dom.makeMasterTree()
Line 1076:
Line 1077: domainStatuses[sdUUID] = sd.DOM_ACTIVE_STATUS
Line 1078: self.setMetaParam(PMDK_DOMAINS, domainStatuses)
--
To view, visit http://gerrit.usersys/1092
To unsubscribe, visit http://gerrit.usersys/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b7af67039a38765a4758ce0db15633d7dbd5e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>