Eduardo Warszawski has posted comments on this change.
Change subject: dir is a builtin, overriding it is not nice
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.usersys/1087
To unsubscribe, visit http://gerrit.usersys/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I292cd9d5b47bb1051b765c02b55f351807316ea7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: vds_bootstrap: fix usage string
......................................................................
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.usersys.redhat.com/982
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8950764778dc61d04caeed4c74e792d52bba3378
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
Patch was abandoned by Saggi Mizrahi (smizrahi(a)redhat.com) because: This should be done sometime but frankly I'm to tired to mess with this now
You can review this change at: http://gerrit.usersys.redhat.com/1076
Saggi Mizrahi has abandoned this change.
Change subject: AdvancedStatsThread does not need to inherit from threading.Thread
......................................................................
Patch Set 3: Abandoned
This should be done sometime but frankly I'm to tired to mess with this now
--
To view, visit http://gerrit.usersys.redhat.com/1076
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I79899b694c57fba3e81d8eef2b226082d3c99f70
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Patch was abandoned by Saggi Mizrahi (smizrahi(a)redhat.com) because: This should be done sometime but frankly I'm to tired to mess with this now
You can review this change at: http://gerrit.usersys.redhat.com/1077
Saggi Mizrahi has abandoned this change.
Change subject: StatsThread does not need to inherit from threading.Thread
......................................................................
Patch Set 4: Abandoned
This should be done sometime but frankly I'm to tired to mess with this now
--
To view, visit http://gerrit.usersys.redhat.com/1077
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I00b1f9ffb0ad1442ef08d565fa10d1a2fd8bc259
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Igor Lvovsky has posted comments on this change.
Change subject: vds_bootstrap: fix usage string
......................................................................
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/982
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8950764778dc61d04caeed4c74e792d52bba3378
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>