Dan Kenigsberg has posted comments on this change.
Change subject: BZ#749151 revive Vm ticket just before migration
......................................................................
Patch Set 3: Verified; Looks good to me, approved
verified by marian https://bugzilla.redhat.com/show_bug.cgi?id=749151#c20
--
To view, visit http://gerrit.usersys.redhat.com/1086
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c0347354cf8f943c787dd621ce7b0eb78ef55
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert "BZ#727602 setVmTicket: never expire ticket"
......................................................................
Revert "BZ#727602 setVmTicket: never expire ticket"
This reverts commit fd1f8a7a117067f1733898734b1c97bdf75d18bd.
Conflicts:
vdsm/libvirtvm.py
Change-Id: I7624e614576903e39ca0947a4f536433db944332
---
M vdsm/libvirtvm.py
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
Igor Lvovsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1085
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7624e614576903e39ca0947a4f536433db944332
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "BZ#727602 setVmTicket: never expire ticket"
......................................................................
Patch Set 2: Verified; Looks good to me, approved
verified by marian
--
To view, visit http://gerrit.usersys.redhat.com/1085
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7624e614576903e39ca0947a4f536433db944332
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has posted comments on this change.
Change subject: Adding shared raw disk feature.
......................................................................
Patch Set 2:
I think we need to add additional list for raw drives, else we can't see drive information with queries like: list, getVmStats, ...
--
To view, visit http://gerrit.usersys.redhat.com/1064
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib417bd6423773db382826d6255e8cbeafd333116
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has posted comments on this change.
Change subject: Generalize _parseDriveSpec dictionaries.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1063
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24350c099a92923323a221c909c53855a2906ece
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has posted comments on this change.
Change subject: BZ#749151 revive Vm ticket just before migration
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1086
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7c0347354cf8f943c787dd621ce7b0eb78ef55
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#750528 - pool refresh should not change metadatata.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
I wish this patch did not depend on the two previous ones.
....................................................
File vdsm/storage/sp.py
Line 343: self.masterDomain.mountMaster()
Line 344: self.masterDomain.createMasterTree(log=True)
Line 345: self.tasksDir = os.path.join(self.poolPath, POOL_MASTER_DOMAIN, sd.MASTER_FS_DIR, sd.TASKS_DIR)
Line 346:
Line 347: #Domain private care
I do not understand the joke here. and why are you in-lining the formerly-separated function? I think it is less readable.
Line 348: domUUIDs = self.getDomains(activeOnly=True).keys()
Line 349: for sdUUID in domUUIDs:
Line 350: if sdUUID == self.masterDomain.sdUUID:
Line 351: continue
Line 352: dom = sdCache.produce(sdUUID)
Line 353: domMD = dom.getMetadata()
Line 354: if domMD[sd.DMDK_CLASS] == sd.BACKUP_DOMAIN:
Line 355: dom.mountMaster()
Line 356: # Master tree should be exist in this point
s/be //
Line 357: # Recreate it if not.
Line 358: dom.createMasterTree()
Line 359: #Stale master domain?
Line 360: elif domMD[sd.DMDK_CLASS] == sd.DATA_DOMAIN \
Line 1006: dom.acquireClusterLock(self.id)
Line 1007: try:
Line 1008: domMD = dom.getMetadata()
Line 1009: #If you remove this condition, remove it from public_createStoragePool too.
Line 1010: if domMD[sd.DMDK_CLASS] == sd.DATA_DOMAIN and domMD[sd.DMDK_VERSION] != self.masterDomain.getVersion():
this change seems to me an unrelated optimization. am I right?
Line 1011: raise se.MixedSDVersionError(dom.sdUUID, domMD[sd.DMDK_VERSION], self.masterDomain.sdUUID, self.masterDomain.getVersion())
Line 1012:
Line 1013: dom.attach(self.spUUID)
Line 1014: if domMD[sd.DMDK_CLASS] == sd.DATA_DOMAIN and domMD[sd.DMDK_ROLE] == sd.MASTER_DOMAIN:
--
To view, visit http://gerrit.usersys.redhat.com/1082
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12e3e700ff67a527c367533bf9f5654e8760a118
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has posted comments on this change.
Change subject: Revert "BZ#727602 setVmTicket: never expire ticket"
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1085
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7624e614576903e39ca0947a4f536433db944332
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move iscsid.conf template outside of the source file
......................................................................
Move iscsid.conf template outside of the source file
Change-Id: I59ab2a951ddf15941218524ad7eb5bf94295023e
---
M vdsm.spec.in
M vdsm/storage/Makefile.am
M vdsm/storage/iscsi.py
A vdsm/storage/iscsid.conf.template
4 files changed, 212 insertions(+), 207 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1034
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59ab2a951ddf15941218524ad7eb5bf94295023e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: Move iscsid.conf template outside of the source file
......................................................................
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1034
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ab2a951ddf15941218524ad7eb5bf94295023e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>