vdsm-patches June 2012

vdsm-patches@lists.fedorahosted.org

45 participants
405 discussions

Change in vdsm[master]: change the code style of SecureXMLRPCServer.py for PEP8 comp...
by shuming＠linux.vnet.ibm.com 13 Jun '12

13 Jun '12

Hello ShaoHe Feng, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/4797 to review the following change. Change subject: change the code style of SecureXMLRPCServer.py for PEP8 compliance ...................................................................... change the code style of SecureXMLRPCServer.py for PEP8 compliance Change-Id: I28328713dc4be9fb78e8c1f48c9f93b36a4d9eb2 Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> --- M Makefile.am M vdsm/SecureXMLRPCServer.py 2 files changed, 27 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/4797/1 -- To view, visit http://gerrit.ovirt.org/4797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28328713dc4be9fb78e8c1f48c9f93b36a4d9eb2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming <shuming(a)linux.vnet.ibm.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>

4 5

Change in vdsm[master]: change the code style of before_vm_start.py for PEP8 complia...
by shuming＠linux.vnet.ibm.com 13 Jun '12

13 Jun '12

Hello ShaoHe Feng, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/4798 to review the following change. Change subject: change the code style of before_vm_start.py for PEP8 compliance ...................................................................... change the code style of before_vm_start.py for PEP8 compliance Change-Id: Ic0e86c35be128f542151557d12d30a095fa4624f Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> --- M Makefile.am M vdsm_hooks/fileinject/before_vm_start.py 2 files changed, 40 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/4798/1 -- To view, visit http://gerrit.ovirt.org/4798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0e86c35be128f542151557d12d30a095fa4624f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming <shuming(a)linux.vnet.ibm.com> Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>

2 3

Change in vdsm[master]: API: Add formal definition for disk types
by agl＠us.ibm.com 13 Jun '12

13 Jun '12

Adam Litke has uploaded a new change for review. Change subject: API: Add formal definition for disk types ...................................................................... API: Add formal definition for disk types Expose the enum representing disk types in the public API. Along the way, correct some docstrings that suggest the diskType parameter is a string when it is an integer. Signed-off-by: Adam Litke <agl(a)us.ibm.com> Change-Id: I797bc9dd2b86678c14ba4c5abdc4a87f618b6b09 --- M vdsm/API.py M vdsm/storage/fileVolume.py M vdsm/storage/sp.py 3 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/4957/1 -- To view, visit http://gerrit.ovirt.org/4957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I797bc9dd2b86678c14ba4c5abdc4a87f618b6b09 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>

6 13

Change in vdsm[master]: BZ#798188 Disallow cross-vendor virtualization.
by Dan Kenigsberg 13 Jun '12

13 Jun '12

Dan Kenigsberg has posted comments on this change. Change subject: BZ#798188 Disallow cross-vendor virtualization. ...................................................................... Patch Set 1: Looks good to me, approved same as upstream -- To view, visit http://gerrit.usersys.redhat.com/1317 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id52f757971e28058257d819036e58e0f1925c44d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>

1 0

Change in vdsm[master]: BZ#830485 - Add netConfigDirty bit to getVdsCaps report
by Igor Lvovsky 13 Jun '12

13 Jun '12

Igor Lvovsky has uploaded a new change for review. Change subject: BZ#830485 - Add netConfigDirty bit to getVdsCaps report ...................................................................... BZ#830485 - Add netConfigDirty bit to getVdsCaps report Change-Id: Iba641a74d33157186ddc6ceb6196b531953c9c8b Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com> --- M vdsm/API.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/5257/1 -- To view, visit http://gerrit.ovirt.org/5257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba641a74d33157186ddc6ceb6196b531953c9c8b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>

2 3

Change in vdsm[master]: Add bridge on top of VLAN if exists
by Igor Lvovsky 13 Jun '12

13 Jun '12

Igor Lvovsky has uploaded a new change for review. Change subject: Add bridge on top of VLAN if exists ...................................................................... Add bridge on top of VLAN if exists In VLAN case we should attach bridge only to the VLAN rather than to underlying NICs or bond Change-Id: I1c554853b5be9330933174da810b6d67c83eb96e Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com> --- M vdsm/configNetwork.py 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/5284/1 -- To view, visit http://gerrit.ovirt.org/5284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1c554853b5be9330933174da810b6d67c83eb96e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>

2 3

Change in vdsm[master]: Use proper MTU on bonding when add network
by Igor Lvovsky 13 Jun '12

13 Jun '12

Igor Lvovsky has uploaded a new change for review. Change subject: Use proper MTU on bonding when add network ...................................................................... Use proper MTU on bonding when add network Change-Id: Id34f2462ddfc2c9f4a323235c79f919c0cce12a7 Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com> --- M vdsm/configNetwork.py 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/5209/1 -- To view, visit http://gerrit.ovirt.org/5209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id34f2462ddfc2c9f4a323235c79f919c0cce12a7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>

2 4

Change in vdsm[master]: Use already known iface in addNetwork
by Igor Lvovsky 13 Jun '12

13 Jun '12

Igor Lvovsky has uploaded a new change for review. Change subject: Use already known iface in addNetwork ...................................................................... Use already known iface in addNetwork Change-Id: I085792401a04d7695855e81b16b442e4c31ab706 Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com> --- M vdsm/configNetwork.py 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/5283/1 -- To view, visit http://gerrit.ovirt.org/5283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I085792401a04d7695855e81b16b442e4c31ab706 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>

2 3

Change in vdsm[master]: Check permission to read key files when ssl is enabled
by wenyi＠linux.vnet.ibm.com 13 Jun '12

13 Jun '12

Wenyi Gao has uploaded a new change for review. Change subject: Check permission to read key files when ssl is enabled ...................................................................... Check permission to read key files when ssl is enabled Currently, there is no permission check to read key files when ssl is enabled, which maybe cause puzzling error. For example, when a non-privileged user runs "vdsClient -s 0 getVdsCaps", there will be as following error: $ vdsClient -s 0 getVdsCaps Traceback (most recent call last): File "/usr/share/vdsm/vdsClient.py", line 2275, in <module> code, message = commands[command][0](commandArgs) File "/usr/share/vdsm/vdsClient.py", line 403, in do_getCap return self.ExecAndExit(self.s.getVdsCapabilities()) File "/usr/lib64/python2.7/xmlrpclib.py", line 1224, in __call__ return self.__send(self.__name, args) File "/usr/lib64/python2.7/xmlrpclib.py", line 1578, in __request verbose=self.__verbose File "/usr/lib64/python2.7/xmlrpclib.py", line 1264, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib64/python2.7/xmlrpclib.py", line 1292, in single_request self.send_content(h, request_body) File "/usr/lib64/python2.7/xmlrpclib.py", line 1439, in send_content connection.endheaders(request_body) File "/usr/lib64/python2.7/httplib.py", line 954, in endheaders self._send_output(message_body) File "/usr/lib64/python2.7/httplib.py", line 814, in _send_output self.send(msg) File "/usr/lib64/python2.7/httplib.py", line 776, in send self.connect() File "/usr/lib/python2.7/site-packages/vdsm/SecureXMLRPCServer.py", line 98, in connect cert_reqs=self.cert_reqs) File "/usr/lib64/python2.7/ssl.py", line 381, in wrap_socket ciphers=ciphers) File "/usr/lib64/python2.7/ssl.py", line 141, in __init__ ciphers) SSLError: [Errno 185090050] _ssl.c:340: error:0B084002:x509 certificate routines:X509_load_cert_crl_file:system lib When ssl is enabled, this patch will first check the permission to read key files, and then give a proper error message if there is no read access to them. Change-Id: I59b983d31a08bc657abdcba85f2f033900338055 Signed-off-by: Wenyi Gao <wenyi(a)linux.vnet.ibm.com> --- M vdsm_cli/vdscli.py.in 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/5156/1 -- To view, visit http://gerrit.ovirt.org/5156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I59b983d31a08bc657abdcba85f2f033900338055 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>

2 6

Change in vdsm[master]: fix a sloppy rebase
by Dan Kenigsberg 12 Jun '12

12 Jun '12

Dan Kenigsberg has uploaded a new change for review. Change subject: fix a sloppy rebase ...................................................................... fix a sloppy rebase note to self: avoid late-evening hasty rebases Change-Id: Ia9e208563b3e814626746e8143b18f9b4e3ad6bd Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm.spec.in 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/5297/1 -- To view, visit http://gerrit.ovirt.org/5297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9e208563b3e814626746e8143b18f9b4e3ad6bd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 2

← Newer
1
...
33
34
35
36
37
38
39
40
41
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches June 2012