Wenyi Gao has uploaded a new change for review.
Change subject: Close and remove the temporary file before raising a exception
......................................................................
Close and remove the temporary file before raising a exception
Change-Id: I93eafbcf78805669596258b3579ee49cc1b79360
Signed-off-by: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
---
M vdsm/storage/multipath.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/4885/1
--
To view, visit http://gerrit.ovirt.org/4885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93eafbcf78805669596258b3579ee49cc1b79360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Yair Zaslavsky has uploaded a new change for review.
Change subject: Change storageServer to parse some params as strings
......................................................................
Change storageServer to parse some params as strings
engine is sending the connection information as a map of
string keys and string values. VDSM tries to parse version,retrans and
timeout as numbers, but due to the nature of the passed map
it receives a string containing numerical values for these arguments.
Since these arguments are later on added to a comma delimited list
I suggest to parse them as strings.
Change-Id: I4d1716a6f66a108d60f39fad14d92625a692d0e3
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M vdsm/storage/storageServer.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/5062/1
--
To view, visit http://gerrit.ovirt.org/5062
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d1716a6f66a108d60f39fad14d92625a692d0e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Mark Wu has posted comments on this change.
Change subject: config qemu-sanlock to ignore readonly lease for default
......................................................................
Patch Set 1: I would prefer that you didn't submit this
You also need bump the required libvirt version to v0.9.12 in the spec file of vdsm package. But it's still not available on f17.
--
To view, visit http://gerrit.ovirt.org/5057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I116f3ce07fff8075902a862e0259198232efd2f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Bing Bu Cao has posted comments on this change.
Change subject: config qemu-sanlock to ignore readonly lease for default
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/vdsmd.init.in
Line 377: set_if_default $qlconf ignore_readonly_and_shared_disks 1
As I know,the "ignore_readonly_and_shared_disks" was just merged into libvirt(0.9.12) one month ago.And now the libvirt (0.9.11) depended by vdsm will ignore this parameter.
I think the patch only/will be ok after libvirt updated.
https://bugzilla.redhat.com/show_bug.cgi?id=828633
--
To view, visit http://gerrit.ovirt.org/5057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I116f3ce07fff8075902a862e0259198232efd2f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning (#514657)
......................................................................
Patch Set 2: Do not submit
please abandon this. master branch is unused in this downstream gerrit.
--
To view, visit http://gerrit.usersys.redhat.com/1311
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: CpuPinning for vdsClient (#514657)
......................................................................
Patch Set 1: Do not submit
please abandon this. master branch is unused in this downstream gerrit.
--
To view, visit http://gerrit.usersys.redhat.com/1312
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1cf4c55d23bda450cad1543ac4d622f2949e03d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>