vdsm-patches October 2016

vdsm-patches@lists.fedorahosted.org

33 participants
468 discussions

Change in vdsm[master]: stomp: simplified client
by ybronhei＠redhat.com 30 Oct '16

30 Oct '16

Yaniv Bronhaim has posted comments on this change. Change subject: stomp: simplified client ...................................................................... Patch Set 13: Code-Review+1 you can split the patch and fix the commit msg. but generally for me this patch is fine. -- To view, visit https://gerrit.ovirt.org/59151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3
by Piotr Kliczewski 30 Oct '16

30 Oct '16

Piotr Kliczewski has uploaded a new change for review. Change subject: tests: inspect.getargspec() is deprecated in py3 ...................................................................... tests: inspect.getargspec() is deprecated in py3 We do not want to see following warning during running tests: DeprecationWarning: inspect.getargspec() is deprecated Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M tests/api_test.py M tests/schemaValidationTest.py M tests/testlib.py 3 files changed, 12 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/64313/1 diff --git a/tests/api_test.py b/tests/api_test.py index 3c57381..b977415 100644 --- a/tests/api_test.py +++ b/tests/api_test.py @@ -18,12 +18,11 @@ # Refer to the README and COPYING files for full details of the license # -import inspect - from vdsm.common import api from vdsm.common import exception from vdsm.common import response +from testlib import getargspec from testlib import VdsmTestCase as TestCaseBase @@ -31,10 +30,10 @@ def test_preserve_signature(self): vm = FakeVM() - args = inspect.getargspec(vm.fail) + args = getargspec(vm.fail) self.assertEqual(args.args, ['self', 'exc']) self.assertEqual(args.varargs, None) - self.assertEqual(args.keywords, None) + self.assertEqual(getattr(args, 'keywords', None), None) class TestResponse(TestCaseBase): diff --git a/tests/schemaValidationTest.py b/tests/schemaValidationTest.py index fd87724..13df62f 100644 --- a/tests/schemaValidationTest.py +++ b/tests/schemaValidationTest.py @@ -29,6 +29,7 @@ from vdsm.rpc import Bridge from api import vdsmapi +from testlib import getargspec from testlib import VdsmTestCase as TestCaseBase from contextlib import contextmanager @@ -169,12 +170,12 @@ yield class_name, class_obj def _get_args(self, method_obj): - args = inspect.getargspec(method_obj).args + args = getargspec(method_obj).args args.remove('self') return args def _get_default_args(self, method_obj): - argSpec = inspect.getargspec(method_obj) + argSpec = getargspec(method_obj) if argSpec.defaults: return argSpec.args[- len(argSpec.defaults):] else: diff --git a/tests/testlib.py b/tests/testlib.py index c341c24..7c63a38 100644 --- a/tests/testlib.py +++ b/tests/testlib.py @@ -45,6 +45,12 @@ import mock mock +try: + from inspect import getfullargspec as getargspec +except ImportError: # py2 + from inspect import getargspec as getargspec +getargspec + from nose import config from nose import core from nose import result -- To view, visit https://gerrit.ovirt.org/64313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

4 10

Change in vdsm[master]: sp: _upgradePool - log before starting domain upgrade thread
by automation＠ovirt.org 30 Oct '16

30 Oct '16

gerrit-hooks has posted comments on this change. Change subject: sp: _upgradePool - log before starting domain upgrade thread ...................................................................... Patch Set 1: * update_tracker: OK -- To view, visit https://gerrit.ovirt.org/57550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f13ad128dbd9aa9d69891d5999d584a8cc26d0d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: sp: _upgradePoolDomain - improved logging
by automation＠ovirt.org 30 Oct '16

30 Oct '16

gerrit-hooks has posted comments on this change. Change subject: sp: _upgradePoolDomain - improved logging ...................................................................... Patch Set 3: * update_tracker: OK -- To view, visit https://gerrit.ovirt.org/57551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b004a763e4322214015d558768b81e5bfc646ab Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: sp: _upgradePool - log before starting domain upgrade thread
by Jenkins CI RO 30 Oct '16

30 Oct '16

Jenkins CI RO has abandoned this change. Change subject: sp: _upgradePool - log before starting domain upgrade thread ...................................................................... Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/57550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6f13ad128dbd9aa9d69891d5999d584a8cc26d0d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: sp: _upgradePoolDomain - improved logging
by Jenkins CI RO 30 Oct '16

30 Oct '16

Jenkins CI RO has abandoned this change. Change subject: sp: _upgradePoolDomain - improved logging ...................................................................... Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/57551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1b004a763e4322214015d558768b81e5bfc646ab Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: utils: Properly handle int argument in tobool().
by automation＠ovirt.org 30 Oct '16

30 Oct '16

gerrit-hooks has posted comments on this change. Change subject: utils: Properly handle int argument in tobool(). ...................................................................... Patch Set 4: * update_tracker: OK -- To view, visit https://gerrit.ovirt.org/57511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1740f82f5fa5eb50c319b46ce428bbb9f8c0c15e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: utils: Properly handle int argument in tobool().
by Jenkins CI RO 30 Oct '16

30 Oct '16

Jenkins CI RO has abandoned this change. Change subject: utils: Properly handle int argument in tobool(). ...................................................................... Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/57511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1740f82f5fa5eb50c319b46ce428bbb9f8c0c15e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: coverage: Add vdsm-coverage sub package
by automation＠ovirt.org 30 Oct '16

30 Oct '16

gerrit-hooks has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package ...................................................................... Patch Set 5: * update_tracker: OK -- To view, visit https://gerrit.ovirt.org/49807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Petr Balogh <pbalogh(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: coverage: Add vdsm-coverage sub package
by Jenkins CI RO 30 Oct '16

30 Oct '16

Jenkins CI RO has abandoned this change. Change subject: coverage: Add vdsm-coverage sub package ...................................................................... Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/49807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Petr Balogh <pbalogh(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches October 2016