vdsm-patches October 2016

vdsm-patches@lists.fedorahosted.org

33 participants
468 discussions

Change in vdsm[master]: stomp: simplified client
by igoihman＠redhat.com 31 Oct '16

31 Oct '16

Irit Goihman has posted comments on this change. Change subject: stomp: simplified client ...................................................................... Patch Set 13: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/59151/10/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 603: """ Line 604: reactor = Reactor() Line 605: Line 606: def start(): Line 607: thread = concurrent.thread(reactor.process_requests, > this also doesn't change anything. daemon=True is the deafult in out concur it's a rebase problem Line 608: name='Client %s:%s' % (host, port)) Line 609: thread.start() Line 610: Line 611: client = StompClient(utils.create_connected_socket(host, port, sslctx), -- To view, visit https://gerrit.ovirt.org/59151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: utils: build cert paths in single place
by igoihman＠redhat.com 31 Oct '16

31 Oct '16

Irit Goihman has posted comments on this change. Change subject: utils: build cert paths in single place ...................................................................... Patch Set 14: Verified+1 -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: virt: Prevent running stuck VM operations
by automation＠ovirt.org 31 Oct '16

31 Oct '16

gerrit-hooks has posted comments on this change. Change subject: virt: Prevent running stuck VM operations ...................................................................... Patch Set 2: * update_tracker: OK -- To view, visit https://gerrit.ovirt.org/59735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfb9c2516d29c2769d195c1269a7bed3260d8ba3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: virt: Prevent running stuck VM operations
by mzamazal＠redhat.com 31 Oct '16

31 Oct '16

Milan Zamazal has abandoned this change. Change subject: virt: Prevent running stuck VM operations ...................................................................... Abandoned -- To view, visit https://gerrit.ovirt.org/59735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibfb9c2516d29c2769d195c1269a7bed3260d8ba3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: utils: build cert paths in single place
by Dan Kenigsberg 31 Oct '16

31 Oct '16

Dan Kenigsberg has posted comments on this change. Change subject: utils: build cert paths in single place ...................................................................... Patch Set 14: -Code-Review -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: utils: build cert paths in single place
by Dan Kenigsberg 31 Oct '16

31 Oct '16

Dan Kenigsberg has posted comments on this change. Change subject: utils: build cert paths in single place ...................................................................... Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 154: EXT_KVM_2_OVIRT = '@LIBEXECDIR@/kvm2ovirt' Line 155: EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@' Line 156: Line 157: # location of the certificates Line 158: PKI_DIR = os.path.join(SYSCONF_PATH, 'pki', 'vdsm') > Puting all constants in single module is not junkyard, this is a good way t constants that do not have a "natural" owner should in this junkyard. But I was suspecting that this particular constant (and many others) can sit in a module that should be important anyway in order to use them. However, I see that Irit says this is not possible, so I'm dropping my -1 (but expecting a better explanation WHY this is impossible). Line 159: KEY_FILE = os.path.join(PKI_DIR, 'keys', 'vdsmkey.pem') Line 160: CERT_FILE = os.path.join(PKI_DIR, 'certs', 'vdsmcert.pem') -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.
by automation＠ovirt.org 31 Oct '16

31 Oct '16

gerrit-hooks has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. ...................................................................... Patch Set 8: * update_tracker: OK * Set MODIFIED::bug 1306698::::#1306698::::IGNORE, not all related patches are closed, check 65564 -- To view, visit https://gerrit.ovirt.org/65565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.
by Dan Kenigsberg 31 Oct '16

31 Oct '16

Dan Kenigsberg has submitted this change and it was merged. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. ...................................................................... Allow pinning of VM NUMA nodes to host NUMA nodes. Adds <memnode> elements to the <numatune> element in the libvirt domain XML. Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c Bug-Url: https://bugzilla.redhat.com/1306698 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/65565 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <fromani(a)redhat.com> Reviewed-by: Martin Polednik <mpolednik(a)redhat.com> --- M lib/api/vdsm-api.yml M tests/vmTests.py M vdsm/virt/vmxml.py 3 files changed, 46 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Andrej Krejcir: Verified Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21004c18962d00a9df411770b24f2123d9226b4c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: volume: Add compat level to volume's info
by Maor Lipchuk 30 Oct '16

30 Oct '16

Maor Lipchuk has uploaded a new change for review. Change subject: volume: Add compat level to volume's info ...................................................................... volume: Add compat level to volume's info Change-Id: Ic01646173a2b62dabb965cd79e393ca65e724f3b Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M vdsm/storage/volume.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/65867/1 diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py index d7d65d7..73c14c9 100644 --- a/vdsm/storage/volume.py +++ b/vdsm/storage/volume.py @@ -231,6 +231,8 @@ info['truesize'] = str(avsize) info['status'] = "OK" info['lease'] = self.getLeaseStatus() + domain = sdCache.produce(self.sdUUID) + info['qcow2compat'] = domain.qcow2_compat() except se.StorageException as e: self.log.debug("exception: %s:%s" % (str(e.message), str(e.value))) info['apparentsize'] = "0" -- To view, visit https://gerrit.ovirt.org/65867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic01646173a2b62dabb965cd79e393ca65e724f3b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>

2 2

Change in vdsm[master]: utils: build cert paths in single place
by ybronhei＠redhat.com 30 Oct '16

30 Oct '16

Yaniv Bronhaim has posted comments on this change. Change subject: utils: build cert paths in single place ...................................................................... Patch Set 14: Code-Review+1 lets monitor the sos paths collection in separate bugzilla and add it after splitting the constant module (other bugzilla to monitor. please open the two) -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches October 2016