Dan Kenigsberg has posted comments on this change.
Change subject: Fix metadata file permissions for fileSD ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/storage/fileSD.py Line 120: os.path.join(metadataDir, metaFile), 0, 0660) that's more than a change of permissions, but also a change in the created file.
I find the commit message misleading
(yeah, we spoke about it on irc, but let's not forget)
-- To view, visit http://gerrit.ovirt.org/1252 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I97ab4f724b8f061161da414c1fc3cfd493298430 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com