Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63478
to review the following change.
Change subject: Fix return value names for VM.ioTune calls ......................................................................
Fix return value names for VM.ioTune calls
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832 Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Signed-off-by: Martin Sivak msivak@redhat.com Reviewed-on: https://gerrit.ovirt.org/60513 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani fromani@redhat.com --- M tests/vmTests.py M vdsm/virt/vm.py 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/63478/1
diff --git a/tests/vmTests.py b/tests/vmTests.py index 6d38f46..7965317 100644 --- a/tests/vmTests.py +++ b/tests/vmTests.py @@ -864,7 +864,7 @@ u'totalBytes': 9999 }} ] - self.assertEqual(tunables['ioTunePolicy'], expected) + self.assertEqual(tunables['ioTunePolicyList'], expected)
def testSetIoTune(self):
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 7fdcacf..8456f9e 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2738,12 +2738,12 @@ qos = self._getVmPolicy() ioTuneList = qos.getElementsByTagName("ioTune") if not ioTuneList or not ioTuneList[0].hasChildNodes(): - return response.success(ioTunePolicy=[]) + return response.success(ioTunePolicyList=[])
for device in ioTuneList[0].getElementsByTagName("device"): tunables.append(io_tune_dom_to_values(device))
- return response.success(ioTunePolicy=tunables) + return response.success(ioTunePolicyList=tunables)
def getIoTune(self): resultList = [] @@ -2776,7 +2776,7 @@ else: return response.error('updateIoTuneErr', e.message)
- return response.success(ioTune=resultList) + return response.success(ioTuneList=resultList)
def setIoTune(self, tunables): for io_tune_change in tunables: