Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

[Martin Sivak]

Hello Francesco Romani,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/63478

to review the following change.

Change subject: Fix return value names for VM.ioTune calls
......................................................................

Fix return value names for VM.ioTune calls

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Signed-off-by: Martin Sivak <msivak(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/60513
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani(a)redhat.com&gt;
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/63478/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 6d38f46..7965317 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -864,7 +864,7 @@
                      u'totalBytes': 9999
                  }}
             ]
-            self.assertEqual(tunables['ioTunePolicy'], expected)
+            self.assertEqual(tunables['ioTunePolicyList'], expected)
 
     def testSetIoTune(self):
 
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7fdcacf..8456f9e 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2738,12 +2738,12 @@
         qos = self._getVmPolicy()
         ioTuneList = qos.getElementsByTagName("ioTune")
         if not ioTuneList or not ioTuneList[0].hasChildNodes():
-            return response.success(ioTunePolicy=[])
+            return response.success(ioTunePolicyList=[])
 
         for device in ioTuneList[0].getElementsByTagName("device"):
             tunables.append(io_tune_dom_to_values(device))
 
-        return response.success(ioTunePolicy=tunables)
+        return response.success(ioTunePolicyList=tunables)
 
     def getIoTune(self):
         resultList = []
@@ -2776,7 +2776,7 @@
                 else:
                     return response.error('updateIoTuneErr', e.message)
 
-        return response.success(ioTune=resultList)
+        return response.success(ioTuneList=resultList)
 
     def setIoTune(self, tunables):
         for io_tune_change in tunables:


-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
......................................................................


Patch Set 1:

* #1373832::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public bug
* Check Product::#1373832::OK, Correct classification oVirt
* Check TM::#1373832::ERROR, wrong target milestone for stable branch, --- should match
^.*4.0.*
* Check merged to previous::OK,         change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
......................................................................


Patch Set 2:

* #1373832::Update tracker: OK
* #60513::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public bug
* Check Product::#1373832::OK, product: vdsm
* Check Product::#60513::IGNORE, not relevant for classification: Retired
* Check TM::#1373832::OK, correct target milestone ovirt-4.0.5
* Check merged to previous::OK,         change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Andrej Krejcir has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
......................................................................


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
......................................................................


Patch Set 3:

* #1373832::Update tracker: OK
* #60513::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public bug
* Check Product::#1373832::OK, product: vdsm
* Check Product::#60513::IGNORE, not relevant for classification: Retired
* Check TM::#1373832::OK, correct target milestone ovirt-4.0.5
* Check merged to previous::OK,         change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
......................................................................


Patch Set 3:

please backport again to the ovirt-4.0.5 branch if you want this in 4.0.5 - otherwise will
be in 4.0.6 and onwards.

-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has submitted this change and it was merged.

Change subject: Fix return value names for VM.ioTune calls
......................................................................


Fix return value names for VM.ioTune calls

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/60513
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/63478
Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Andrej Krejcir: Verified



-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;

gerrit-hooks has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
......................................................................


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::bug 1373832::::#1373832::::IGNORE, not all related patches are closed,
check 63479

-- 
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No