Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client

[Martin Sivak]

Hello Piotr Kliczewski, Francesco Romani, Andrej Krejcir,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/63479

to review the following change.

Change subject: Add all MOM calls to jsonrpc client
......................................................................

Add all MOM calls to jsonrpc client

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Signed-off-by: Martin Sivak <msivak(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/60492
Reviewed-by: Francesco Romani <fromani(a)redhat.com&gt;
Tested-by: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
---
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
2 files changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/63479/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index caffb9a..1854869 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -60,6 +60,8 @@
     'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
     'getDeviceList': 'Host.getDeviceList',
     'getImagesList': 'StorageDomain.getImages',
+    'getIoTunePolicy': 'VM.getIoTunePolicy',
+    'getIoTune': 'VM.getIoTune',
     'getSpmStatus': 'StoragePool.getSpmStatus',
     'getStorageDomainInfo': 'StorageDomain.getInfo',
     'getStorageDomainsList': 'Host.getStorageDomains',
@@ -93,10 +95,12 @@
     'setBalloonTarget': 'VM.setBalloonTarget',
     'setCpuTunePeriod': 'VM.setCpuTunePeriod',
     'setCpuTuneQuota': 'VM.setCpuTuneQuota',
+    'setKsmTune': 'Host.setKsmTune',
     'setMOMPolicy': 'Host.setMOMPolicy',
     'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
     'setupNetworks': 'Host.setupNetworks',
     'setVmTicket': 'VM.setTicket',
+    'setIoTune': 'VM.setIoTune',
     'setVolumeDescription': 'Volume.setDescription',
     'shutdown': 'VM.shutdown',
     'spmStart': 'StoragePool.spmStart',
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 273bd2e..192de42 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -349,7 +349,7 @@
     'Host_getVMFullList': {'call': Host_getVMFullList_Call,
'ret': 'vmList'},
     'Host_getAllVmStats': {'ret': 'statsList'},
     'Host_setupNetworks': {'ret': 'status'},
-    'Host_setKsmTune': {'ret': 'taskStatus'},
+    'Host_setKsmTune': {'ret': 'status'},
     'Image_cloneStructure': {'ret': 'uuid'},
     'Image_delete': {'ret': 'uuid'},
     'Image_deleteVolumes': {'ret': 'uuid'},
@@ -402,11 +402,12 @@
     'VM_migrationCreate': {'ret': VM_migrationCreate_Ret},
     'VM_getMigrationStatus': {'ret': 'migrationStats'},
     'VM_pause': {'ret': VM_running_state_change_Ret},
-    'VM_setCpuTunePeriod': {'ret': 'taskStatus'},
-    'VM_setCpuTuneQuota': {'ret': 'taskStatus'},
+    'VM_setCpuTunePeriod': {'ret': 'status'},
+    'VM_setCpuTuneQuota': {'ret': 'status'},
     'VM_hotplugMemory':  {'ret': 'vmList'},
     'VM_setNumberOfCpus': {'ret': 'vmList'},
-    'VM_setIoTune': {'ret': 'taskStatus'},
+    'VM_setIoTune': {'ret': 'status'},
+    'VM_setBalloonTarget': {'ret': 'status'},
     'VM_updateDevice': {'ret': 'vmList'},
     'Volume_copy': {'ret': 'uuid'},
     'Volume_create': {'ret': 'uuid'},


-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
......................................................................


Patch Set 1:

* #1373832::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public bug
* Check Product::#1373832::OK, Correct classification oVirt
* Check TM::#1373832::ERROR, wrong target milestone for stable branch, --- should match
^.*4.0.*
* Check merged to previous::OK,         change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
......................................................................


Patch Set 2:

* #1373832::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public bug
* Check merged to previous::OK,         change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Andrej Krejcir has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
......................................................................


Patch Set 3:

* #1373832::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public bug
* Check merged to previous::OK,         change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
......................................................................


Patch Set 3:

please backport again to the ovirt-4.0.5 branch if you want this in 4.0.5 - otherwise will
be in 4.0.6 and onwards.

-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has submitted this change and it was merged.

Change subject: Add all MOM calls to jsonrpc client
......................................................................


Add all MOM calls to jsonrpc client

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/60492
Reviewed-by: Francesco Romani <fromani(a)redhat.com&gt;
Tested-by: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Reviewed-on: https://gerrit.ovirt.org/63479
---
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
2 files changed, 9 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Andrej Krejcir: Verified



-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;

gerrit-hooks has posted comments on this change.

Change subject: Add all MOM calls to jsonrpc client
......................................................................


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::bug 1373832::::#1373832::SKIPPED, The branch 'ovirt-4.0.5' for the
current target milestone 'ovirt-4.0.5' exists.

-- 
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98839db856b0b450c5b09975a08c60b542f18b6a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com&gt;
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No