Martin Polednik has posted comments on this change.
Change subject: vm: split device init from domDependentInit ......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/59814/5/vdsm/virt/vm.py File vdsm/virt/vm.py:
PS5, Line 1883: def _dom_init_devices(self): This function is too packed. I believe it would be slightly better to keep first 3 calls in the (now) caller, factor out port mirroring and possibly leave console preparation in the caller also.
After that, it makes sense to consider if moving the 4-5 calls elsewhere is a good idea.