Martin Polednik has posted comments on this change.
Change subject: vm: split device init from domDependentInit
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/59814/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS5, Line 1883: def _dom_init_devices(self):
This function is too packed. I believe it would be slightly better to keep first 3 calls
in the (now) caller, factor out port mirroring and possibly leave console preparation in
the caller also.
After that, it makes sense to consider if moving the 4-5 calls elsewhere is a good idea.
--
To view, visit
https://gerrit.ovirt.org/59814
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes