Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options

Hello Nir Soffer, Milan Zamazal,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/65307

to review the following change.

Change subject: virt: Make boolean values from boolean migration options
......................................................................

virt: Make boolean values from boolean migration options

`compressed' and `autoConverge' migration options have boolean values in
the string form.  They must be converted to actual booleans before they
are checked.

Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1
Bug-Url: https://bugzilla.redhat.com/1380822
Backport-To: 4.0
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/65007
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/65108
---
M vdsm/virt/migration.py
1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/65307/1

diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index e502756..edd2c79 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -100,6 +100,8 @@
         self._dstparams = dstparams
         self._enableGuestEvents = kwargs.get('enableGuestEvents', False)
         self._machineParams = {}
+        # TODO: utils.tobool shouldn't be used in this constructor, the
+        # conversions should be handled properly in the API layer
         self._tunneled = utils.tobool(tunneled)
         self._abortOnError = utils.tobool(abortOnError)
         self._consoleAddress = consoleAddress
@@ -110,8 +112,8 @@
             kwargs.get('maxBandwidth') or
             config.getint('vars', 'migration_max_bandwidth')
         )
-        self._autoConverge = autoConverge
-        self._compressed = compressed
+        self._autoConverge = utils.tobool(autoConverge)
+        self._compressed = utils.tobool(compressed)
         self._incomingLimit = kwargs.get('incomingLimit')
         self._outgoingLimit = kwargs.get('outgoingLimit')
         self.status = {

gerrit-hooks has posted comments on this change.

Change subject: virt: Make boolean values from boolean migration options
......................................................................

Patch Set 1:

* #65108::Update tracker: OK
* #1380822::Update tracker: OK
* #65007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1380822::OK, public bug
* Check Product::#65108::IGNORE, not relevant for classification: Red Hat
* Check Product::#1380822::OK, product: vdsm
* Check Product::#65007::IGNORE, not relevant for classification: Retired
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])

Milan Zamazal has posted comments on this change.

Change subject: virt: Make boolean values from boolean migration options
......................................................................

Patch Set 1: Code-Review+1 Verified+1

Verified that migration still works and the options values are set as requested.

Francesco Romani has posted comments on this change.

Change subject: virt: Make boolean values from boolean migration options
......................................................................

Patch Set 1: Continuous-Integration+1

run 'make check' locally and independently

Francesco Romani has posted comments on this change.

Change subject: virt: Make boolean values from boolean migration options
......................................................................

Patch Set 1: Code-Review+2

Francesco Romani has submitted this change and it was merged.

Change subject: virt: Make boolean values from boolean migration options
......................................................................

virt: Make boolean values from boolean migration options

`compressed' and `autoConverge' migration options have boolean values in
the string form.  They must be converted to actual booleans before they
are checked.

Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1
Bug-Url: https://bugzilla.redhat.com/1380822
Backport-To: 4.0
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/65007
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/65108
Reviewed-on: https://gerrit.ovirt.org/65307
Continuous-Integration: Francesco Romani 
---
M vdsm/virt/migration.py
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Francesco Romani: Looks good to me, approved; Passed CI tests
  Milan Zamazal: Verified; Looks good to me, but someone else must approve

gerrit-hooks has posted comments on this change.

Change subject: virt: Make boolean values from boolean migration options
......................................................................

Patch Set 2:

* #1380822::Update tracker: OK
* Set MODIFIED::bug 1380822::::#1380822::::OK