Change in vdsm[master]: recoveryMode param is never used
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: recoveryMode param is never used
......................................................................
Patch Set 7: Verified; Looks good to me, approved
--
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb7b5b491ad9899bd433ebaadc55cf6d46575edc
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: Made spm securing logic more generic
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Made spm securing logic more generic
......................................................................
Patch Set 8: Verified; Looks good to me, approved
--
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e16feafc03d6efe5c904b18d4d27177dd14b905
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: Merged SPM to StoragePool and HSM
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Merged SPM to StoragePool and HSM
......................................................................
Patch Set 8: Verified; Looks good to me, approved
--
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia016ba62a9436dd4f655bddc0921d60f5211781b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: Related to BZ#744704 - Do not stop SPM task if in 'racquirin...
by smizrahi＠redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Related to BZ#744704 - Do not stop SPM task if in 'racquiring' state
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1042
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36459bea9cfe9b095f2cfb8d88cc142d248c77a4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#744704 - Add rollback support for complex tasks
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: BZ#744704 - Add rollback support for complex tasks
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File vdsm/storage/blockVolume.py
Line 249: cls.log.warn("Cannot deactivate new created volume %s/%s", sdUUID, volUUID, exc_info=True)
Line 250:
Line 251: # Remove all previous rollbacks for 'halfbaked' volume and add rollback for 'real' volume creation
Line 252: vars.task.replaceRecoveries(task.Recovery("create block volume rollback", "blockVolume", "BlockVolume", "createVolumeRollback",
Line 253: [repoPath, sdUUID, imgUUID, volUUID, imageDir]), True)
Done
Line 254: return volUUID
Line 255:
Line 256:
Line 257: def delete(self, postZero, force):
....................................................
File vdsm/storage/task.py
Line 73: FIELD_SEP = ","
Line 74: RESOURCE_SEP = "!"
Line 75: TASK_METADATA_VERSION = 1
Line 76:
Line 77: STUB_ROLLBACK = "stub rollback"
OK, I'll change it to
STUB_ROLLBACK = "http://en.wikipedia.org/wiki/Sentinel_value"
;)
Line 78:
Line 79: class State:
Line 80: unknown = "unknown"
Line 81: init = "init"
Line 1047: self.recoveries.append(recovery)
Line 1048: self.persist()
Line 1049:
Line 1050:
Line 1051: def replaceRecoveries(self, recovery, singleTask=False):
You are right, for now nobody call it without 'singleTask=True', but in general, I think it's a good idea to have 'remove all recoveries' capabilities.
About the splitting to different functions, I don't know, it will be different functions that have a partially identical code. So, IMHO it's redundant in this case.
Line 1052: if not isinstance(recovery, Recovery):
Line 1053: raise TypeError("recovery param %s(%s) must be Recovery object" % (repr(recovery), type(recovery)))
Line 1054: if not recovery.name:
Line 1055: raise ValueError("replaceRecoveries: name is required")
....................................................
File vdsm/storage/volume.py
Line 327: @classmethod
Line 328: def startCreateVolumeRollback(cls, taskObj, sdUUID, imgUUID, volUUID):
Line 329: cls.log.info("startCreateVolumeRollback: sdUUID=%s imgUUID=%s "\
Line 330: "volUUID=%s " % ( sdUUID, imgUUID, volUUID))
Line 331: # This rollback it's actually do nothing.
Done
Line 332: # In general the createVolume rollbacks are a list of small rollbacks
Line 333: # that replaced by the one major rollback at the end of the task.
Line 334: # This rollback is a simple marker that must to be the first rollback
Line 335: # in the list of createVolume rollbacks.
Line 329: cls.log.info("startCreateVolumeRollback: sdUUID=%s imgUUID=%s "\
Line 330: "volUUID=%s " % ( sdUUID, imgUUID, volUUID))
Line 331: # This rollback it's actually do nothing.
Line 332: # In general the createVolume rollbacks are a list of small rollbacks
Line 333: # that replaced by the one major rollback at the end of the task.
Done
Line 334: # This rollback is a simple marker that must to be the first rollback
Line 335: # in the list of createVolume rollbacks.
Line 336: # We need it in cases when createVolume is a part of more complex task and
Line 337: # not a task by itself. In such cases when we will replace the list of
--
To view, visit http://gerrit.usersys.redhat.com/1041
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie36ac02475f3f6438a63fbcbd26730862216cebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#745390 always report product=RHEV to guest bios
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#745390 always report product=RHEV to guest bios
......................................................................
BZ#745390 always report product=RHEV to guest bios
Laziness is dangerous; patches should be checked.
Change-Id: I5dee9473c7570134cb8ade66efa07fe223d59b55
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1055
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5dee9473c7570134cb8ade66efa07fe223d59b55
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: The start of exceptions being independent from the interface
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: The start of exceptions being independent from the interface
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/dispatcher.py
Line 95: self.log.error(e, exc_info=True)
Line 96: defaultException = ctask.defaultException
Line 97: if defaultException and hasattr(defaultException, "response"):
Line 98: resp = defaultException.response()
Line 99: defaultException = (resp['status']['code'], resp['status']['message'])
very confusing. is defaultException an exception or a tuple?
Line 100: return se.generateResponse(e, defaultException)
Line 101:
Line 102: return se.generateResponse(e)
Line 103: except:
--
To view, visit http://gerrit.usersys.redhat.com/1021
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic85a93ff0aa42369db477bfef2d7a340851cae73
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: Refactor dispatcher unicode handling
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Refactor dispatcher unicode handling
......................................................................
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1020
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id007710654e5ddbb41c269f624646159fbbc904e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
