Change in vdsm[master]: BZ#741203 Use cached node id if SPM is active
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#741203 Use cached node id if SPM is active
......................................................................
BZ#741203 Use cached node id if SPM is active
Do not invalidate the metadata cache if the node is the SPM and it
is active. This will prevent the getStoragePoolInfo call to be stuck
when the domain is unreachable and at the same time won't break the
fix for BZ#733909.
In the patch:
* add the attribute isSPM to the StoragePool class
* the SPM never requires to invalidate the cache
Change-Id: Iee15c4b35a415e9ea460b1ce6a4afa14d147ed8d
---
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/sp.py
M vdsm/storage/spm.py
4 files changed, 34 insertions(+), 35 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1004
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee15c4b35a415e9ea460b1ce6a4afa14d147ed8d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#741203 Use cached node id if SPM is active
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#741203 Use cached node id if SPM is active
......................................................................
Patch Set 5: Verified; Looks good to me, approved
kinda-verified by Rami, not looking good to me, but I'm biting the bullet.
--
To view, visit http://gerrit.usersys.redhat.com/1004
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee15c4b35a415e9ea460b1ce6a4afa14d147ed8d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#741203 Don't return a value in domain selftest
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#741203 Don't return a value in domain selftest
......................................................................
BZ#741203 Don't return a value in domain selftest
The domain selftest doesn't need to return a boolean value, if the check
fails an exception is raised.
Change-Id: I551970c1f426f2b28ad58e49310338de6b40a29f
---
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/nfsSD.py
M vdsm/storage/sd.py
M vdsm/storage/sp.py
5 files changed, 3 insertions(+), 9 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1012
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I551970c1f426f2b28ad58e49310338de6b40a29f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#741203 Don't return a value in domain selftest
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#741203 Don't return a value in domain selftest
......................................................................
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1012
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I551970c1f426f2b28ad58e49310338de6b40a29f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#741203 Don't return a value in domain selftest
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#741203 Don't return a value in domain selftest
......................................................................
Patch Set 3: Verified; Looks good to me, approved
Sorry Saggi, you would have to rebase.
--
To view, visit http://gerrit.usersys.redhat.com/1012
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I551970c1f426f2b28ad58e49310338de6b40a29f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#746766 deployUtil: set proper selinux context to .ssh/aut...
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#746766 deployUtil: set proper selinux context to .ssh/authorized_hosts
......................................................................
BZ#746766 deployUtil: set proper selinux context to .ssh/authorized_hosts
Change-Id: I6833b991f89033b0b6ab0c85fb6f8df49809ea26
---
M vdsm_reg/deployUtil.py.in
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
Objections:
Eduardo Warszawski: I would prefer that you didn't submit this
--
To view, visit http://gerrit.usersys.redhat.com/1045
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6833b991f89033b0b6ab0c85fb6f8df49809ea26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 7 months
Change in vdsm[master]: BZ#746766 deployUtil: set proper selinux context to .ssh/aut...
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#746766 deployUtil: set proper selinux context to .ssh/authorized_hosts
......................................................................
Patch Set 1: Verified; Looks good to me, approved
Sorry Eduardo, I have to take it now.
--
To view, visit http://gerrit.usersys.redhat.com/1045
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6833b991f89033b0b6ab0c85fb6f8df49809ea26
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 7 months