vdsm-patches October 2011

vdsm-patches@lists.fedorahosted.org

14 participants
403 discussions

Change in vdsm[master]: isMounted() now handles / at end of export in certain distro...
by Haim Ateya 30 Oct '11

30 Oct '11

Haim Ateya has posted comments on this change. Change subject: isMounted() now handles / at end of export in certain distros ...................................................................... Patch Set 2: Verified -- To view, visit http://gerrit.usersys.redhat.com/1072 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbba23b8a2d89a037ba809a86591ab33239ce24 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: isMounted() now handles / at end of export in certain distro...
by Igor Lvovsky 30 Oct '11

30 Oct '11

Igor Lvovsky has posted comments on this change. Change subject: isMounted() now handles / at end of export in certain distros ...................................................................... Patch Set 2: Looks good to me, but someone else must approve Saggy cries that he don't likes "". -- To view, visit http://gerrit.usersys/1072 To unsubscribe, visit http://gerrit.usersys/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbba23b8a2d89a037ba809a86591ab33239ce24 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: isMounted() now handles / at end of export in certain distro...
by smizrahi＠redhat.com 30 Oct '11

30 Oct '11

Saggi Mizrahi has posted comments on this change. Change subject: isMounted() now handles / at end of export in certain distros ...................................................................... Patch Set 2: (3 inline comments) .................................................... File vdsm/storage/fileUtils.py Line 154: return True Line 155: Line 156: return False Line 157: Line 158: def isMounted(resource=None, mountPoint=None, mountType=None): I hate using empty strings, None is empty value Line 159: """ Line 160: Verify that "resource" (if given) is mounted on "mountPoint" Line 161: """ Line 162: if mountPoint is None and resource is None: Line 158: def isMounted(resource=None, mountPoint=None, mountType=None): Line 159: """ Line 160: Verify that "resource" (if given) is mounted on "mountPoint" Line 161: """ Line 162: if mountPoint is None and resource is None: Nope, only None is an acceptable empty value. Line 163: raise ValueError("`mountPoint` or `resource` must be specified") Line 164: Line 165: cleanPath = lambda path: path[:-1] if path is not None and path.endswith("/") else path Line 166: Line 173: (res, mp, fs) = m[0:3] Line 174: res = cleanPath(res) Line 175: mp = cleanPath(mp) Line 176: Line 177: if ( (mountPoint is None or mp == mountPoint) Nope Line 178: and (resource is None or res == resource) Line 179: and (mountType is None or fs.startswith(mountType)) ): Line 180: return True Line 181: -- To view, visit http://gerrit.usersys.redhat.com/1072 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbba23b8a2d89a037ba809a86591ab33239ce24 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Changed default bridge name to engine
by smizrahi＠redhat.com 30 Oct '11

30 Oct '11

Saggi Mizrahi has submitted this change and it was merged. Change subject: Changed default bridge name to engine ...................................................................... Changed default bridge name to engine Change-Id: Iad298199b273753f921a2abfef16567d3e5a6033 --- M vdsm/clientIF.py M vdsm/config.py M vdsm/libvirtvm.py 3 files changed, 9 insertions(+), 3 deletions(-) Approvals: Igor Lvovsky: Looks good to me, but someone else must approve Saggi Mizrahi: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/1071 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad298199b273753f921a2abfef16567d3e5a6033 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Changed default bridge name to engine
by smizrahi＠redhat.com 30 Oct '11

30 Oct '11

Saggi Mizrahi has posted comments on this change. Change subject: Changed default bridge name to engine ...................................................................... Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/1071 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad298199b273753f921a2abfef16567d3e5a6033 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: isMounted() now handles / at end of export in certain distro...
by Igor Lvovsky 30 Oct '11

30 Oct '11

Igor Lvovsky has posted comments on this change. Change subject: isMounted() now handles / at end of export in certain distros ...................................................................... Patch Set 2: I would prefer that you didn't submit this (3 inline comments) .................................................... File vdsm/storage/fileUtils.py Line 154: return True Line 155: Line 156: return False Line 157: Line 158: def isMounted(resource=None, mountPoint=None, mountType=None): Default should be empty string and simplify the lambda below. Line 159: """ Line 160: Verify that "resource" (if given) is mounted on "mountPoint" Line 161: """ Line 162: if mountPoint is None and resource is None: Line 158: def isMounted(resource=None, mountPoint=None, mountType=None): Line 159: """ Line 160: Verify that "resource" (if given) is mounted on "mountPoint" Line 161: """ Line 162: if mountPoint is None and resource is None: Better: if not mountPoint and not resource Line 163: raise ValueError("`mountPoint` or `resource` must be specified") Line 164: Line 165: cleanPath = lambda path: path[:-1] if path is not None and path.endswith("/") else path Line 166: Line 173: (res, mp, fs) = m[0:3] Line 174: res = cleanPath(res) Line 175: mp = cleanPath(mp) Line 176: Line 177: if ( (mountPoint is None or mp == mountPoint) Same as above, remove None's Line 178: and (resource is None or res == resource) Line 179: and (mountType is None or fs.startswith(mountType)) ): Line 180: return True Line 181: -- To view, visit http://gerrit.usersys/1072 To unsubscribe, visit http://gerrit.usersys/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbba23b8a2d89a037ba809a86591ab33239ce24 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Changed default bridge name to engine
by Igor Lvovsky 30 Oct '11

30 Oct '11

Igor Lvovsky has posted comments on this change. Change subject: Changed default bridge name to engine ...................................................................... Patch Set 1: Looks good to me, but someone else must approve Fix the bootstrap too. -- To view, visit http://gerrit.usersys/1071 To unsubscribe, visit http://gerrit.usersys/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad298199b273753f921a2abfef16567d3e5a6033 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>

1 0

Change in vdsm[master]: Fixed reconstruct master
by smizrahi＠redhat.com 30 Oct '11

30 Oct '11

Saggi Mizrahi has submitted this change and it was merged. Change subject: Fixed reconstruct master ...................................................................... Fixed reconstruct master Change-Id: Ic7aa064dc07f2b26b3681be52a07901da197200b --- M vdsm/storage/sp.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Igor Lvovsky: Looks good to me, but someone else must approve Saggi Mizrahi: Verified; Looks good to me, approved -- To view, visit http://gerrit.usersys.redhat.com/1070 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7aa064dc07f2b26b3681be52a07901da197200b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Fixed reconstruct master
by smizrahi＠redhat.com 30 Oct '11

30 Oct '11

Saggi Mizrahi has posted comments on this change. Change subject: Fixed reconstruct master ...................................................................... Patch Set 1: Verified; Looks good to me, approved Verified by hateya -- To view, visit http://gerrit.usersys.redhat.com/1070 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7aa064dc07f2b26b3681be52a07901da197200b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

1 0

Change in vdsm[master]: Fixed reconstruct master
by Igor Lvovsky 30 Oct '11

30 Oct '11

Igor Lvovsky has posted comments on this change. Change subject: Fixed reconstruct master ...................................................................... Patch Set 1: Looks good to me, but someone else must approve Approved but STINKS! -- To view, visit http://gerrit.usersys/1070 To unsubscribe, visit http://gerrit.usersys/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7aa064dc07f2b26b3681be52a07901da197200b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches October 2011