July 2011 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: BZ#725967 - one process pool to rule them all

by erez＠redhat.com

Erez Sh has posted comments on this change. Change subject: BZ#725967 - one process pool to rule them all ...................................................................... Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.usersys/744 To unsubscribe, visit http://gerrit.usersys/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia69071a049761b271a982c600cf0520a782c7eac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com> Gerrit-Reviewer: Erez Sh <erez(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>

12 years, 9 months

1
0
0 / 0

[MERGED PATCH] BZ#698173 updateVM: encode ovf data as utf8 on disk (via gerrit-bot)

by Dan Kenigsberg

Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/746

12 years, 9 months

1
0
0 / 0

[NEW PATCH] BZ#698173 updateVM: encode ovf data as utf8 on disk (via gerrit-bot)

by Dan Kenigsberg

New patch submitted by Dan Kenigsberg (danken(a)redhat.com) You can review this change at: http://gerrit.usersys.redhat.com/746 commit 70013bfa7e51cecfdfce9afa10f616cde346b33f Author: Dan Kenigsberg <danken(a)redhat.com> Date: Tue Jul 26 18:10:22 2011 +0300 BZ#698173 updateVM: encode ovf data as utf8 on disk Change-Id: I83d637010fefd4a7a85f8ebd4d32a4d5ee803102 diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 1ddc3db..24722d6 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -14,6 +14,7 @@ import time import threading import errno import uuid +import codecs import constants import storage_mailbox @@ -935,7 +936,8 @@ class StoragePool: try: os.mkdir(vmPath) - open(os.path.join(vmPath, vmUUID + '.ovf'), 'w').write(ovf) + codecs.open(os.path.join(vmPath, vmUUID + '.ovf'), 'w', + encoding='utf8').write(ovf) except OSError, ex: if ex.errno == errno.ENOSPC: raise se.NoSpaceLeftOnDomain(sdUUID)

12 years, 9 months

2
3
0 / 0

[MERGED PATCH] BZ#720981 - Sometimes devices have whitespace in their name file (via gerrit-bot)

by smizrahi＠redhat.com

Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/751

12 years, 9 months

1
0
0 / 0

[MERGED PATCH] BZ#725963 - Fix error handling in isBlockDevice() (via gerrit-bot)

by smizrahi＠redhat.com

Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/749

12 years, 9 months

1
0
0 / 0

[NEW PATCH] BZ#720981 - Sometimes devices have whitespace in their name file (via gerrit-bot)

by smizrahi＠redhat.com

New patch submitted by Saggi Mizrahi (smizrahi(a)redhat.com) You can review this change at: http://gerrit.usersys.redhat.com/751 commit 92be0f2bb11e069bde0348c0f00edd705db6d4ad Author: Saggi Mizrahi <smizrahi(a)redhat.com> Date: Wed Jul 27 12:37:39 2011 +0300 BZ#720981 - Sometimes devices have whitespace in their name file Change-Id: Id99ab9b8b210616ef13b8acc7ddf2d5ce3f14553 diff --git a/vdsm/storage/devicemapper.py b/vdsm/storage/devicemapper.py index 76d31a3..ed672b7 100644 --- a/vdsm/storage/devicemapper.py +++ b/vdsm/storage/devicemapper.py @@ -21,7 +21,7 @@ def getDmId(deviceMultipathName): for nameFile in glob("/sys/block/dm-*/dm/name"): try: with open(nameFile, "r") as f: - if f.read() == deviceMultipathName: + if f.read().strip() == deviceMultipathName: return nameFile.split("/")[3] except (IOError, OSError): pass

12 years, 9 months

2
7
0 / 0

[NEW PATCH] BZ#725963 - Fix error handling in isBlockDevice() (via gerrit-bot)

by smizrahi＠redhat.com

New patch submitted by Saggi Mizrahi (smizrahi(a)redhat.com) You can review this change at: http://gerrit.usersys.redhat.com/749 commit 654681f63df38137cadf09d08182b2cbfa45f883 Author: Saggi Mizrahi <smizrahi(a)redhat.com> Date: Wed Jul 27 10:43:30 2011 +0300 BZ#725963 - Fix error handling in isBlockDevice() Change-Id: I9f519354e7fec56a85ef908765d33e7b92ad82bb diff --git a/vdsm/storage/devicemapper.py b/vdsm/storage/devicemapper.py index 8873fbd..76d31a3 100644 --- a/vdsm/storage/devicemapper.py +++ b/vdsm/storage/devicemapper.py @@ -70,15 +70,18 @@ def resolveDevName(devName): try: return getDmId(devName) except Exception: - raise OSError(errno.ENOENT, "No such multipath device `%s`" % devName) + raise OSError(errno.ENOENT, "No such block device `%s`" % devName) def isVirtualDevice(devName): devName = resolveDevName(devName) return os.path.exists(os.path.join("/sys/devices/virtual/block/", devName)) def isBlockDevice(devName): - devName = resolveDevName(devName) - return os.path.exists(os.path.join("/sys/block/", devName)) + try: + devName = resolveDevName(devName) + return os.path.exists(os.path.join("/sys/block/", devName)) + except OSError: + return False def getAllSlaves():

12 years, 9 months

4
6
0 / 0

[MERGED PATCH] BZ#688616 keep cgroup off as kernel support is not ready yet (via gerrit-bot)

by Dan Kenigsberg

Patch merged into repository You can review this change at: http://gerrit.usersys.redhat.com/753

12 years, 9 months

1
0
0 / 0

[NEW PATCH] BZ#688616 keep cgroup off as kernel support is not ready yet (via gerrit-bot)

by Dan Kenigsberg

New patch submitted by Dan Kenigsberg (danken(a)redhat.com) You can review this change at: http://gerrit.usersys.redhat.com/753 commit eef6e7a42c405759430ec7c13f37f5e2ae228aaa Author: Dan Kenigsberg <danken(a)redhat.com> Date: Wed Jul 27 15:52:36 2011 +0300 BZ#688616 keep cgroup off as kernel support is not ready yet Sorry for the noise.. Change-Id: Ia92e7ffb499f8c0251da8e216277635c10c733bd diff --git a/vds_bootstrap/vds_bootstrap.py b/vds_bootstrap/vds_bootstrap.py index 70af1a5..e56f651 100755 --- a/vds_bootstrap/vds_bootstrap.py +++ b/vds_bootstrap/vds_bootstrap.py @@ -63,7 +63,7 @@ if rhel6based: VDSM_NAME = "vdsm" VDSM_MIN_VER = VDSM_NAME + "-4.9" KERNEL_VER = "2.6.32-.*.el6" - KERNEL_MIN_VER = 115 + KERNEL_MIN_VER = 150 MINIMAL_SUPPORTED_PLATFORM = "6.0" else: VDSM_NAME = "vdsm22" @@ -110,8 +110,6 @@ CONFLICT_SERVICES = ['cpuspeed'] if rhel6based: NEEDED_SERVICES.append('libvirtd') CONFLICT_SERVICES.append('libvirt-guests') - # Until BZ#623712 is solved - no cgroup for you ! - CONFLICT_SERVICES.append('cgconfig') else: CONFLICT_SERVICES.append('libvirtd') diff --git a/vdsm/vdsmd b/vdsm/vdsmd index 0591cb2..46c0f49 100755 --- a/vdsm/vdsmd +++ b/vdsm/vdsmd @@ -32,9 +32,6 @@ DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup CORE_PATTERN=/proc/sys/kernel/core_pattern NEEDED_SERVICES="iscsid multipathd" CONFLICTING_SERVICES="libvirt-guests libvirtd" -# TODO: Remove cpu cgroup disabling when BZ#623712 is resolved (kernel on -# massively multicore platforms failing to scale with cgroups turned on) -CONFLICTING_SERVICES="cgconfig $CONFLICTING_SERVICES" LCONF=/etc/libvirt/libvirtd.conf QCONF=/etc/libvirt/qemu.conf

12 years, 9 months

3
5
0 / 0

by Dan Kenigsberg

New patch submitted by Dan Kenigsberg (danken(a)redhat.com) You can review this change at: http://gerrit.usersys.redhat.com/750 commit 06dbebcb1500980b963c7758b71d4ad9ee58e13a Author: Dan Kenigsberg <danken(a)redhat.com> Date: Wed Jul 27 12:52:51 2011 +0300 Related to BZ#688616: do not stop cgroup when vdsmd start Oopsy, forgot to revert that one... Change-Id: I5e709e68e1bcdc3bec0a258ec6344ad30c89c0d3 diff --git a/vdsm/vdsmd b/vdsm/vdsmd index 0591cb2..46c0f49 100755 --- a/vdsm/vdsmd +++ b/vdsm/vdsmd @@ -32,9 +32,6 @@ DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup CORE_PATTERN=/proc/sys/kernel/core_pattern NEEDED_SERVICES="iscsid multipathd" CONFLICTING_SERVICES="libvirt-guests libvirtd" -# TODO: Remove cpu cgroup disabling when BZ#623712 is resolved (kernel on -# massively multicore platforms failing to scale with cgroups turned on) -CONFLICTING_SERVICES="cgconfig $CONFLICTING_SERVICES" LCONF=/etc/libvirt/libvirtd.conf QCONF=/etc/libvirt/qemu.conf

12 years, 9 months

3
4
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches July 2011