October 2013 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ...................................................................... Patch Set 7: Code-Review+2 Thanks! -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-HasComments: No

10 years, 6 months

1
0
0 / 0

Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ...................................................................... Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4916/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4031/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/678/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

10 years, 6 months

1
0
0 / 0

Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ...................................................................... Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4915/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4030/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4840/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/677/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

10 years, 6 months

1
0
0 / 0

Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ...................................................................... Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4914/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4029/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4839/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/676/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

10 years, 6 months

1
0
0 / 0

Change in vdsm[master]: Removing unnecessary subshell call

by ybronhei＠redhat.com

Yaniv Bronhaim has uploaded a new change for review. Change subject: Removing unnecessary subshell call ...................................................................... Removing unnecessary subshell call Change-Id: If938a322836a82090671483f47a6a0c49878556a Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M init/sysvinit/vdsmd.init.in 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/20061/1 diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in index efd9c35..e10cca0 100755 --- a/init/sysvinit/vdsmd.init.in +++ b/init/sysvinit/vdsmd.init.in @@ -68,8 +68,8 @@ initctl stop "${srv}" || : # stop fails when already down initctl status "${srv}" | grep -q stop/waiting elif [ -x "/etc/init.d/${srv}" ]; then - (! service "${srv}" status >/dev/null 2>&1) || - service "${srv}" stop + ! service "${srv}" status >/dev/null 2>&1 || + service "${srv}" stop else true fi -- To view, visit http://gerrit.ovirt.org/20061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If938a322836a82090671483f47a6a0c49878556a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>

10 years, 6 months

5
9
0 / 0

Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ...................................................................... Patch Set 4: Code-Review-1 Please note few nit-picking on PS2 and PS3. Other than that, ACK. I believe that the Jenkins failure are unrelated. Toni - could you help here? Oct 10 11:43:59 jenkins-slave-vm01.ovirt.org vdsm[2744]: vdsm vds ERROR interface 'dummy_18' already member of network 'test-network' Oct 10 11:43:59 jenkins-slave-vm01.ovirt.org vdsm[2744]: vdsm vds ERROR interface 'dummy_18' already has networks -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

10 years, 6 months

1
0
0 / 0

Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ...................................................................... Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4909/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4024/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/675/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

10 years, 6 months

1
0
0 / 0

Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ...................................................................... Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4908/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4023/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4833/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/674/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

10 years, 6 months

1
0
0 / 0

Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ...................................................................... Patch Set 3: (1 comment) .................................................... File tests/functional/networkTests.py Line 1420: self.vdsm_net.setupNetworks(networks, {}, {}) Line 1421: Line 1422: self.assertTrue(os.path.isfile(hook_cookiefile)) Line 1423: Line 1424: delete_networks = {NETWORK_NAME: {'remove': True}} another nit: please avoid tabs. Line 1425: self.vdsm_net.setupNetworks(delete_networks, Line 1426: {}, {}) Line 1427: Line 1428: @cleanupNet -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

10 years, 6 months

1
0
0 / 0

Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...

by Dan Kenigsberg

Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. ...................................................................... Patch Set 2: (4 comments) .................................................... File AUTHORS Line 8: Federico Simoncelli <fsimonce(a)redhat.com> Line 9: Saggi Mizrahi <smizrahi(a)redhat.com> Line 10: Line 11: Patches have also been contributed by (ordered by lastname): Line 12: trailing whitespace showing up as red in gerrit. Line 13: Miguel Angel Ajo <miguelangel(a)ajo.es> Line 14: Timothy Asir <tjeyasin(a)redhat.com> Line 15: Haim Ateya <hateya(a)redhat.com> Line 16: Daniel P. Berrange <berrange(a)redhat.com> .................................................... File tests/Makefile.am Line 104: apiData.py \ Line 105: monkeypatch.py \ Line 106: testrunner.py \ Line 107: testValidation.py \ Line 108: hookValidation.py Please keep sorted, and add a trailing $(NULL) at the end. Line 109: Line 110: dist_vdsmtests_SCRIPTS = \ Line 111: run_tests.sh \ Line 112: testValidation.py \ .................................................... File vdsm/vdsmd.8.in Line 63: .FN /usr/libexec/vdsm/hooks/<hook-name>/ Line 64: in lexicographic order. Line 65: Line 66: .SS Hook environment Line 67: Each hook script (except before_vdsm_start, after_vdsm_stop, before_network_setup please keep under 80 chars. It's easier to review. Line 68: and after_network_setup)) inherit the environment of the VDSM process, with an Line 69: additional variable Line 70: .B _hook_domxml Line 71: which holds the path of libvirt's .................................................... File vdsm_hooks/Makefile.am Line 100: after_disk_hotunplug \ Line 101: before_vdsm_start \ Line 102: after_vdsm_stop \ Line 103: before_network_setup \ Line 104: after_network_setup Could you append $(NULL) here, too? Line 105: Line 106: all-local: \ Line 107: $(nodist_vdsmexec_SCRIPTS) Line 108: -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <miguelangel(a)ajo.es> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

10 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches October 2013