Change in vdsm[master]: vm: state change missing return value
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: state change missing return value
......................................................................
vm: state change missing return value
Return arguments where ignored in schema for pause and resume verbs.
We had to update command_info with following verbs to returned
'vmList' dictionary required by the engine.
Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1163089
Reviewed-on: http://gerrit.ovirt.org/35105
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Tested-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Omer Frenkel <ofrenkel(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
2 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified; Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/35105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 6 months
Change in vdsm[master]: vm: state change missing return value
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: vm: state change missing return value
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
Change in vdsm[master]: hba: Parallel hba scanning
by Nir Soffer
Nir Soffer has uploaded a new change for review.
Change subject: hba: Parallel hba scanning
......................................................................
hba: Parallel hba scanning
When scanning multiple HBAs, it canning one HBA blocks for long time,
the scan may timeout before we discovering new devices on other HBAs.
We have one bug (https://bugzilla.redhat.com/844180) showing SCSI scan
blocking for more then 80 seconds, but we don't know if this was caused
by iSCSI or FC server. In QE lab, we could not reproduce blocking for
more then couple of milliseconds with FC server, even when disconnecting
the cable.
Now we perform the scan in background threads. In the unlikely case that
a thread is blocked when the deadline reached, it will exit when the
scan is finished.
Because os.write releases the GIL before invoking the blocking write()
call, there is no chance of blocking other threads.
Note that if a scan thread blocks, you cannot terminate or even kill
supervdsm until the scan is finished. Since supervdsm is restarted only
during upgrades, this should be good enough.
We can avoid the restart issue if we use ioprocess, but we don't have
yet iporocess support in supervdsm. Additionally, ioprocess is not
available on current release (3.4) where we need to fix the issue.
Change-Id: I0bcd29551314a55bff2d2cc89f02f5c562f5d016
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/hba.py
1 file changed, 49 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/34407/1
diff --git a/vdsm/storage/hba.py b/vdsm/storage/hba.py
index 9b2e8eb..cf0db37 100644
--- a/vdsm/storage/hba.py
+++ b/vdsm/storage/hba.py
@@ -22,11 +22,13 @@
Collect HBA information
"""
import glob
-import os
import logging
+import os
+import threading
import time
from vdsm.config import config
+from vdsm import utils
log = logging.getLogger("Storage.HBA")
@@ -48,21 +50,56 @@
normal multipath rescanning flow. This procedure will add LUNs, but not
remove them.
- We wait after the scan so multipathd can discover the new devices.
+ Scanning is synchronous operation and may block. To avoid one scan blocking
+ others, we perform the scan in parallel.
Note: Must be executed as root.
"""
- log.info("Rescanning HBAs")
- for path in glob.glob(FC_HOST_MASK + '/device/scsi_host/host*/scan'):
- log.debug("Rescanning %s", path)
- try:
- with open(path, 'wb', 0) as f:
- f.write('- - -')
- except IOError as e:
- logging.error("Error rescanning: %s", e)
+ log.info("Scanning HBAs")
+ hosts = glob.glob(FC_HOST_MASK + '/device/scsi_host/host*/scan')
+ if not hosts:
+ log.debug("No HBA found")
+ return
- delay = config.getint('irs', 'scsi_rescan_minimal_timeout')
- time.sleep(delay)
+ cond = threading.Condition(threading.Lock())
+ scanning = [0]
+
+ @utils.traceback(on=log.name)
+ def scanner(path):
+ try:
+ log.debug("Scanning %s", path)
+ fd = os.open(path, os.O_WRONLY)
+ try:
+ os.write(fd, '- - -')
+ finally:
+ os.close(fd)
+ log.debug("Finished")
+ finally:
+ with cond:
+ scanning[0] -= 1
+ cond.notify()
+
+ for path in hosts:
+ t = threading.Thread(target=scanner, args=(path,))
+ t.daemon = True
+ t.start()
+ with cond:
+ scanning[0] += 1
+
+ start = time.time()
+ deadline = start + config.getint('irs', 'scsi_rescan_maximal_timeout')
+
+ time.sleep(config.getint('irs', 'scsi_rescan_minimal_timeout'))
+
+ with cond:
+ while scanning[0]:
+ now = time.time()
+ if now >= deadline:
+ log.error("Timeout scanning HBAs")
+ return
+ cond.wait(deadline - now)
+
+ log.debug("Scanning finished in %.1f seconds", time.time() - start)
def getiSCSIInitiators():
--
To view, visit http://gerrit.ovirt.org/34407
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bcd29551314a55bff2d2cc89f02f5c562f5d016
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
9 years, 6 months
Change in vdsm[master]: jsonrpc: Wrong key name for getDevicesVisibility
by Maor Lipchuk
Maor Lipchuk has posted comments on this change.
Change subject: jsonrpc: Wrong key name for getDevicesVisibility
......................................................................
Patch Set 1:
Get the following error in the GUI:
"Error while executing action Edit SAN Storage Domain configuration: Physical device initialization failed. Please check that the device is empty and accessible by the host."
--
To view, visit http://gerrit.ovirt.org/35014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63180a87e40e48134e6da8b9996f849362fb5501
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
Change in vdsm[master]: jsonrpc: Wrong key name for getDevicesVisibility
by Maor Lipchuk
Maor Lipchuk has posted comments on this change.
Change subject: jsonrpc: Wrong key name for getDevicesVisibility
......................................................................
Patch Set 1: Verified-1
--
To view, visit http://gerrit.ovirt.org/35014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63180a87e40e48134e6da8b9996f849362fb5501
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
Change in vdsm[master]: jsonrpc: Wrong key name for getDevicesVisibility
by Maor Lipchuk
Maor Lipchuk has posted comments on this change.
Change subject: jsonrpc: Wrong key name for getDevicesVisibility
......................................................................
Patch Set 1: -Verified
Host was not using json, still investigate verification
--
To view, visit http://gerrit.ovirt.org/35014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63180a87e40e48134e6da8b9996f849362fb5501
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
Change in vdsm[master]: jsonrpc: Wrong key name for getDevicesVisibility
by Maor Lipchuk
Maor Lipchuk has posted comments on this change.
Change subject: jsonrpc: Wrong key name for getDevicesVisibility
......................................................................
Patch Set 1: Verified+1
Verfied as follow:
Create iSCSi domain on first DC
Create NFS Domain on first DC
Craete NFS Domain on second DC
detach iSCSi domain and attach it to second dc
extend the iSCSI domain with one more lun.
The extend was successful
--
To view, visit http://gerrit.ovirt.org/35014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63180a87e40e48134e6da8b9996f849362fb5501
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
Change in vdsm[master]: vm: state change missing return value
by ofrenkel＠redhat.com
Omer Frenkel has posted comments on this change.
Change subject: vm: state change missing return value
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
Change in vdsm[master]: vm: state change missing return value
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: vm: state change missing return value
......................................................................
Patch Set 2:
Just to think aloud: as I said I don't know a better way to fix that, but I still wonder why does Engine require this field. I see deep in Engine code it is expected to be present, but don't know why or even if it is still relevant.
--
To view, visit http://gerrit.ovirt.org/35105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
