Change in vdsm[master]: Change clientIF to get port as string and not as int from co...
by alukiano＠redhat.com
Artyom Lukianov has uploaded a new change for review.
Change subject: Change clientIF to get port as string and not as int from config.
......................................................................
Change clientIF to get port as string and not as int from config.
Change-Id: I3021dc9b25581d1e0078e480764eb1202ee517b5
Bug-Url: https://bugzilla.redhat.com/1163771
Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com>
---
M vdsm/clientIF.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/35128/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 440e5e7..b7a7ef8 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -104,7 +104,7 @@
self.threadLocal.client = ''
host = config.get('addresses', 'management_ip')
- port = config.getint('addresses', 'management_port')
+ port = config.get('addresses', 'management_port')
self._createAcceptor(host, port)
self._prepareXMLRPCBinding(port)
self._prepareJSONRPCBinding()
--
To view, visit http://gerrit.ovirt.org/35128
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3021dc9b25581d1e0078e480764eb1202ee517b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com>
9 years, 6 months
Change in vdsm[master]: vm: state change missing return value
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: state change missing return value
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/205/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/35105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.48
by mtayer＠redhat.com
mooli tayer has uploaded a new change for review.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.48
......................................................................
spec: bump policycoreutils-python version to 2.0.83-19.48
New version contains fix for:
seobject.booleanRecords().modify(...)
AttributeError: booleanRecords instance has no attribute 'load'
Change-Id: Idc1c30a157d6763674874113e62add82833bd070
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139873
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/33771/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0dcd82b..ebe2188 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -203,7 +203,7 @@
Requires: kernel >= 2.6.32-279.9.1
Requires: initscripts >= 9.03.31-2.el6_3.1
Requires: policycoreutils >= 2.0.83-19.30
-Requires: policycoreutils-python >= 2.0.83-19.30
+Requires: policycoreutils-python >= 2.0.83-19.48
Requires: selinux-policy-targeted >= 3.7.19-195.el6_4.13
Requires: lvm2 >= 2.02.100-5
Requires: logrotate < 3.8.0
--
To view, visit http://gerrit.ovirt.org/33771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc1c30a157d6763674874113e62add82833bd070
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
9 years, 6 months
Change in vdsm[master]: Makefile: add vdsm-reg-setup.in to pyflakes
by Douglas Schilling Landgraf
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: Makefile: add vdsm-reg-setup.in to pyflakes
......................................................................
Makefile: add vdsm-reg-setup.in to pyflakes
We should run pyflakes in vdsm-reg-setup.in as well.
Change-Id: I6be99965f3249374c99c1d4ab71145d571c13921
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/27025/1
diff --git a/Makefile.am b/Makefile.am
index a7fc23f..ea3a4c3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -66,7 +66,8 @@
check-local:
find . -path './.git' -prune -type f -o \
- -name '*.py' -o -name '*.py.in' | xargs $(PYFLAKES) | \
+ -name '*.py' -o -name '*.py.in' -o \
+ -name 'vdsm-reg-setup.in' | xargs $(PYFLAKES) | \
grep -w -v $(SKIP_PYFLAKES_ERR) | \
while read LINE; do echo "$$LINE"; false; done
$(PEP8) --version
--
To view, visit http://gerrit.ovirt.org/27025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6be99965f3249374c99c1d4ab71145d571c13921
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
9 years, 6 months
Change in vdsm[master]: Fix ballooning behaviour of freshly received VM
by Martin Sivak
Martin Sivák has uploaded a new change for review.
Change subject: Fix ballooning behaviour of freshly received VM
......................................................................
Fix ballooning behaviour of freshly received VM
There is an issue with freshly received VMs. MOM might ask for
the current balloon status before the stats threads collect all
data. The target will be reported as 0 in that case and the VM
will be requested to return all its free memory.
The balloon info method won't return any data before it
has everything ready after this fix is applied.
This also fixes the unittest that was using balloon for checking
whether the stats system works.
Change-Id: If44c8e9d65b7221b2dec5fdd1f2d7d4343f7aeaa
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M tests/vmTests.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vm.py
3 files changed, 25 insertions(+), 20 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/34887/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 07dc6be..effc8a6 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -1495,10 +1495,9 @@
with fake.VM(self.VM_PARAMS, self.DEV_BALLOON) as testvm:
self.assertEqual(testvm._dom, None)
mock_stats_thread = vm.VmStatsThread(testvm)
- res = {}
- mock_stats_thread._getBalloonStats(res)
+ res = mock_stats_thread.get()
self.assertIn('balloonInfo', res)
- self.assertIn('balloon_cur', res['balloonInfo'])
+ self.assertNotIn('balloon_cur', res['balloonInfo'])
def testGetStatsDomInfoFail(self):
# bz1073478 - extra case
@@ -1506,10 +1505,8 @@
testvm._dom = fake.Domain(
virtError=libvirt.VIR_ERR_NO_DOMAIN)
mock_stats_thread = vm.VmStatsThread(testvm)
- res = {}
- mock_stats_thread._getBalloonStats(res)
+ res = mock_stats_thread.get()
self.assertIn('balloonInfo', res)
- self.assertIn('balloon_cur', res['balloonInfo'])
def testMultipleGraphicDeviceStats(self):
devices = [{'type': 'graphics', 'device': 'spice', 'port': '-1'},
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 624b686..0074223 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -6320,21 +6320,22 @@
##
# @BalloonInfo:
#
-# Guest memory balloon information.
+# Guest memory balloon information. Values are present only when the
+# balloon is enabled and ready.
#
-# @balloon_max: The maximum amount of memory available to the guest (in KiB)
+# @balloon_max: #optional The maximum amount of memory available to the guest (in KiB)
#
-# @balloon_cur: The current amount of memory available to the guest (in KiB)
+# @balloon_cur: #optional The current amount of memory available to the guest (in KiB)
#
-# @balloon_min: The minimum amount of memory guaranteed to the guest (in KiB)
+# @balloon_min: #optional The minimum amount of memory guaranteed to the guest (in KiB)
#
-# @balloon_target: The amount of memory requested (in KiB)
+# @balloon_target: #optional The amount of memory requested (in KiB)
#
# Since: 4.10.0
##
{'type': 'BalloonInfo',
- 'data': {'balloon_max': 'str', 'balloon_cur': 'str', 'balloon_min': 'str',
- 'balloon_target': 'str'}}
+ 'data': {'*balloon_max': 'str', '*balloon_cur': 'str', '*balloon_min': 'str',
+ '*balloon_target': 'str'}}
##
# @VmDisplayInfo:
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 9740ab3..3c51089 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -410,14 +410,21 @@
balloon_target = dev.get('target', max_mem)
break
else:
- balloon_target = 0
+ balloon_target = None
- stats['balloonInfo'] = {
- 'balloon_max': str(max_mem),
- 'balloon_min': str(
- int(self._vm.conf.get('memGuaranteedSize', '0')) * 1024),
- 'balloon_cur': str(sample) if sample is not None else '0',
- 'balloon_target': str(balloon_target)}
+ stats['balloonInfo'] = {}
+
+ # Do not return any balloon status info before we get all data
+ # MOM will ignore VMs with missing balloon information instead
+ # using incomplete data and computing wrong balloon targets
+ if balloon_target is not None and sample is not None:
+ stats['balloonInfo'].update({
+ 'balloon_max': str(max_mem),
+ 'balloon_min': str(
+ int(self._vm.conf.get('memGuaranteedSize', '0')) * 1024),
+ 'balloon_cur': str(sample),
+ 'balloon_target': str(balloon_target)
+ })
def _getCpuTuneInfo(self, stats):
--
To view, visit http://gerrit.ovirt.org/34887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If44c8e9d65b7221b2dec5fdd1f2d7d4343f7aeaa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
9 years, 6 months
Change in vdsm[master]: jsonrpc: Wrong key name for getDevicesVisibility
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: Wrong key name for getDevicesVisibility
......................................................................
jsonrpc: Wrong key name for getDevicesVisibility
Bug-Url: https://bugzilla.redhat.com/1159637
Change-Id: I63180a87e40e48134e6da8b9996f849362fb5501
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Reviewed-on: http://gerrit.ovirt.org/35014
Reviewed-by: Allon Mureinik <amureini(a)redhat.com>
Tested-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/35014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63180a87e40e48134e6da8b9996f849362fb5501
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 6 months
Change in vdsm[master]: jsonrpc: Wrong key name for getDevicesVisibility
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Wrong key name for getDevicesVisibility
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63180a87e40e48134e6da8b9996f849362fb5501
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
Change in vdsm[master]: jsonrpc: Wrong key name for getDevicesVisibility
by Maor Lipchuk
Maor Lipchuk has posted comments on this change.
Change subject: jsonrpc: Wrong key name for getDevicesVisibility
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63180a87e40e48134e6da8b9996f849362fb5501
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
9 years, 6 months
Change in vdsm[ovirt-3.5]: multipath: add specific fail entry for emc-vnx
by Federico Simoncelli
Federico Simoncelli has uploaded a new change for review.
Change subject: multipath: add specific fail entry for emc-vnx
......................................................................
multipath: add specific fail entry for emc-vnx
As few other storage arrays also the emc-vnx is forcing the
queue_if_no_path option on the multipath device.
This patch adds a specific section for the device maintaining
the emc defaults but forcing to fail the io instead of queuing.
In case of queuing we observed that the processes were blocked
on io and among other things it prevented the storage pool to
be reconstructed.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1098769
Change-Id: Icf5f4c89eac1273bf3a8e1afa300fec7b5b68eae
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/35072
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
(cherry picked from commit 9880fdf9989718a097bb05571a6344e28c2f258b)
---
M vdsm/storage/multipath.py
1 file changed, 20 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/35179/1
diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index 68502ce..34573c2 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -53,8 +53,9 @@
OLD_TAGS = ["# RHAT REVISION 0.2", "# RHEV REVISION 0.3",
"# RHEV REVISION 0.4", "# RHEV REVISION 0.5",
"# RHEV REVISION 0.6", "# RHEV REVISION 0.7",
- "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"]
-MPATH_CONF_TAG = "# RHEV REVISION 1.0"
+ "# RHEV REVISION 0.8", "# RHEV REVISION 0.9",
+ "# RHEV REVISION 1.0"]
+MPATH_CONF_TAG = "# RHEV REVISION 1.1"
MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE"
STRG_MPATH_CONF = (
"\n\n"
@@ -82,6 +83,23 @@
" product \"Compellent Vol\"\n"
" no_path_retry fail\n"
"}\n"
+ "device {\n"
+ " # multipath.conf.default\n"
+ " vendor \"DGC\"\n"
+ " product \".*\"\n"
+ " product_blacklist \"LUNZ\"\n"
+ " path_grouping_policy \"group_by_prio\"\n"
+ " path_checker \"emc_clariion\"\n"
+ " hardware_handler \"1 emc\"\n"
+ " prio \"emc\"\n"
+ " failback immediate\n"
+ " rr_weight \"uniform\"\n"
+ " # vdsm required configuration\n"
+ " getuid_callout \"%(scsi_id_path)s --whitelisted "
+ "--replace-whitespace --device=/dev/%%n\"\n"
+ " features \"0\"\n"
+ " no_path_retry fail\n"
+ "}\n"
"}"
)
MPATH_CONF_TEMPLATE = MPATH_CONF_TAG + STRG_MPATH_CONF
--
To view, visit http://gerrit.ovirt.org/35179
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf5f4c89eac1273bf3a8e1afa300fec7b5b68eae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
9 years, 6 months
Change in vdsm[ovirt-3.5]: vm: state change missing return value
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: vm: state change missing return value
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0737403dcfa0ccd0a3c2813b215b4d5fa958eca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
9 years, 6 months
