Change in vdsm[master]: cleanup: ifcfg configurator static methods and list handling
by asegurap＠redhat.com
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: cleanup: ifcfg configurator static methods and list handling
......................................................................
cleanup: ifcfg configurator static methods and list handling
Change-Id: I83051a07d3b907ba31a01f75e64f01f3f2e7a165
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M vdsm/netconf/ifcfg.py
1 file changed, 26 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/20536/1
diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py
index cf198ef..c0a4144 100644
--- a/vdsm/netconf/ifcfg.py
+++ b/vdsm/netconf/ifcfg.py
@@ -193,7 +193,8 @@
self._setNewMtu(nic, _netinfo.getVlanDevsForIface(nic.name))
ifup(nic.name)
- def _getFilePath(self, fileType, device):
+ @staticmethod
+ def _getFilePath(fileType, device):
return os.path.join(netinfo.NET_CONF_DIR, '%s-%s' % (fileType, device))
def _removeSourceRouteFile(self, fileType, device):
@@ -361,7 +362,8 @@
confFile.write(content)
logging.info('Restored %s', confFilePath)
- def _devType(self, content):
+ @staticmethod
+ def _devType(content):
if re.search('^TYPE=Bridge$', content, re.MULTILINE):
return "Bridge"
elif re.search('^VLAN=yes$', content, re.MULTILINE):
@@ -371,7 +373,8 @@
else:
return "Other"
- def _sortDeviceIfcfgs(self, deviceIfcfgs):
+ @classmethod
+ def _sortDeviceIfcfgs(cls, deviceIfcfgs):
devdict = {'Bridge': [],
'Vlan': [],
'Slave': [],
@@ -380,7 +383,8 @@
if not confFile.startswith(netinfo.NET_CONF_PREF):
continue
try:
- content = file(confFile).read()
+ with open(confFile) as confFileObj:
+ content = confFileObj.read()
except IOError as e:
if e.errno == os.errno.ENOENT:
continue
@@ -388,15 +392,17 @@
raise
dev = confFile[len(netinfo.NET_CONF_PREF):]
- devdict[self._devType(content)].append(dev)
+ devdict[cls._devType(content)].append(dev)
return devdict['Other'] + devdict['Vlan'] + devdict['Bridge']
- def _stopDevices(self, deviceIfcfgs):
+ @staticmethod
+ def _stopDevices(deviceIfcfgs):
for dev in reversed(deviceIfcfgs):
ifdown(dev)
- def _startDevices(self, deviceIfcfgs):
+ @staticmethod
+ def _startDevices(deviceIfcfgs):
for dev in deviceIfcfgs:
try:
ifup(dev)
@@ -504,8 +510,8 @@
return ports
def writeConfFile(self, fileName, configuration):
- '''Backs up the previous contents of the file referenced by fileName
- writes the new configuration and sets the specified access mode.'''
+ """Backs up the previous contents of the file referenced by fileName
+ writes the new configuration and sets the specified access mode."""
self._backup(fileName)
logging.debug('Writing to file %s configuration:\n%s' % (fileName,
configuration))
@@ -533,20 +539,20 @@
pipes.quote(onboot))
cfg += conf
if ipconfig.ipaddr:
- cfg = cfg + 'IPADDR=%s\n' % pipes.quote(ipconfig.ipaddr)
- cfg = cfg + 'NETMASK=%s\n' % pipes.quote(ipconfig.netmask)
+ cfg += 'IPADDR=%s\n' % pipes.quote(ipconfig.ipaddr)
+ cfg += 'NETMASK=%s\n' % pipes.quote(ipconfig.netmask)
if ipconfig.gateway:
- cfg = cfg + 'GATEWAY=%s\n' % pipes.quote(ipconfig.gateway)
+ cfg += 'GATEWAY=%s\n' % pipes.quote(ipconfig.gateway)
# According to manual the BOOTPROTO=none should be set
# for static IP
- cfg = cfg + 'BOOTPROTO=none\n'
+ cfg += 'BOOTPROTO=none\n'
elif ipconfig.bootproto:
- cfg = cfg + 'BOOTPROTO=%s\n' % pipes.quote(ipconfig.bootproto)
+ cfg += 'BOOTPROTO=%s\n' % pipes.quote(ipconfig.bootproto)
if mtu:
- cfg = cfg + 'MTU=%d\n' % mtu
+ cfg += 'MTU=%d\n' % mtu
if ipconfig.defaultRoute:
- cfg = cfg + 'DEFROUTE=%s\n' % ipconfig.defaultRoute
+ cfg += 'DEFROUTE=%s\n' % ipconfig.defaultRoute
cfg += 'NM_CONTROLLED=no\n'
if ipconfig.ipv6addr or ipconfig.ipv6autoconf or ipconfig.dhcpv6:
cfg += 'IPV6INIT=yes\n'
@@ -675,7 +681,8 @@
self._backup(netinfo.NET_CONF_PREF + bridge)
self._removeFile(netinfo.NET_CONF_PREF + bridge)
- def _getConfigValue(self, conffile, entry):
+ @staticmethod
+ def _getConfigValue(conffile, entry):
"""
Get value from network configuration file
@@ -729,13 +736,13 @@
def ifdown(iface):
- "Bring down an interface"
+ """Bring down an interface"""
rc, out, err = utils.execCmd([constants.EXT_IFDOWN, iface], raw=True)
return rc
def ifup(iface, async=False):
- "Bring up an interface"
+ """Bring up an interface"""
def _ifup(netIf):
rc, out, err = utils.execCmd([constants.EXT_IFUP, netIf], raw=False)
--
To view, visit http://gerrit.ovirt.org/20536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83051a07d3b907ba31a01f75e64f01f3f2e7a165
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
10 years, 4 months
Change in vdsm[master]: rwtab: Add /var/run/vdsm
by iheim＠redhat.com
Itamar Heim has posted comments on this change.
Change subject: rwtab: Add /var/run/vdsm
......................................................................
Patch Set 1:
ping?
--
To view, visit http://gerrit.ovirt.org/18829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26d15b38cde216eff378fc4095663732302cc8ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 4 months
Change in vdsm[master]: caps: Collect numa information
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: caps: Collect numa information
......................................................................
Patch Set 4:
(2 comments)
Just a couple of things in the commit message and it is good for me.
http://gerrit.ovirt.org/#/c/23703/4//COMMIT_MSG
Commit Message:
Line 8:
Line 9: This patch modifies the caps module to add function of collect
Line 10: host numa information and report to ovirt engine.
Line 11: It will add a key named numaNodes in the xml rpc response of
Line 12: getCapabilities whose value is the host's numa information.
Add one blank line here for readability, please.
Line 13: An example of the value: 0:0,1:10240:9500;1:2,3:10240:9700
Line 14: The items are separated by semicolon, the fields in each item
Line 15: are separated by colon.
Line 16: Take the first item above to explain the meaning of each field:
Line 14: The items are separated by semicolon, the fields in each item
Line 15: are separated by colon.
Line 16: Take the first item above to explain the meaning of each field:
Line 17: 0 - The index of numa node
Line 18: 0,1 - The index of cpu which belong to this numa node
Thanks, we're almost there. Is this socket_id,core_id?
If so, I'd change the text as something like that
The index of cpu (socket, core) which belong to this numa node.
Line 19: 10240 - The total memory of this numa node
Line 20: 9500 - The free memory of this numa node
Line 21:
Line 22: Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd
--
To view, visit http://gerrit.ovirt.org/23703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
10 years, 4 months
Change in vdsm[master]: hsm: Fix missing MAX_DOMAINS constant
by Nir Soffer
Nir Soffer has uploaded a new change for review.
Change subject: hsm: Fix missing MAX_DOMAINS constant
......................................................................
hsm: Fix missing MAX_DOMAINS constant
Commit ab6014b394 moved MAX_DOMAINS from sp to spbackends without
updating all users, breaking creation of a pool on block storage using
old storage domain format. This patch fix the error by importing the
name from its new module.
Change-Id: I772b01be4de309aa4b15bf2c89e69b64787e1a11
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/24242/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 53c9dd0..5efa4ec 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -40,7 +40,7 @@
from vdsm.config import config
import sp
-from spbackends import MAX_POOL_DESCRIPTION_SIZE
+from spbackends import MAX_POOL_DESCRIPTION_SIZE, MAX_DOMAINS
from spbackends import StoragePoolDiskBackend
from spbackends import StoragePoolMemoryBackend
import domainMonitor
@@ -948,7 +948,7 @@
msdVersion = msd.getVersion()
if (msdType in sd.BLOCK_DOMAIN_TYPES and
msdVersion in blockSD.VERS_METADATA_LV and
- len(domList) > sp.MAX_DOMAINS):
+ len(domList) > MAX_DOMAINS):
raise se.TooManyDomainsInStoragePoolError()
for sdUUID in domList:
--
To view, visit http://gerrit.ovirt.org/24242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I772b01be4de309aa4b15bf2c89e69b64787e1a11
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
10 years, 4 months
Change in vdsm[master]: caps: Collect numa information
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Collect numa information
......................................................................
Patch Set 4:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6272/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7162/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7051/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
--
To view, visit http://gerrit.ovirt.org/23703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 4 months
Change in vdsm[master]: netinfo: Make a test run under RHEL 6.5
by osvoboda＠redhat.com
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: Make a test run under RHEL 6.5
......................................................................
netinfo: Make a test run under RHEL 6.5
dhclient still resides in /sbin/dhclient.
dnsmasq does not accept the --bind-dynamic option.
For testing purposes, --bind-interfaces is enough
although it generates a warning:
LOUD WARNING: listening on 240.0.0.1 may accept requests via interfaces other than veth_23
LOUD WARNING: use --bind-dynamic rather than --bind-interfaces to avoid DNS amplification attacks via these interface(s)
Change-Id: Iee3e9e49e8392e08743706f5857a3325a4024bb4
Bug-Url: https://bugzilla.redhat.com/987813
Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com>
---
M tests/functional/dhcp.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/24201/1
diff --git a/tests/functional/dhcp.py b/tests/functional/dhcp.py
index fe1b079..8798c6b 100644
--- a/tests/functional/dhcp.py
+++ b/tests/functional/dhcp.py
@@ -26,7 +26,8 @@
from time import sleep
_DNSMASQ_BINARY = CommandPath('dnsmasq', '/usr/sbin/dnsmasq')
-_DHCLIENT_BINARY = CommandPath('dhclient', '/usr/sbin/dhclient')
+_DHCLIENT_BINARY = CommandPath('dhclient', '/usr/sbin/dhclient',
+ '/sbin/dhclient')
_NM_CLI_BINARY = CommandPath('nmcli', '/usr/bin/nmcli')
_START_CHECK_TIMEOUT = 0.5
_DHCLIENT_TIMEOUT = 10
@@ -48,7 +49,7 @@
'-p', '0', '--dhcp-range=' + dhcpRangeFrom + ',' +
dhcpRangeTo + ',2m', '--dhcp-option=3', '-k',
'-i', interface, '-I', 'lo', '-d',
- '--bind-dynamic'], sync=False)
+ '--bind-interfaces'], sync=False)
sleep(_START_CHECK_TIMEOUT)
if self.proc.returncode:
raise DhcpError('Failed to start dnsmasq DHCP server.' +
--
To view, visit http://gerrit.ovirt.org/24201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee3e9e49e8392e08743706f5857a3325a4024bb4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
10 years, 4 months
Change in vdsm[master]: netinfo: Do not mix local and universal time, improve tests
by osvoboda＠redhat.com
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: Do not mix local and universal time, improve tests
......................................................................
netinfo: Do not mix local and universal time, improve tests
Also go back to using dhclient's --bind-interfaces option
to stay compatible with RHEL 6.
Change-Id: I1b2a33209b45001c427d5712d57326394cbeb9d0
Bug-Url: https://bugzilla.redhat.com/987813
Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com>
---
M lib/vdsm/netinfo.py
M tests/functional/dhcp.py
M tests/functional/networkTests.py
M tests/netinfoTests.py
4 files changed, 37 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/24192/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 98e2462..dbacb2f 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -557,7 +557,7 @@
if expiryTime.startswith(EPOCH):
since_epoch = expiryTime[len(EPOCH):]
- return datetime.fromtimestamp(float(since_epoch))
+ return datetime.utcfromtimestamp(float(since_epoch))
else:
return datetime.strptime(expiryTime, '%w %Y/%m/%d %H:%M:%S')
@@ -583,7 +583,7 @@
continue # the line should always contain a ;
expiryTime = _parseExpiryTime(line[len(EXPIRE):end])
- if datetime.now() > expiryTime:
+ if datetime.utcnow() > expiryTime:
insideLease = False
continue
diff --git a/tests/functional/dhcp.py b/tests/functional/dhcp.py
index 717b80a..3bd200a 100644
--- a/tests/functional/dhcp.py
+++ b/tests/functional/dhcp.py
@@ -26,7 +26,8 @@
from time import sleep
_DNSMASQ_BINARY = CommandPath('dnsmasq', '/usr/sbin/dnsmasq')
-_DHCLIENT_BINARY = CommandPath('dhclient', '/usr/sbin/dhclient')
+_DHCLIENT_BINARY = CommandPath('dhclient', '/usr/sbin/dhclient',
+ '/sbin/dhclient')
_NM_CLI_BINARY = CommandPath('nmcli', '/usr/bin/nmcli')
_START_CHECK_TIMEOUT = 0.5
_DHCLIENT_TIMEOUT = 10
@@ -48,7 +49,7 @@
'-p', '0', '--dhcp-range=' + dhcpRangeFrom + ',' +
dhcpRangeTo + ',2m', '--dhcp-option=3', '-k',
'-i', interface, '-I', 'lo', '-d',
- '--bind-dynamic'], sync=False)
+ '--bind-interfaces'], sync=False)
sleep(_START_CHECK_TIMEOUT)
if self.proc.returncode:
raise DhcpError('Failed to start dnsmasq DHCP server.' +
@@ -59,11 +60,11 @@
logging.debug(''.join(self.proc.stderr))
-def runDhclient(interface, leaseFile, pidFile):
+def runDhclient(interface, confFile, leaseFile, pidFile):
"""Starts dhclient and hands the process over after a while."""
rc, out, err = execCmd([_DHCLIENT_BINARY.cmd, '-d', '-lf', leaseFile,
'-pf', pidFile, '-timeout', str(_DHCLIENT_TIMEOUT),
- '-1', interface])
+ '-1', '-cf', confFile, interface])
if rc: # == 2
logging.debug(''.join(err))
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 5484e99..d493192 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1686,10 +1686,11 @@
self.assertEqual(status, SUCCESS, msg)
self.assertNetworkDoesntExist(NETWORK_NAME)
+ @permutations([['default'], ['local']])
@cleanupNet
@RequireVethMod
@ValidateRunningAsRoot
- def testDhclientLeases(self):
+ def testDhclientLeases(self, dateFormat=False):
dhcp4 = set()
with vethIf() as (server, client):
with avoidAnotherDhclient(client):
@@ -1700,10 +1701,14 @@
with dnsmasqDhcp(server):
with namedTemporaryDir(dir='/var/lib/dhclient') as tmpDir:
+ confFile = os.path.join(tmpDir, 'test.conf')
leaseFile = os.path.join(tmpDir, 'test.lease')
pidFile = os.path.join(tmpDir, 'test.pid')
- dhcp.runDhclient(client, leaseFile, pidFile)
+ with open(confFile, 'w') as f:
+ f.write('db-time-format {0};'.format(dateFormat))
+
+ dhcp.runDhclient(client, confFile, leaseFile, pidFile)
dhcp4 = getDhclientIfaces([leaseFile])
self.assertIn(client, dhcp4, 'Test iface not found in a lease file.')
diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py
index cfdf107..4ad79dc 100644
--- a/tests/netinfoTests.py
+++ b/tests/netinfoTests.py
@@ -19,9 +19,11 @@
# Refer to the README and COPYING files for full details of the license
#
import os
+from datetime import datetime
from functools import partial
from shutil import rmtree
import tempfile
+import time
from xml.dom import minidom
import ethtool
@@ -295,28 +297,36 @@
def testGetDhclientIfaces(self):
LEASES = (
- 'lease {\n'
+ 'lease {{\n'
' interface "valid";\n'
- ' expire 3 2037/01/29 18:25:46;\n'
- '}\n'
- 'lease {\n'
+ ' expire {0:%w %Y/%m/%d %H:%M:%S};\n'
+ '}}\n'
+ 'lease {{\n'
' interface "valid2";\n'
- ' expire epoch 2117041460; # Sat Jan 31 20:04:20 2037\n'
- '}\n'
- 'lease {\n'
+ ' expire epoch {1:.0f};\n'
+ '}}\n'
+ 'lease {{\n'
' interface "expired";\n'
- ' expire 3 2014/01/29 18:25:46;\n'
- '}\n'
- 'lease {\n'
+ ' expire {2:%w %Y/%m/%d %H:%M:%S};\n'
+ '}}\n'
+ 'lease {{\n'
' interface "expired2";\n'
- ' expire epoch 1391195060; # Fri Jan 31 20:04:20 2014\n'
- '}\n'
+ ' expire epoch {3:.0f};\n'
+ '}}\n'
)
with namedTemporaryDir() as tmpDir:
leaseFile = os.path.join(tmpDir, 'test.lease')
with open(leaseFile, 'w') as f:
- f.write(LEASES)
+ lastMinute = time.time() - 60
+ nextMinute = time.time() + 60
+
+ f.write(LEASES.format(
+ datetime.utcfromtimestamp(nextMinute),
+ nextMinute,
+ datetime.utcfromtimestamp(lastMinute),
+ lastMinute
+ ))
dhcp4 = getDhclientIfaces([leaseFile])
--
To view, visit http://gerrit.ovirt.org/24192
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b2a33209b45001c427d5712d57326394cbeb9d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
10 years, 4 months
Change in vdsm[master]: New before_device_create/before_nic_hotplug hook: privatevlan
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: New before_device_create/before_nic_hotplug hook: privatevlan
......................................................................
Patch Set 5:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6271/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7161/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7050/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/336/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
--
To view, visit http://gerrit.ovirt.org/24195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idda6f193c0095241bc1540a0241d49426c000fb3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michael Samuel <mik(a)miknet.net>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michael Samuel <mik(a)miknet.net>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 4 months
Change in vdsm[master]: New before_device_create/before_nic_hotplug hook: privatevlan
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: New before_device_create/before_nic_hotplug hook: privatevlan
......................................................................
Patch Set 4:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6270/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7160/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7049/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/335/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
--
To view, visit http://gerrit.ovirt.org/24195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idda6f193c0095241bc1540a0241d49426c000fb3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michael Samuel <mik(a)miknet.net>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michael Samuel <mik(a)miknet.net>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 4 months
Change in vdsm[master]: New before_device_create/before_nic_hotplug hook: privatevlan
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: New before_device_create/before_nic_hotplug hook: privatevlan
......................................................................
Patch Set 3:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6269/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7159/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7048/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/334/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org.
--
To view, visit http://gerrit.ovirt.org/24195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idda6f193c0095241bc1540a0241d49426c000fb3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michael Samuel <mik(a)miknet.net>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 4 months
