Change in vdsm[master]: vm.py: Fix unsupported HPET option in ppc64
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm.py: Fix unsupported HPET option in ppc64
......................................................................
vm.py: Fix unsupported HPET option in ppc64
This patch does not allow disabling HPET in ppc64, since the -no-hpet
option is missing in the ppc64 QEMU.
Change-Id: I6df40fad6c6d70e5006a0b3bf2ca3660f8c75404
Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Reviewed-on: http://gerrit.ovirt.org/24332
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
---
M tests/vmTestsData.py
M vdsm/vm.py
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Vitor de Lima: Verified
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/24332
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6df40fad6c6d70e5006a0b3bf2ca3660f8c75404
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in vdsm[master]: tests: add initial tests for timeOffset handling
by fromani＠redhat.com
Francesco Romani has uploaded a new change for review.
Change subject: tests: add initial tests for timeOffset handling
......................................................................
tests: add initial tests for timeOffset handling
the handling of timeOffset has been a source of issues
recently and deserves more testing.
Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M tests/vmTests.py
1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/24252/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 1e0a3f6..30c6745 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -24,7 +24,9 @@
import vm
from vdsm import constants
+from vdsm import define
from testrunner import VdsmTestCase as TestCaseBase
+from testrunner import permutations, expandPermutations
import caps
from vdsm import utils
from vdsm import libvirtconnection
@@ -629,3 +631,30 @@
lambda: "fc25cbbe-5520-4f83-b82e-1541914753d9")
def testBuildCmdLinePPC64(self):
self.assertBuildCmdLine(CONF_TO_DOMXML_PPC64)
+
+
+@expandPermutations
+class TestVmOperations(TestCaseBase):
+ BASE_OFFSET = 42
+ UPDATE_OFFSET = 3200 # just a number, no particular meaning
+
+ @MonkeyPatch(constants, 'P_VDSM_RUN', '/tmp/')
+ @MonkeyPatch(libvirtconnection, 'get', lambda x: ConnectionMock())
+ @permutations([[define.NORMAL], [define.ERROR]])
+ def testTimeOffsetRoundtrip(self, exitCode):
+ fake = vm.Vm(None, {'vmId': 'TESTING1',
+ 'timeOffset': self.BASE_OFFSET})
+ fake.setDownStatus(exitCode, "testing")
+ assert fake.getStats()['timeOffset'] == self.BASE_OFFSET
+
+ @MonkeyPatch(constants, 'P_VDSM_RUN', '/tmp/')
+ @MonkeyPatch(libvirtconnection, 'get', lambda x: ConnectionMock())
+ @permutations([[define.NORMAL], [define.ERROR]])
+ def testTimeOffsetUpdate(self, exitCode):
+ # bz956741
+ fake = vm.Vm(None, {'vmId': 'TESTING1',
+ 'timeOffset': self.BASE_OFFSET})
+ fake._rtcUpdate(self.UPDATE_OFFSET)
+ fake.setDownStatus(exitCode, "testing")
+ assert fake.getStats()['timeOffset'] == str(
+ self.BASE_OFFSET + self.UPDATE_OFFSET)
--
To view, visit http://gerrit.ovirt.org/24252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8925945686e6dd3a6a83a87e26157aba12ec1bd3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
10 years, 4 months
Change in vdsm[master]: API: setHaMaintenanceMode command
by gpadgett＠redhat.com
Greg Padgett has uploaded a new change for review.
Change subject: API: setHaMaintenanceMode command
......................................................................
API: setHaMaintenanceMode command
New API for setting hosted engine maintenance mode.
Change-Id: Ic08c5edb0e9b8cc11eb70ef6a66301335c42aad3
Bug-Url: https://bugzilla.redhat.com/1053040
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M lib/vdsm/define.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm_api/vdsmapi-schema.json
4 files changed, 61 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/23264/1
diff --git a/lib/vdsm/define.py b/lib/vdsm/define.py
index 5cd9b99..abf6437 100644
--- a/lib/vdsm/define.py
+++ b/lib/vdsm/define.py
@@ -135,6 +135,9 @@
'setNumberOfCpusErr': {'status': {
'code': 60,
'message': 'Failed to set the number of cpus'}},
+ 'haErr': {'status': {
+ 'code': 61,
+ 'message': 'Failed to set Hosted Engine HA policy'}},
'recovery': {'status': {
'code': 99,
'message': 'Recovering from crash or Initializing'}},
diff --git a/vdsm/API.py b/vdsm/API.py
index bb589c9..b918c27 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1484,6 +1484,30 @@
except:
return errCode['momErr']
+ def setHaMaintenanceMode(self, mode, enabled):
+ """
+ Sets Hosted Engine HA maintenance mode ('global' or 'local') to
+ enabled (True) or disabled (False).
+ """
+ if not haClient:
+ return errCode['unavail']
+
+ self.log.info("Setting Hosted Engine HA {0} maintenance to {1}"
+ .format(mode.lower(), enabled))
+ if mode.lower() == 'global':
+ mm = haClient.HAClient.MaintenanceMode.GLOBAL
+ elif mode.lower() == 'local':
+ mm = haClient.HAClient.MaintenanceMode.LOCAL
+ else:
+ return errCode['haErr']
+
+ try:
+ haClient.HAClient().setMaintenance(mm, enabled)
+ except:
+ self.log.exception("error setting HA maintenance mode")
+ return errCode['haErr']
+ return {'status': doneCode}
+
# take a rough estimate on how much free mem is available for new vm
# memTotal = memFree + memCached + mem_used_by_non_qemu + resident .
# simply returning (memFree + memCached) is not good enough, as the
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index d0987e5..54cae06 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -427,6 +427,10 @@
api = API.Global()
return api.setMOMPolicyParameters(key_value_store)
+ def setHaMaintenanceMode(self, mode, enabled):
+ api = API.Global()
+ return api.setHaMaintenanceMode(mode, enabled)
+
def domainActivate(self, sdUUID, spUUID, options=None):
domain = API.StorageDomain(sdUUID)
return domain.activate(spUUID)
@@ -846,6 +850,7 @@
(self.setLogLevel, 'setLogLevel'),
(self.setMOMPolicy, 'setMOMPolicy'),
(self.setMOMPolicyParameters, 'setMOMPolicyParameters'),
+ (self.setHaMaintenanceMode, 'setHaMaintenanceMode'),
(self.vmHotplugDisk, 'hotplugDisk'),
(self.vmHotunplugDisk, 'hotunplugDisk'),
(self.vmHotplugNic, 'hotplugNic'),
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index cfe13e2..732c4da 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -460,6 +460,35 @@
'data': {'key_value_store': 'dict'}}
##
+# @HaMaintenanceMode:
+#
+# An enumeration of recognized Hosted Engine maintenance modes.
+#
+# @GLOBAL: Suspend Hosted Engine agent actions on all hosts
+#
+# @LOCAL: Suspend Hosted Engine agent on this host, after migrating
+# engine VM, if necessary.
+#
+# Since: 4.14.0
+##
+{'enum': 'HaMaintenanceMode',
+ 'data': ['GLOBAL', 'LOCAL']}
+
+##
+# @Host.setHaMaintenanceMode:
+#
+# Configure maintenance for Hosted Engine subsystem.
+#
+# @mode: Type of maintenance to configure
+#
+# @enabled: Whether to enable or disable maintenance
+#
+# Since: 4.14.0
+##
+{'command': {'class': 'Host', 'name': 'setHaMaintenanceMode'},
+ 'data': {'mode': 'HaMaintenanceMode', 'enabled': 'bool'}}
+
+##
# @TaskDetails:
#
# A collection of information about a task.
--
To view, visit http://gerrit.ovirt.org/23264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic08c5edb0e9b8cc11eb70ef6a66301335c42aad3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
10 years, 4 months
Change in vdsm[master]: API: return additional Hosted Engine information from vdsStats
by gpadgett＠redhat.com
Greg Padgett has uploaded a new change for review.
Change subject: API: return additional Hosted Engine information from vdsStats
......................................................................
API: return additional Hosted Engine information from vdsStats
Return additional hosted engine runtime information with vds statistics
which allows for better interoperability between the engine and hosted
engine agent.
Change-Id: Iaee2756d0652dc56439b8004e9260fcea927b708
Bug-Url: https://bugzilla.redhat.com/1053040
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M vdsm/API.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 54 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/23263/1
diff --git a/vdsm/API.py b/vdsm/API.py
index bb76f20..bb589c9 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1235,12 +1235,7 @@
stats['netConfigDirty'] = str(self._cif._netConfigDirty)
stats['generationID'] = self._cif._generationID
-
- if haClient:
- try:
- stats['haScore'] = haClient.HAClient().get_local_host_score()
- except Exception:
- self.log.exception("failed to retrieve Hosted Engine HA score")
+ stats['haStats'] = self._getHAInfo()
return {'status': doneCode, 'info': stats}
@@ -1554,6 +1549,38 @@
self.log.error(vmId + ': Lost connection to VM')
return count, active, migrating
+ def _getHAInfo(self):
+ """
+ Return Hosted Engine HA information for this host.
+ """
+ i = {
+ 'configured': False,
+ 'active': False,
+ 'score': 0,
+ 'globalMaintenance': False,
+ 'localMaintenance': False,
+ }
+ if haClient:
+ # TODO more robust check for configuration? The hosted engine
+ # packages may be installed but not set up.
+ i['configured'] = True
+ try:
+ stats = haClient.HAClient().get_all_stats()
+ if 0 in stats:
+ i['globalMaintenance'] = stats[0].get(
+ haClient.HAClient.GlobalMdFlags.MAINTENANCE, False)
+
+ host_id = haClient.HAClient.get_local_host_id()
+ if host_id in stats:
+ i['active'] = stats[host_id]['live-data']
+ i['score'] = stats[host_id]['score']
+ i['localMaintenance'] = stats[host_id]['maintenance']
+ except Exception:
+ self.log.exception("failed to retrieve Hosted Engine HA info")
+ else:
+ self.log.debug("Hosted Engine HA is not installed")
+ return i
+
@staticmethod
def translateNetOptionsToNew(options):
_translationMap = {
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 564180a..cfe13e2 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -1540,6 +1540,24 @@
##
{'enum': 'MOMStatus', 'data': ['disabled', 'active', 'inactive']}
+##
+# @HostedEngineStatus:
+#
+# Hosted Engine subsystem status, according to each host.
+#
+# @active: Indicates if the HA agent is alive and updating data
+#
+# @localMaintenance: Indicates if host is in local HA maintenance mode
+#
+# @globalMaintenance: Indicates if cluster is in global maintenance mode
+#
+# @score: Numeric host score
+#
+# Since: 4.14.0
+##
+{'type': 'HostedEngineStatus',
+ 'data': {'active': 'bool', 'globalMaintenance': 'bool',
+ 'localMaintenance': 'bool', 'score': 'uint'}}
##
# @HostStats:
@@ -1616,8 +1634,8 @@
#
# @momStatus: The current status of the MOM policy engine
#
-# @haScore: #optional The host score according to the HA agent,
-# if installed (new in version 4.13.0)
+# @haStatus: The current status of the Hosted Engine HA system
+# (new in version 4.14.0)
#
# Since: 4.10.0
##
@@ -1636,7 +1654,7 @@
'vmCount': 'int', 'vmActive': 'int', 'vmMigrating': 'int',
'dateTime': 'str', 'ksmState': 'bool', 'ksmPages': 'int',
'ksmCpu': 'float', 'netConfigDirty': 'bool', 'generationID': 'UUID',
- 'momStatus': 'MOMStatus', '*haScore': 'uint'}}
+ 'momStatus': 'MOMStatus', 'haStatus': 'HostedEngineStatus'}}
##
# @Host.getStats:
--
To view, visit http://gerrit.ovirt.org/23263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaee2756d0652dc56439b8004e9260fcea927b708
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
10 years, 4 months
Change in vdsm[master]: vmDevices: add __slots__ to devices
by mpoledni＠redhat.com
Martin Polednik has uploaded a new change for review.
Change subject: vmDevices: add __slots__ to devices
......................................................................
vmDevices: add __slots__ to devices
VDSM devices are created using setattr over **kwargs, making the
initialization implicit. Implementing __slots__ does define which
attributes does the device accept and also improves memory footprint.
Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a
Signed-off-by: Martin Polednik <mpoledni(a)redhat.com>
---
M vdsm/vm.py
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/21036/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 796735f..7e4483f 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1166,7 +1166,10 @@
class VmDevice(object):
+ __slots__ = ['deviceType', 'device', 'alias', 'specParams', 'deviceId']
+
def __init__(self, conf, log, **kwargs):
+ self.specParams = {}
for attr, value in kwargs.iteritems():
try:
setattr(self, attr, value)
@@ -1215,6 +1218,7 @@
class ControllerDevice(VmDevice):
+ __slots__ = ['model', 'address']
def getXML(self):
"""
@@ -1229,6 +1233,7 @@
class VideoDevice(VmDevice):
+ __slots__ = ['address']
def getXML(self):
"""
@@ -1245,6 +1250,7 @@
class SoundDevice(VmDevice):
+ __slots__ = ['address', 'alias']
def getXML(self):
"""
@@ -1256,6 +1262,8 @@
class NetworkInterfaceDevice(VmDevice):
+ __slots__ = ['nicModel', 'macAddr', 'network', 'bootOrder', 'address',
+ 'linkActive', 'spotMirroring', 'custom']
def __init__(self, conf, log, **kwargs):
# pyLint can't tell that the Device.__init__() will
@@ -1348,6 +1356,11 @@
class Drive(VmDevice):
+ __slots__ = ['iface', 'path', 'readonly', 'bootOrder', 'domainID',
+ 'poolID', 'imageID', 'UUID', 'volumeID', 'format',
+ 'propagateErrors', 'address', 'apparentsize',
+ 'index', 'name', 'optional', 'shared', 'truesize',
+ 'volumeChain', 'baseVolumeID']
VOLWM_CHUNK_MB = config.getint('irs', 'volume_utilization_chunk_mb')
VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent')
VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during replication
@@ -1646,6 +1659,7 @@
class BalloonDevice(VmDevice):
+ __slots__ = ['address']
def getXML(self):
"""
@@ -1662,6 +1676,8 @@
class WatchdogDevice(VmDevice):
+ __slots__ = ['address']
+
def __init__(self, *args, **kwargs):
super(WatchdogDevice, self).__init__(*args, **kwargs)
@@ -1684,6 +1700,8 @@
class SmartCardDevice(VmDevice):
+ __slots__ = ['address']
+
def getXML(self):
"""
Add smartcard section to domain xml
@@ -1701,6 +1719,8 @@
class RedirDevice(VmDevice):
+ __slots__ = ['address']
+
def getXML(self):
"""
Create domxml for a redir device.
@@ -1713,6 +1733,8 @@
class ConsoleDevice(VmDevice):
+ __slots__ = []
+
def getXML(self):
"""
Create domxml for a console device.
--
To view, visit http://gerrit.ovirt.org/21036
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e8dadabdd02d3b44606f215c4bc7b7e306a591a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
10 years, 4 months
Re: [oVirt Jenkins] vdsm_unit_tests - Build # 2773 - Failure!
by Dan Kenigsberg
On Tue, Feb 11, 2014 at 05:24:57PM +0000, Jenkins ci oVirt Server wrote:
> Project: http://jenkins.ovirt.org/job/vdsm_unit_tests/
> Build: http://jenkins.ovirt.org/job/vdsm_unit_tests/2773/
> Build Number: 2773
> Build Status: Failure
> Triggered By: Started by an SCM change
>
> -------------------------------------
> Changes Since Last Success:
> -------------------------------------
> Changes for Build #2773
> [Dan Kenigsberg] fencing: stop using a deprecated command
>
>
>
>
> -----------------
> Failed Tests:
> -----------------
> 1 tests failed.
> REGRESSION: miscTests.WatchCmd.testLeakFd
>
> Error Message:
> 79 != 80
> -------------------- >> begin captured logging << --------------------
> root: DEBUG: 'echo "Real stupidity beats artificial intelligence every time."' (cwd None)
> root: DEBUG: SUCCESS: <err> = []; <rc> = 0
> --------------------- >> end captured logging << ---------------------
>
> Stack Trace:
> File "/usr/lib64/python2.6/unittest.py", line 278, in run
> testMethod()
> File "/home/jenkins/workspace/vdsm_unit_tests/tests/miscTests.py", line 988, in testLeakFd
> self.assertEquals(openFdNum(), openFds)
> File "/usr/lib64/python2.6/unittest.py", line 349, in failUnlessEqual
> (msg or '%r != %r' % (first, second))
> 79 != 80
> -------------------- >> begin captured logging << --------------------
> root: DEBUG: 'echo "Real stupidity beats artificial intelligence every time."' (cwd None)
> root: DEBUG: SUCCESS: <err> = []; <rc> = 0
> --------------------- >> end captured logging << ---------------------
this is certainly unrelated to my string change; any idea what it *is*
related to?
10 years, 4 months
Change in vdsm[master]: fencing: stop using a deprecated command
by Dan Kenigsberg
Dan Kenigsberg has uploaded a new change for review.
Change subject: fencing: stop using a deprecated command
......................................................................
fencing: stop using a deprecated command
Recently, fence-agents stopped supporting the "option" alias for its
"action" STDIN command.
https://lists.fedorahosted.org/pipermail/cluster-commits/2013-February/00...
Let us conform to the new option name. The "action" name has been long
supported by el6 and f19's fence-agents, so it can be safely used.
Thanks to John Taylor for reporting the issue.
Bug-Url: https://bugzilla.redhat.com/1063472
Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/API.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/24303/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 36b2095..a2c9616 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1130,7 +1130,7 @@
script = constants.EXT_FENCE_PREFIX + agent
- inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\noption=%s\n'
+ inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\naction=%s\n'
'passwd=%s\n') % (agent, addr, username, action, password)
if port != '':
inp += 'port=%s\n' % (port,)
--
To view, visit http://gerrit.ovirt.org/24303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
10 years, 4 months
Change in vdsm[master]: vm.py: Fix unsupported HPET option in ppc64
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: vm.py: Fix unsupported HPET option in ppc64
......................................................................
Patch Set 1: Code-Review+1
Sorry about this. I'll make sure PPC64 is on my check list for the coming changes.
--
To view, visit http://gerrit.ovirt.org/24332
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df40fad6c6d70e5006a0b3bf2ca3660f8c75404
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 4 months
Change in vdsm[master]: vm.py: Fix unsupported HPET option in ppc64
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: vm.py: Fix unsupported HPET option in ppc64
......................................................................
Patch Set 1: Code-Review+2
Sorry about that!
--
To view, visit http://gerrit.ovirt.org/24332
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df40fad6c6d70e5006a0b3bf2ca3660f8c75404
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years, 4 months
