vdsm-patches February 2014

vdsm-patches@lists.fedorahosted.org

42 participants
527 discussions

Change in vdsm[ovirt-3.4]: fencing: stop using a deprecated command
by Dan Kenigsberg 16 Feb '14

16 Feb '14

Hello Douglas Schilling Landgraf, Eli Mesika, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/24343 to review the following change. Change subject: fencing: stop using a deprecated command ...................................................................... fencing: stop using a deprecated command Recently, fence-agents stopped supporting the "option" alias for its "action" STDIN command. https://lists.fedorahosted.org/pipermail/cluster-commits/2013-February/0030… Let us conform to the new option name. The "action" name has been long supported by el6 and f19's fence-agents, so it can be safely used. Thanks to John Taylor for reporting the issue. Bug-Url: https://bugzilla.redhat.com/1063472 Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/24303 Reviewed-by: Eli Mesika <emesika(a)redhat.com> Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M vdsm/API.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/24343/1 diff --git a/vdsm/API.py b/vdsm/API.py index 8c5b9cb..7cff71b 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -1142,7 +1142,7 @@ return errCode['fenceAgent'] raise - inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\noption=%s\n' + inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\naction=%s\n' 'passwd=%s\n') % (agent, addr, username, action, password) if port != '': inp += 'port=%s\n' % (port,) -- To view, visit http://gerrit.ovirt.org/24343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

3 5

Change in vdsm[ovirt-3.4]: clientIF: Teardown volume path only for VDSM images
by sgotliv＠redhat.com 16 Feb '14

16 Feb '14

Hello Ayal Baron, Nir Soffer, Allon Mureinik, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/24467 to review the following change. Change subject: clientIF: Teardown volume path only for VDSM images ...................................................................... clientIF: Teardown volume path only for VDSM images Trying to tear down a cdrom or external lun throws an exception which creates a lot of log printings. Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c Bug-Url: https://bugzilla.redhat.com/980054 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/21973 Reviewed-by: Nir Soffer <nsoffer(a)redhat.com> Reviewed-by: Ayal Baron <abaron(a)redhat.com> Reviewed-by: Allon Mureinik <amureini(a)redhat.com> --- M vdsm/clientIF.py 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/24467/1 diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index 67dacab..1d3b0a4 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -323,9 +323,10 @@ def teardownVolumePath(self, drive): res = {'status': doneCode} try: - res = self.irs.teardownImage(drive['domainID'], - drive['poolID'], drive['imageID']) - except (KeyError, TypeError): + if vm.isVdsmImage(drive): + res = self.irs.teardownImage(drive['domainID'], + drive['poolID'], drive['imageID']) + except TypeError: # paths (strings) are not deactivated if not isinstance(drive, basestring): self.log.warning("Drive is not a vdsm image: %s", -- To view, visit http://gerrit.ovirt.org/24467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>

4 5

Change in vdsm[master]: vm: Update LUN size when starting a vm
by derez＠redhat.com 16 Feb '14

16 Feb '14

Daniel Erez has uploaded a new change for review. Change subject: vm: Update LUN size when starting a vm ...................................................................... vm: Update LUN size when starting a vm In order to handle resize of DirectLUN disks (i.e. when a LUN volume is extended by user), relevant data should be retrieved when invoking getVmStats. Hence, added the following information to disks stats for DirectLUN disks: truesize, apparentsize and lunGUID (the sizes values already exist but are zeroed). Using these values, the engine could keep the DB updated. The following changes are introduced: * hsm: appropriateDevice method now fetches LUN's device size using 'multipath -> getDeviceSize'. * clientIF: For LUN devices, updated drive's truesize/apparentsize using hsm's getVolumeSize method. * vm: _getDiskStats -> in order to identify each LUN (e.g. on engine side), added 'lunGUID' to dStats when vmDrive.GUID exists (applicable for DirectLUN disks). Change-Id: Ia4988212f7f96078e774d2a4e7b5cd1681383cb0 Bug-Url: https://bugzilla.redhat.com/1026868 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M vdsm/clientIF.py M vdsm/storage/hsm.py M vdsm/vm.py 3 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/24235/1 diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index 894a5d7..d0095e4 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -263,6 +263,10 @@ if res['status']['code']: raise vm.VolumeError(drive) + # Update size for LUN volume + drive["truesize"] = res['truesize'] + drive["apparentsize"] = res['apparentsize'] + volPath = os.path.join("/dev/mapper", drive["GUID"]) # UUID drive format diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 53c9dd0..15485e2 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3107,6 +3107,11 @@ expectedException=OSError, timeout=QEMU_READABLE_TIMEOUT) + # Get the size of the logical unit volume. + size = str(multipath.getDeviceSize(devicemapper.getDmId(guid))) + + return dict(truesize=size, apparentsize=size) + @public def inappropriateDevices(self, thiefId): """ diff --git a/vdsm/vm.py b/vdsm/vm.py index aae8bd6..295814e 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -631,6 +631,8 @@ 'apparentsize': str(vmDrive.apparentsize)} if isVdsmImage(vmDrive): dStats['imageID'] = vmDrive.imageID + else: + dStats['lunGUID'] = vmDrive.GUID dStats['readRate'] = ((eInfo[dName][1] - sInfo[dName][1]) / sampleInterval) dStats['writeRate'] = ((eInfo[dName][3] - sInfo[dName][3]) / -- To view, visit http://gerrit.ovirt.org/24235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia4988212f7f96078e774d2a4e7b5cd1681383cb0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com>

6 10

Change in vdsm[ovirt-3.3]: vm iface statistics: never report negative rates
by Dan Kenigsberg 16 Feb '14

16 Feb '14

Hello Yaniv Bronhaim, Ondřej Svoboda, Antoni Segura Puimedon, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/24322 to review the following change. Change subject: vm iface statistics: never report negative rates ...................................................................... vm iface statistics: never report negative rates When Linux tx/rx couters overflow their 32 bit limit, they wrap back to zero. This causes our reported rxRate/txRate to become negative for one nample. 51073875161d9b932b7 Bug-Url: https://bugzilla.redhat.com/1062166 Change-Id: I40daeb12172a7f54f135b3018405ef228983fa93 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/23598 Tested-by: Ondřej Svoboda <osvoboda(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/24152 Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com> Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M vdsm/vm.py 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/24322/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index bb35f0e..3534699 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -616,10 +616,12 @@ ifStats['txDropped'] = str(eInfo[nic.name][7]) ifRxBytes = (100.0 * - (eInfo[nic.name][0] - sInfo[nic.name][0]) / + (eInfo[nic.name][0] - sInfo[nic.name][0]) % + 2 ** 32 / sampleInterval / ifSpeed / self.MBPS_TO_BPS) ifTxBytes = (100.0 * - (eInfo[nic.name][4] - sInfo[nic.name][4]) / + (eInfo[nic.name][4] - sInfo[nic.name][4]) % + 2 ** 32 / sampleInterval / ifSpeed / self.MBPS_TO_BPS) ifStats['rxRate'] = '%.1f' % ifRxBytes -- To view, visit http://gerrit.ovirt.org/24322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I40daeb12172a7f54f135b3018405ef228983fa93 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

2 9

Change in vdsm[master]: [RFC] storage: Configure multipath using local interfaces
by apahim＠redhat.com 15 Feb '14

15 Feb '14

Amador Pahim has uploaded a new change for review. Change subject: [RFC] storage: Configure multipath using local interfaces ...................................................................... [RFC] storage: Configure multipath using local interfaces Currently is not possible to achieve multipath using one target IP and two or more local interfaces. iscsiadm is always executed with default interface. This patch takes advantage of pre-existent irs iscsi_default_ifaces configuration key to inform to vdsm the interfaces to be used creating paths to the target. This is the initial patch, hoping for comments and concerns. For now, let me keep some links to explain what is the goal: - iscsi multipath mannual configuration: https://gist.github.com/apahim/7434734 - current vdsm implementation: https://gist.github.com/apahim/7434764 - vdsm results after this patch: https://gist.github.com/apahim/7434836 Change-Id: I488c0a1401606ac40a5ee4ef3d816f53b1d22785 Bug-Url: http://bugzilla.redhat.com/753541 Signed-off-by: Amador Pahim <apahim(a)redhat.com> --- M vdsm/storage/hsm.py M vdsm/storage/iscsiadm.py 2 files changed, 54 insertions(+), 41 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/21189/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 15fd9fa..13ff51f 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -147,7 +147,11 @@ def _BCInitiatorNameResolve(ifaceName): if not ifaceName: - return iscsi.IscsiInterface('default') + ifaces = config.get('irs', 'iscsi_default_ifaces').split(',') + if ifaces and 'iser' not in ifaces: + return iscsi.IscsiInterface(ifaces) + else: + return iscsi.IscsiInterface(['default']) for iface in iscsi.iterateIscsiInterfaces(): if iface.name == ifaceName: diff --git a/vdsm/storage/iscsiadm.py b/vdsm/storage/iscsiadm.py index 9bb27ea..30b811f 100644 --- a/vdsm/storage/iscsiadm.py +++ b/vdsm/storage/iscsiadm.py @@ -229,70 +229,79 @@ def node_new(iface, portal, targetName): - rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", iface, "-p", - portal, "--op=new"]) - if rc == 0: - return + for i in iface: + if not iface_exists(i): + iface_new(i) - if not iface_exists(iface): - raise IscsiInterfaceDoesNotExistError(iface) + rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", i, "-p", + portal+",1", "--op=new"]) - raise IscsiNodeError(rc, out, err) + if rc != 0: + raise IscsiNodeError(rc, out, err) + + return def node_update(iface, portal, targetName, key, value, hideValue=False): - rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", iface, "-p", - portal, "-n", key, "-v", value, "--op=update"], - hideValue) - if rc == 0: - return + for i in iface: + if not iface_exists(i): + iface_new(i) - if not iface_exists(iface): - raise IscsiInterfaceDoesNotExistError(iface) + rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", i, "-p", + portal+",1", "-n", key, "-v", + value, "--op=update"], hideValue) - raise IscsiNodeError(rc, out, err) + if rc != 0: + raise IscsiNodeError(rc, out, err) + + return def node_delete(iface, portal, targetName): - rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", iface, "-p", - portal, "--op=delete"]) - if rc == 0: - return + for i in iface: + if iface_exists(i): + iface_delete(i) - if not iface_exists(iface): - raise IscsiInterfaceDoesNotExistError(iface) + rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", i, "-p", + portal+",1", "--op=delete"]) + if rc != 0: + raise IscsiNodeError(rc, out, err) - raise IscsiNodeError(rc, out, err) + return def node_disconnect(iface, portal, targetName): - rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", iface, "-p", - portal, "-u"]) - if rc == 0: - return + for i in iface: + if not iface_exists(i): + raise IscsiInterfaceDoesNotExistError(i) - if not iface_exists(iface): - raise IscsiInterfaceDoesNotExistError(iface) + rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", + iface, "-p", portal+",1", "-u"]) - if rc == ISCSI_ERR_OBJECT_NOT_FOUND: - raise IscsiSessionNotFound(iface, portal, targetName) + if rc == ISCSI_ERR_OBJECT_NOT_FOUND: + raise IscsiSessionNotFound(iface, portal, targetName) - raise IscsiNodeError(rc, out, err) + if rc != 0: + raise IscsiNodeError(rc, out, err) + + return def node_login(iface, portal, targetName): - rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", iface, "-p", - portal, "-l"]) - if rc == 0: - return + for i in iface: + if not iface_exists(i): + raise IscsiInterfaceDoesNotExistError(i) - if not iface_exists(iface): - raise IscsiInterfaceDoesNotExistError(iface) + rc, out, err = _runCmd(["-m", "node", "-T", targetName, "-I", i, "-p", + portal+",1", "-l"]) - if rc == ISCSI_ERR_LOGIN_AUTH_FAILED: - raise IscsiAuthenticationError(rc, out, err) + if rc == ISCSI_ERR_LOGIN_AUTH_FAILED: + raise IscsiAuthenticationError(rc, out, err) - raise IscsiNodeError(rc, out, err) + if rc != 0: + raise IscsiNodeError(rc, out, err) + + return def session_rescan_async(): -- To view, visit http://gerrit.ovirt.org/21189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I488c0a1401606ac40a5ee4ef3d816f53b1d22785 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apahim(a)redhat.com>

4 10

Change in vdsm[master]: tests: Move securable tests to its own test module
by Nir Soffer 15 Feb '14

15 Feb '14

Nir Soffer has uploaded a new change for review. Change subject: tests: Move securable tests to its own test module ...................................................................... tests: Move securable tests to its own test module The tests were hidden in tests/main.py making it harder to find the tests. Change-Id: I40fad51de67ad732d9a91119010a6bf889af6bc7 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M tests/Makefile.am M tests/main.py 2 files changed, 1 insertion(+), 67 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/24482/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 44d4923..b7105ba 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -61,6 +61,7 @@ remoteFileHandlerTests.py \ resourceManagerTests.py \ schemaTests.py \ + securableTests.py \ sslTests.py \ storageMailboxTests.py \ tcTests.py \ diff --git a/tests/main.py b/tests/main.py index e2237da..1f87092 100644 --- a/tests/main.py +++ b/tests/main.py @@ -23,76 +23,9 @@ from gluster import exception as gluster_exception from storage import storage_exception -from storage.securable import secured, SecureError, unsecured from vdsm.utils import GeneralException from testrunner import VdsmTestCase as TestCaseBase - - -class TestSecurable(TestCaseBase): - - @secured - class MySecureClass(object): - - def __init__(self): - self.secured = False - - def __is_secure__(self): - return self.secured - - def securedMethod(self): - "securedMethod docstring" - pass - - @unsecured - def unsecuredMethod(self): - "unsecuredMethod docstring" - pass - - class MyClassWithoutIsSecureMethod(object): - pass - - class MyClassIsSecureClassMethod(object): - - @classmethod - def __is_secure__(self): - pass - - def assertUnsecured(self, secureObject): - self.assertRaises(SecureError, secureObject.securedMethod) - secureObject.unsecuredMethod() - - def assertSecured(self, secureObject): - secureObject.securedMethod() - secureObject.unsecuredMethod() - - def testIsSecureMethodCheck(self): - self.assertRaises(NotImplementedError, secured, - TestSecurable.MyClassWithoutIsSecureMethod) - self.assertRaises(NotImplementedError, secured, - TestSecurable.MyClassIsSecureClassMethod) - - def testSecurable(self): - secureObject = TestSecurable.MySecureClass() - self.assertUnsecured(secureObject) - - secureObject.secured = True - self.assertSecured(secureObject) - - secureObject.secured = False - self.assertUnsecured(secureObject) - - def testSecurityOverride(self): - secureObject = TestSecurable.MySecureClass() - secureObject.securedMethod(__securityOverride=True) - - def testDocstringWrapping(self): - secureObject = TestSecurable.MySecureClass() - - self.assertEqual(secureObject.securedMethod.__doc__, - "securedMethod docstring") - self.assertEqual(secureObject.unsecuredMethod.__doc__, - "unsecuredMethod docstring") class TestStorageExceptions(TestCaseBase): -- To view, visit http://gerrit.ovirt.org/24482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I40fad51de67ad732d9a91119010a6bf889af6bc7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>

3 5

Change in vdsm[master]: execCmd: no need to pass the default sudo=False value
by Dan Kenigsberg 15 Feb '14

15 Feb '14

Dan Kenigsberg has uploaded a new change for review. Change subject: execCmd: no need to pass the default sudo=False value ...................................................................... execCmd: no need to pass the default sudo=False value These are remnants from the days where we had a crazier default. Cleaned with sed -i 's/execCmd$.*$, sudo=False/execCmd\1/' and a couple of manual additions. Change-Id: Id8c0e30756113ddb35d2e51984c3ea72bbe45a44 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/utils.py M tests/functional/virtTests.py M tests/miscTests.py M tests/utilsTests.py M vdsm/hooks.py M vdsm/ksm.py M vdsm/storage/blockSD.py M vdsm/storage/clusterlock.py M vdsm/storage/devicemapper.py M vdsm/storage/fuser.py M vdsm/storage/misc.py M vdsm/storage/multipath.py M vdsm/storage/storage_mailbox.py M vdsm/storage/volume.py M vdsm/supervdsmServer M vdsm/tc.py M vdsm_hooks/checkimages/before_vm_start.py M vdsm_hooks/hostusb/after_vm_destroy.py M vdsm_hooks/hostusb/before_vm_start.py M vdsm_hooks/scratchpad/before_vm_start.py 20 files changed, 43 insertions(+), 44 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/24145/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index 8a3bb64..3606464 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -556,7 +556,7 @@ self._poller.close() -def execCmd(command, sudo=False, cwd=None, data=None, raw=False, logErr=True, +def execCmd(command, cwd=None, data=None, raw=False, logErr=True, printable=None, env=None, sync=True, nice=None, ioclass=None, ioclassdata=None, setsid=False, execCmdLogger=logging.root, deathSignal=0, childUmask=None): @@ -629,7 +629,7 @@ """ Executes an external command, optionally via sudo with stop abilities. """ - proc = execCmd(command, sudo=False, cwd=cwd, data=data, sync=False, + proc = execCmd(command, cwd=cwd, data=data, sync=False, nice=nice, ioclass=ioclass, execCmdLogger=execCmdLogger, deathSignal=deathSignal) if recoveryCallback: diff --git a/tests/functional/virtTests.py b/tests/functional/virtTests.py index 862cf45..cadcca9 100644 --- a/tests/functional/virtTests.py +++ b/tests/functional/virtTests.py @@ -86,7 +86,7 @@ logging.warning('Generating a temporary initramfs image') fd, path = tempfile.mkstemp() cmd = [_mkinitrd.cmd, "-f", path, _kernelVer] - rc, out, err = execCmd(cmd, sudo=False) + rc, out, err = execCmd(cmd) os.chmod(path, 0o644) return path diff --git a/tests/miscTests.py b/tests/miscTests.py index 13eddbe..5858b05 100644 --- a/tests/miscTests.py +++ b/tests/miscTests.py @@ -342,7 +342,7 @@ def testWaitTimeout(self): ttl = 2 - p = utils.execCmd([EXT_SLEEP, str(ttl + 10)], sudo=False, sync=False) + p = utils.execCmd([EXT_SLEEP, str(ttl + 10)], sync=False) startTime = time.time() p.wait(ttl) duration = time.time() - startTime @@ -352,7 +352,7 @@ def testWaitCond(self): ttl = 2 - p = utils.execCmd([EXT_SLEEP, str(ttl + 10)], sudo=False, sync=False) + p = utils.execCmd([EXT_SLEEP, str(ttl + 10)], sync=False) startTime = time.time() p.wait(cond=lambda: time.time() - startTime > ttl) duration = time.time() - startTime @@ -363,7 +363,7 @@ def testCommunicate(self): data = ("The trouble with the world is that the stupid are cocksure " "and the intelligent are full of doubt") - p = utils.execCmd([EXT_DD], data=data, sudo=False, sync=False) + p = utils.execCmd([EXT_DD], data=data, sync=False) p.stdin.close() self.assertEquals(p.stdout.read(len(data)).strip(), data) @@ -688,7 +688,7 @@ with tempfile.NamedTemporaryFile() as f: cmd = [EXT_DD, "bs=1", "if=/dev/urandom", 'of=%s' % f.name, 'count=%d' % count] - rc, out, err = utils.execCmd(cmd, sudo=False) + rc, out, err = utils.execCmd(cmd) self.assertTrue(misc.validateDDBytes(err, count)) @@ -700,7 +700,7 @@ with tempfile.NamedTemporaryFile() as f: cmd = [EXT_DD, "bs=1", "if=/dev/urandom", 'of=%s' % f.name, 'count=%d' % count] - rc, out, err = utils.execCmd(cmd, sudo=False) + rc, out, err = utils.execCmd(cmd) self.assertFalse(misc.validateDDBytes(err, count + 1)) @@ -993,12 +993,12 @@ """ Tests that execCmd execs and returns the correct ret code """ - ret, out, err = utils.execCmd([EXT_ECHO], sudo=False) + ret, out, err = utils.execCmd([EXT_ECHO]) self.assertEquals(ret, 0) def testNoCommand(self): - self.assertRaises(OSError, utils.execCmd, ["I.DONT.EXIST"], sudo=False) + self.assertRaises(OSError, utils.execCmd, ["I.DONT.EXIST"]) def testStdOut(self): """ @@ -1008,7 +1008,7 @@ line = "All I wanted was to have some pizza, hang out with dad, " + \ "and not let your weirdness mess up my day" # (C) Nickolodeon - Invader Zim - ret, stdout, stderr = utils.execCmd((EXT_ECHO, line), sudo=False) + ret, stdout, stderr = utils.execCmd((EXT_ECHO, line)) self.assertEquals(stdout[0], line) def testStdErr(self): @@ -1020,8 +1020,7 @@ "turning you on at all?" # (C) Fox - The X Files code = "import sys; sys.stderr.write('%s')" % line - ret, stdout, stderr = utils.execCmd([EXT_PYTHON, "-c", code], - sudo=False) + ret, stdout, stderr = utils.execCmd([EXT_PYTHON, "-c", code]) self.assertEquals(stderr[0], line) def testSudo(self): @@ -1036,7 +1035,7 @@ def testNice(self): cmd = ["sleep", "10"] - proc = utils.execCmd(cmd, sudo=False, nice=10, sync=False) + proc = utils.execCmd(cmd, nice=10, sync=False) def test(): nice = utils.pidStat(proc.pid).nice diff --git a/tests/utilsTests.py b/tests/utilsTests.py index b3b102d..784255c 100644 --- a/tests/utilsTests.py +++ b/tests/utilsTests.py @@ -57,7 +57,7 @@ class PidStatTests(TestCaseBase): def test(self): args = ["sleep", "3"] - sproc = utils.execCmd(args, sync=False, sudo=False) + sproc = utils.execCmd(args, sync=False) stats = utils.pidStat(sproc.pid) pid = int(stats.pid) # procName comes in the format of (procname) @@ -88,7 +88,7 @@ class GetCmdArgsTests(TestCaseBase): def test(self): args = [EXT_SLEEP, "4"] - sproc = utils.execCmd(args, sync=False, sudo=False) + sproc = utils.execCmd(args, sync=False) try: self.assertEquals(utils.getCmdArgs(sproc.pid), tuple(args)) finally: @@ -97,7 +97,7 @@ def testZombie(self): args = [EXT_SLEEP, "0"] - sproc = utils.execCmd(args, sync=False, sudo=False) + sproc = utils.execCmd(args, sync=False) sproc.kill() try: test = lambda: self.assertEquals(utils.getCmdArgs(sproc.pid), diff --git a/vdsm/hooks.py b/vdsm/hooks.py index d31096b..75f33f9 100644 --- a/vdsm/hooks.py +++ b/vdsm/hooks.py @@ -95,7 +95,7 @@ errorSeen = False for s in scripts: - rc, out, err = utils.execCmd([s], sudo=False, raw=True, + rc, out, err = utils.execCmd([s], raw=True, env=scriptenv) logging.info(err) if rc != 0: diff --git a/vdsm/ksm.py b/vdsm/ksm.py index 05e4ff9..7ace217 100644 --- a/vdsm/ksm.py +++ b/vdsm/ksm.py @@ -48,7 +48,7 @@ self._lock = threading.Lock() if config.getboolean('ksm', 'ksm_monitor_thread'): pids = utils.execCmd([constants.EXT_PGREP, '-xf', 'ksmd'], - raw=False, sudo=False)[1] + raw=False)[1] if pids: self._pid = pids[0].strip() self._cif.log.info( diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 5179c5a..7f608e1 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -213,7 +213,7 @@ cmd = [constants.EXT_DD, "oflag=%s" % misc.DIRECTFLAG, "if=/dev/zero", "of=%s" % lvm.lvPath(sdUUID, volUUID), "bs=%s" % BS, "count=%s" % count] - p = misc.execCmd(cmd, sudo=False, sync=False, + p = misc.execCmd(cmd, sync=False, nice=utils.NICENESS.HIGH, ioclass=utils.IOCLASS.IDLE, deathSignal=signal.SIGKILL) return p diff --git a/vdsm/storage/clusterlock.py b/vdsm/storage/clusterlock.py index f7e7fb6..3260664 100644 --- a/vdsm/storage/clusterlock.py +++ b/vdsm/storage/clusterlock.py @@ -65,7 +65,7 @@ def initLock(self): lockUtil = os.path.join(self.lockUtilPath, "safelease") initCommand = [lockUtil, "release", "-f", self._leasesPath, "0"] - rc, out, err = misc.execCmd(initCommand, sudo=False, + rc, out, err = misc.execCmd(initCommand, cwd=self.lockUtilPath) if rc != 0: self.log.warn("could not initialise spm lease (%s): %s", rc, out) @@ -128,7 +128,7 @@ releaseLockCommand = [freeLockUtil, self._sdUUID] self.log.info("Releasing cluster lock for domain %s" % self._sdUUID) - (rc, out, err) = misc.execCmd(releaseLockCommand, sudo=False, + (rc, out, err) = misc.execCmd(releaseLockCommand, cwd=self.lockUtilPath) if rc != 0: self.log.error("Could not release cluster lock " diff --git a/vdsm/storage/devicemapper.py b/vdsm/storage/devicemapper.py index 686b453..1a0d5cc 100644 --- a/vdsm/storage/devicemapper.py +++ b/vdsm/storage/devicemapper.py @@ -119,7 +119,7 @@ def _removeMapping(deviceName): cmd = [EXT_DMSETUP, "remove", deviceName] - rc = misc.execCmd(cmd, sudo=False)[0] + rc = misc.execCmd(cmd)[0] if rc != 0: raise Exception("Could not remove mapping `%s`" % deviceName) @@ -150,7 +150,7 @@ def _getPathsStatus(): cmd = [EXT_DMSETUP, "status"] - rc, out, err = misc.execCmd(cmd, sudo=False) + rc, out, err = misc.execCmd(cmd) if rc != 0: raise Exception("Could not get device statuses") diff --git a/vdsm/storage/fuser.py b/vdsm/storage/fuser.py index 0f235ee..3d5523c 100644 --- a/vdsm/storage/fuser.py +++ b/vdsm/storage/fuser.py @@ -27,7 +27,7 @@ cmd.append("-m") cmd.append(path) - (rc, out, err) = misc.execCmd(cmd, raw=True, sudo=False) + (rc, out, err) = misc.execCmd(cmd, raw=True) if rc != 0: return [] diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py index 39eb88b..6c9dd15 100644 --- a/vdsm/storage/misc.py +++ b/vdsm/storage/misc.py @@ -199,7 +199,7 @@ if buffersize: cmd.extend(["bs=%d" % buffersize, "count=1"]) - (rc, out, err) = execCmd(cmd, sudo=False) + (rc, out, err) = execCmd(cmd) if rc: raise se.MiscFileReadException(name) @@ -365,7 +365,7 @@ cmd.append("oflag=%s" % oflag) if not stop: - (rc, out, err) = execCmd(cmd, sudo=False, nice=utils.NICENESS.HIGH, + (rc, out, err) = execCmd(cmd, nice=utils.NICENESS.HIGH, ioclass=utils.IOCLASS.IDLE, deathSignal=signal.SIGKILL) else: diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py index 29851f3..82d435d 100644 --- a/vdsm/storage/multipath.py +++ b/vdsm/storage/multipath.py @@ -211,7 +211,7 @@ "--export", "--replace-whitespace", "--device=" + blkdev] - (rc, out, err) = misc.execCmd(cmd, sudo=False) + (rc, out, err) = misc.execCmd(cmd) if rc == 0: for line in out: if line.startswith("ID_SERIAL="): diff --git a/vdsm/storage/storage_mailbox.py b/vdsm/storage/storage_mailbox.py index d56a2d7..8ac56b9 100644 --- a/vdsm/storage/storage_mailbox.py +++ b/vdsm/storage/storage_mailbox.py @@ -275,7 +275,7 @@ def _initMailbox(self): # Sync initial incoming mail state with storage view - (rc, out, err) = _mboxExecCmd(self._inCmd, sudo=False, raw=True) + (rc, out, err) = _mboxExecCmd(self._inCmd, raw=True) if rc == 0: self._incomingMail = out self._init = True @@ -372,7 +372,7 @@ def _checkForMail(self): #self.log.debug("HSM_MailMonitor - checking for mail") #self.log.debug("Running command: " + str(self._inCmd)) - (rc, in_mail, err) = misc.execCmd(self._inCmd, sudo=False, raw=True) + (rc, in_mail, err) = misc.execCmd(self._inCmd, raw=True) if rc: raise RuntimeError("_handleResponses.Could not read mailbox - rc " "%s" % rc) @@ -391,7 +391,7 @@ pChk = struct.pack('<l', chk) # Assumes CHECKSUM_BYTES equals 4!!! self._outgoingMail = \ self._outgoingMail[0:MAILBOX_SIZE - CHECKSUM_BYTES] + pChk - _mboxExecCmd(self._outCmd, data=self._outgoingMail, sudo=False) + _mboxExecCmd(self._outCmd, data=self._outgoingMail) def _handleMessage(self, message): # TODO: add support for multiple mailboxes @@ -575,7 +575,7 @@ self.log.debug("SPM_MailMonitor - clearing outgoing mail, command is: " "%s", self._outCmd) cmd = self._outCmd + ['bs=' + str(self._outMailLen)] - (rc, out, err) = _mboxExecCmd(cmd, sudo=False, data=self._outgoingMail) + (rc, out, err) = _mboxExecCmd(cmd, data=self._outgoingMail) if rc: self.log.warning("SPM_MailMonitor couldn't clear outgoing mail, " "dd failed") @@ -730,7 +730,7 @@ cmd = self._inCmd + ['bs=' + str(self._outMailLen)] #self.log.debug("SPM_MailMonitor - reading incoming mail, " # "command: " + str(cmd)) - (rc, in_mail, err) = misc.execCmd(cmd, sudo=False, raw=True) + (rc, in_mail, err) = misc.execCmd(cmd, raw=True) if rc: raise IOError(errno.EIO, "_handleRequests._checkForMail - " "Could not read mailbox: %s" % self._inbox) @@ -747,7 +747,7 @@ self._outLock.acquire() try: cmd = self._outCmd + ['bs=' + str(self._outMailLen)] - (rc, out, err) = _mboxExecCmd(cmd, sudo=False, + (rc, out, err) = _mboxExecCmd(cmd, data=self._outgoingMail) if rc: self.log.warning("SPM_MailMonitor couldn't write " @@ -773,7 +773,7 @@ 'seek=' + str(mailboxOffset / MAILBOX_SIZE)] #self.log.debug("Running command: %s, for message id: %s", # str(cmd), str(msgID)) - (rc, out, err) = _mboxExecCmd(cmd, sudo=False, data=mailbox) + (rc, out, err) = _mboxExecCmd(cmd, data=mailbox) if rc: self.log.error("SPM_MailMonitor: sendReply - couldn't send " "reply, dd failed") diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py index 341a54d..30de1bc 100644 --- a/vdsm/storage/volume.py +++ b/vdsm/storage/volume.py @@ -1033,7 +1033,7 @@ # +1 is so that odd numbers will round upwards. cmd += [volume, "%uK" % ((size + 1) / 2)] - (rc, out, err) = misc.execCmd(cmd, sudo=False, cwd=cwd, + (rc, out, err) = misc.execCmd(cmd, cwd=cwd, deathSignal=signal.SIGKILL) if rc: raise se.VolumeCreationError(out) diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer index 21351c3..54854dc 100755 --- a/vdsm/supervdsmServer +++ b/vdsm/supervdsmServer @@ -256,7 +256,7 @@ self.__udevReloadRules(guid) cmd = [EXT_UDEVADM, 'trigger', '--verbose', '--action', 'change', '--property-match=DM_NAME=%s' % guid] - rc, out, err = utils.execCmd(cmd, sudo=False) + rc, out, err = utils.execCmd(cmd) if rc: raise OSError(errno.EINVAL, "Could not trigger change for device \ %s, out %s\nerr %s" % (guid, out, err)) @@ -342,7 +342,7 @@ else: reload = "--reload-rules" cmd = [EXT_UDEVADM, 'control', reload] - rc, out, err = utils.execCmd(cmd, sudo=False) + rc, out, err = utils.execCmd(cmd) if rc: self.log.error("Udevadm reload-rules command failed rc=%s, " "out=\"%s\", err=\"%s\"", rc, out, err) @@ -352,7 +352,7 @@ @utils.memoized def __udevVersion(self): cmd = [EXT_UDEVADM, '--version'] - rc, out, err = utils.execCmd(cmd, sudo=False) + rc, out, err = utils.execCmd(cmd) if rc: self.log.error("Udevadm version command failed rc=%s, " " out=\"%s\", err=\"%s\"", rc, out, err) diff --git a/vdsm/tc.py b/vdsm/tc.py index 2b2dfa5..00dfc0b 100644 --- a/vdsm/tc.py +++ b/vdsm/tc.py @@ -99,7 +99,7 @@ def _process_request(command): - retcode, out, err = execCmd(command, raw=True, sudo=False) + retcode, out, err = execCmd(command, raw=True) if retcode != 0: raise TrafficControlException(retcode, err, command) return out diff --git a/vdsm_hooks/checkimages/before_vm_start.py b/vdsm_hooks/checkimages/before_vm_start.py index 0fb1d85..40a1326 100755 --- a/vdsm_hooks/checkimages/before_vm_start.py +++ b/vdsm_hooks/checkimages/before_vm_start.py @@ -75,7 +75,7 @@ # Check the image using qemu-img. Enforce check termination # on timeout expiration - p = hooking.execCmd(cmd, sudo=False, raw=True, sync=False) + p = hooking.execCmd(cmd, raw=True, sync=False) if not p.wait(timeout): p.kill() diff --git a/vdsm_hooks/hostusb/after_vm_destroy.py b/vdsm_hooks/hostusb/after_vm_destroy.py index 8c18a53..ee3379f 100755 --- a/vdsm_hooks/hostusb/after_vm_destroy.py +++ b/vdsm_hooks/hostusb/after_vm_destroy.py @@ -48,7 +48,7 @@ # remove the 0x from the vendor and product id devid = vendorid[2:] + ':' + productid[2:] command = ['lsusb', '-d', devid] - retcode, out, err = hooking.execCmd(command, sudo=False, raw=True) + retcode, out, err = hooking.execCmd(command, raw=True) if retcode != 0: sys.stderr.write('hostusb: cannot find usb device: %s\n' % devid) sys.exit(2) diff --git a/vdsm_hooks/hostusb/before_vm_start.py b/vdsm_hooks/hostusb/before_vm_start.py index 266df60..8dabd8a 100755 --- a/vdsm_hooks/hostusb/before_vm_start.py +++ b/vdsm_hooks/hostusb/before_vm_start.py @@ -67,7 +67,7 @@ # remove the 0x from the vendor and product id devid = vendorid[2:] + ':' + productid[2:] command = ['lsusb', '-d', devid] - retcode, out, err = hooking.execCmd(command, sudo=False, raw=True) + retcode, out, err = hooking.execCmd(command, raw=True) if retcode != 0: sys.stderr.write('hostusb: cannot find usb device: %s\n' % devid) sys.exit(2) diff --git a/vdsm_hooks/scratchpad/before_vm_start.py b/vdsm_hooks/scratchpad/before_vm_start.py index 2e5ddc6..0ff3876 100755 --- a/vdsm_hooks/scratchpad/before_vm_start.py +++ b/vdsm_hooks/scratchpad/before_vm_start.py @@ -33,7 +33,7 @@ Create image file ''' command = ['/usr/bin/qemu-img', 'create', '-f', 'raw', path, size] - retcode, out, err = hooking.execCmd(command, sudo=False, raw=True) + retcode, out, err = hooking.execCmd(command, raw=True) if retcode != 0: sys.stderr.write('scratchpad: error running command %s, err = %s\n' % (' '.join(command), err)) -- To view, visit http://gerrit.ovirt.org/24145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8c0e30756113ddb35d2e51984c3ea72bbe45a44 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

6 21

Change in vdsm[master]: Revert "Fixing ssl config validation"
by Federico Simoncelli 14 Feb '14

14 Feb '14

Federico Simoncelli has uploaded a new change for review. Change subject: Revert "Fixing ssl config validation" ...................................................................... Revert "Fixing ssl config validation" This reverts commit cff03f968e882d94808cf272d9cc3e2ac29fabd0. Setting ssl=false in vdsm.conf makes impossible to start the vdsmd service: FAILED: conflicting vdsm and libvirt-qemu tls configuration. vdsm.conf with ssl=False requires the following changed: libvirtd.conf: listen_tcp=1, auth_tcp="none", qemu.conf: spice_tls=0. Also running: # vdsm-tool configure --force is not resolving the situation. Change-Id: Ic4cab6f3346f9b1ad492d40ea3d3c645484570da Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M lib/vdsm/tool/libvirt_configure.sh.in 1 file changed, 15 insertions(+), 32 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/24492/1 diff --git a/lib/vdsm/tool/libvirt_configure.sh.in b/lib/vdsm/tool/libvirt_configure.sh.in index f1b70bd..8a70be5 100755 --- a/lib/vdsm/tool/libvirt_configure.sh.in +++ b/lib/vdsm/tool/libvirt_configure.sh.in @@ -47,16 +47,11 @@ get_libvirt_conf_item() { local cfile="$1" local key="$2" - @GREP_PATH@ "^\s*"${key}"\s*=" "${cfile}" >/dev/null 2>&1 | \ + @GREP_PATH@ "^\s*"${key}"\s*=" "${cfile}" | \ tail -1 | @SED_PATH@ "s/\s*$key\s*=\s*//;s/\s*$#.*$\?$//" } test_conflicting_conf() { - test_ssl_conflict_conf - # add here additional conf checks -} - -test_ssl_conflict_conf() { local lconf="$1" local qconf="$2" @@ -66,38 +61,26 @@ return 3 fi + if [ "${ssl}" = "true" ]; then + echo "SUCCESS: ssl configured to true. No conflicts" + return 0 + fi + local listen_tcp="$(get_libvirt_conf_item "${lconf}" listen_tcp)" local auth_tcp="$(get_libvirt_conf_item "${lconf}" auth_tcp)" local spice_tls="$(get_libvirt_conf_item "${qconf}" spice_tls)" - if [ "${ssl}" = "true" ]; then - if [ "${listen_tcp}" != "1" -a \ - "${auth_tcp}" != '"none"' -a \ - "${spice_tls}" != "0" ]; then - echo "SUCCESS: ssl configured to true. No conflicts" - return 0 - else - echo "FAILED: conflicting vdsm and libvirt-qemu tls configuration." - echo "vdsm.conf with ssl=True requires the following changed: " - echo "libvirtd.conf: listen_tcp=0, auth_tcp=\"sasl\", " - echo "qemu.conf: spice_tls=1." - return 1 - fi - + if [ "${listen_tcp}" = "1" -a \ + "${auth_tcp}" = '"none"' -a \ + "${spice_tls}" = "0" ]; then + echo "SUCCESS: No conflicts between configuration files" return 0 else - if [ "${listen_tcp}" = "1" -a \ - "${auth_tcp}" = '"none"' -a \ - "${spice_tls}" = "0" ]; then - echo "SUCCESS: ssl configured to false. No conflicts." - return 0 - else - echo "FAILED: conflicting vdsm and libvirt-qemu tls configuration." - echo "vdsm.conf with ssl=False requires the following changed: " - echo "libvirtd.conf: listen_tcp=1, auth_tcp=\"none\", " - echo "qemu.conf: spice_tls=0." - return 1 - fi + echo "FAILED: conflicting vdsm and libvirt-qemu tls configuration." + echo "vdsm.conf with ssl=False requires the following changed: " + echo "libvirtd.conf: listen_tcp=1, auth_tcp=\"none\", " + echo "qemu.conf: spice_tls=0." + return 1 fi } -- To view, visit http://gerrit.ovirt.org/24492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic4cab6f3346f9b1ad492d40ea3d3c645484570da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 5

Change in vdsm[master]: client: update the help of `create` command
by fromani＠redhat.com 14 Feb '14

14 Feb '14

Francesco Romani has uploaded a new change for review. Change subject: client: update the help of `create` command ...................................................................... client: update the help of `create` command This patch updates the help of the `create` command to keep up with last changes. Change-Id: I8a1f755d3586a232e3645afc2ebe6613814225cc Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M client/vdsClient.py 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/24150/1 diff --git a/client/vdsClient.py b/client/vdsClient.py index beae673..5638ca8 100644 --- a/client/vdsClient.py +++ b/client/vdsClient.py @@ -1806,13 +1806,11 @@ 'o acpiEnable : If present will remove the default ' '-no-acpi switch', 'o qgaEnable : use qemu-ga as guest agent', - 'o irqChip : If false, add the -no-kvm-irqchip ' - 'switch', 'o spiceSecureChannels : comma-separated list of ' 'spice channel that will be encrypted', 'o spiceMonitors : number of emulated screen heads', 'o soundDevice : emulated sound device', - 'o launchPaused : If "true", start qemu paused', + 'o launchPaused : If "true", start the VM paused', 'o vmName : human-readable name of new VM', 'o tabletEnable : If "true", enable tablet input', 'o timeOffset : guest\'s start date, relative to ' -- To view, visit http://gerrit.ovirt.org/24150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8a1f755d3586a232e3645afc2ebe6613814225cc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>

2 3

Change in vdsm[master]: schema: document the launchPaused parameter
by fromani＠redhat.com 14 Feb '14

14 Feb '14

Francesco Romani has uploaded a new change for review. Change subject: schema: document the launchPaused parameter ...................................................................... schema: document the launchPaused parameter add documentation for the launchPaused param, which was missing from the API schema. Change-Id: I279e68c7e6b2cca8496a5dbec6e3895d531bce97 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M vdsm_api/vdsmapi-schema.json 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/24144/1 diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 6d8c333..1ac45b5 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -2921,6 +2921,8 @@ # # @vmType: The type of VM # +# @launchPaused: #optional If present, launch the VM in pause mode. +# # Since: 4.10.0 ## {'type': 'VmParameters', @@ -2930,7 +2932,7 @@ 'nice': 'int', 'smp': 'uint', '*smpCoresPerSocket': 'uint', '*smpThreadsPerCore': 'uint', 'timeOffset': 'uint', 'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str', - 'vmType': 'VmType'}} + 'vmType': 'VmType', '*launchPaused': 'bool'}} ## # @VmInfo: -- To view, visit http://gerrit.ovirt.org/24144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I279e68c7e6b2cca8496a5dbec6e3895d531bce97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>

3 4

← Newer
1
...
37
38
39
40
41
42
43
...
53
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2014