vdsm-patches February 2014

vdsm-patches@lists.fedorahosted.org

42 participants
527 discussions

Change in vdsm[master]: test: unstable jsonrpc tests
by Dan Kenigsberg 18 Feb '14

18 Feb '14

Dan Kenigsberg has posted comments on this change. Change subject: test: unstable jsonrpc tests ...................................................................... Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24624/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-02-18 11:06:32 +0100 Line 6: Line 7: test: unstable jsonrpc tests Line 8: Line 9: I am not sure whether this will fix test instability because I am not Your commit message should state which instability you are trying to fix. In any case, another instability is still here: ====================================================================== FAIL: testLeakFd (miscTests.WatchCmd) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/jenkins/workspace/vdsm_unit_tests_gerrit/vdsm/tests/miscTests.py", line 988, in testLeakFd self.assertEquals(openFdNum(), openFds) AssertionError: 78 != 79 -------------------- >> begin captured logging << -------------------- Line 10: able to recreate it (saw only one failure in jenkins history). The ssl Line 11: flag was not passed to constructReactor so plain tcp reactors were Line 12: reused which might caused the issue. Line 13: -- To view, visit http://gerrit.ovirt.org/24624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6dfa4d6324baa0b7091ad6713854d146ec999d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: test: declare unstable test as broken
by Jenkins CI RO 18 Feb '14

18 Feb '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: test: declare unstable test as broken ...................................................................... Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7309/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6407/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7191/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ef53ee34fdcc022c7f2984f4aad4b82ee06840a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: test: declare unstable test as broken
by Nir Soffer 18 Feb '14

18 Feb '14

Nir Soffer has posted comments on this change. Change subject: test: declare unstable test as broken ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ef53ee34fdcc022c7f2984f4aad4b82ee06840a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-HasComments: No

1 0

Change in vdsm[master]: jsonrpc: StoragePool connect missing default value
by Jenkins CI RO 18 Feb '14

18 Feb '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: StoragePool connect missing default value ...................................................................... Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7308/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6406/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7190/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb5923e60314993834cf005af4ad89c21dd0dd76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsm: prepareVolumePath payload detection cleanup
by fromani＠redhat.com 18 Feb '14

18 Feb '14

Francesco Romani has uploaded a new change for review. Change subject: vdsm: prepareVolumePath payload detection cleanup ...................................................................... vdsm: prepareVolumePath payload detection cleanup the prepareVolumePath code path for cdrom/floppy images is complicated due the fact the code has to deal with both regular and payload-created images (vmPayload). This lead to complicate and error-prone code paths, which subsequent fixes made even more cumbersome. This patch is a more aggressive and deep cleanup of the code aiming to properly fix bz1047356. The idea behind the patch is to simplify the detection by factoring the conditions, changing the order of the checks and factoring out the image creation in the payload case. This code proven to be tricky, so deep and extensive verification is due. Change-Id: I3a630d74ec0910c669e0326ad343c5dbea25357e Bug-Url: https://bugzilla.redhat.com/1047356 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M vdsm/clientIF.py 1 file changed, 37 insertions(+), 30 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/22928/1 diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index 8e7f5f4..134b805 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -241,10 +241,30 @@ self.log.info('Error finding path for device', exc_info=True) raise vm.VolumeError(uuid) + def _prepareVolumeFromPayload(self, vmId, drive, device, params): + ''' + vmPayload is a key in params + 'vmPayload': {'volId': 'volume id', # volId is optional + 'file': {'filename': 'content', ...}} + ''' + mkFsNames = {'cdrom': 'mkIsoFs', 'floppy': 'mkFloppyFs'} + try: + mkFsFunction = getattr(supervdsm.getProxy(), + mkFsNames[device]) + except AttributeError: + raise vm.VolumeError("Unsupported 'device': %s in " + "drive: %s" % (device, drive)) + else: + payload = params['vmPayload'] + files = payload['file'] + volId = payload.get('volId') + return mkFsFunction(vmId, files, volId) + def prepareVolumePath(self, drive, vmId=None): if type(drive) is dict: + device = drive['device'] # PDIV drive format - if drive['device'] == 'disk' and vm.isVdsmImage(drive): + if device == 'disk' and vm.isVdsmImage(drive): res = self.irs.prepareImage( drive['domainID'], drive['poolID'], drive['imageID'], drive['volumeID']) @@ -272,36 +292,23 @@ elif "UUID" in drive: volPath = self._getUUIDSpecPath(drive["UUID"]) - # leave path == '' for empty cdrom and floppy drives ... - elif (drive['device'] in ('cdrom', 'floppy') and - 'specParams' in drive and - # next line can be removed in future, when < 3.3 engine - # is not supported - drive['specParams'].get('path', '') == '' and - drive.get('path', '') == '' and - 'vmPayload' not in drive['specParams']): + # cdrom and floppy drives + elif (device in ('cdrom', 'floppy') and 'specParams' in drive): + # vmPayload is a special case for those devices + # which needs to be handled first. + # caution: this code is trickier than it seems. + # see for example: + # https://bugzilla.redhat.com/shoaw_bug.cgi?id=1047356 + params = drive['specParams'] + if 'vmPayload' in params: + volPath = self._prepareVolumeFromPayload(vmId, drive, + device, params) + # leave path == '' for empty cdrom and floppy drives ... + elif (params.get('path', '') == '' and + # line above can be removed in future, when < 3.3 engine + # is not supported + drive.get('path', '') == ''): volPath = '' - - # ... or load the drive from vmPayload: - elif drive['device'] in ('cdrom', 'floppy') and \ - 'specParams' in drive and \ - 'vmPayload' in drive['specParams']: - ''' - vmPayload is a key in specParams - 'vmPayload': {'volId': 'volume id', # volId is optional - 'file': {'filename': 'content', ...}} - ''' - mkFsNames = {'cdrom': 'mkIsoFs', 'floppy': 'mkFloppyFs'} - try: - mkFsFunction = getattr(supervdsm.getProxy(), - mkFsNames[drive['device']]) - except AttributeError: - raise vm.VolumeError("Unsupported 'device': %s in " - "drive: %" % (drive['device'], drive)) - else: - files = drive['specParams']['vmPayload']['file'] - volId = drive['specParams']['vmPayload'].get('volId') - volPath = mkFsFunction(vmId, files, volId) elif "path" in drive: volPath = drive['path'] -- To view, visit http://gerrit.ovirt.org/22928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a630d74ec0910c669e0326ad343c5dbea25357e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>

6 37

Change in vdsm[master]: test: unstable jsonrpc tests
by Jenkins CI RO 18 Feb '14

18 Feb '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: test: unstable jsonrpc tests ...................................................................... Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7301/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6399/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7183/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6dfa4d6324baa0b7091ad6713854d146ec999d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-3.4]: introducing capability to stream data to image
by laravot＠redhat.com 18 Feb '14

18 Feb '14

Hello Nir Soffer, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/24597 to review the following change. Change subject: introducing capability to stream data to image ...................................................................... introducing capability to stream data to image This patch introduces the a new capabaility to vdsm which allows to upload using streaming content to vdsm images. Previously we sent ovf data using XMLRPC (UpdateVM verb), which limits the size of the data, having to encode the payload into the xml, and make it hard and inefficient to upload lot of data and store it on some image. This patch adds the capabillity to stream data to image, allowing efficient upload of data in any size and format and storing it directly on an image. As the XML-RPC spec doesn't support streaming and to avoid requiring another port by using dedicated http server, in this patch we use the existing xmlrpc server to handle upload requests. General upload information: ----------------------------------------------------------- PUT requests arriving to the server with content type of application/octet-stream to default paths that we use today for request handling ('/', '/RPC2') will be treated as upload requests. The upload itself is being executed within a task, that's needed to indicate that there's an operation executed by the host. Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/23281 Reviewed-by: Nir Soffer <nsoffer(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/imageSharing.py M vdsm/storage/sp.py 6 files changed, 211 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/24597/1 diff --git a/vdsm/API.py b/vdsm/API.py index 6103ea2..d9d8c9c 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -854,6 +854,11 @@ return self._irs.downloadImage( methodArgs, self._spUUID, self._sdUUID, self._UUID, volUUID) + def downloadFromStream(self, methodArgs, callback, volUUID=None): + return self._irs.downloadImageFromStream( + methodArgs, callback, self._spUUID, self._sdUUID, self._UUID, + volUUID) + class LVMVolumeGroup(APIBase): ctorArgs = ['lvmvolumegroupID'] diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py index 03859d3..9b56ea1 100644 --- a/vdsm/BindingXMLRPC.py +++ b/vdsm/BindingXMLRPC.py @@ -21,9 +21,12 @@ from errno import EINTR import SimpleXMLRPCServer from vdsm import SecureXMLRPCServer +import json +import httplib import logging import libvirt import threading +import socket from vdsm import constants from vdsm import utils @@ -113,11 +116,95 @@ else: basehandler = SimpleXMLRPCServer.SimpleXMLRPCRequestHandler - class LoggingHandler(basehandler): + class RequestHandler(basehandler): + + # Timeout for the request socket + timeout = 60 + log = logging.getLogger("BindingXMLRPC.RequestHandler") + + HEADER_POOL = 'Storage-Pool-Id' + HEADER_DOMAIN = 'Storage-Domain-Id' + HEADER_IMAGE = 'Image-Id' + HEADER_VOLUME = 'Volume-Id' + HEADER_CONTENT_LENGTH = 'content-length' + HEADER_CONTENT_TYPE = 'content-type' + def setup(self): threadLocal.client = self.client_address[0] threadLocal.server = self.request.getsockname()[0] return basehandler.setup(self) + + def do_PUT(self): + try: + contentLength = self.headers.getheader( + self.HEADER_CONTENT_LENGTH) + if not contentLength: + self.send_error(httplib.LENGTH_REQUIRED, + "missing content length") + return + + try: + contentLength = int(contentLength) + except ValueError: + self.send_error(httplib.BAD_REQUEST, + "invalid content length %r" % + contentLength) + return + + # Required headers + spUUID = self.headers.getheader(self.HEADER_POOL) + sdUUID = self.headers.getheader(self.HEADER_DOMAIN) + imgUUID = self.headers.getheader(self.HEADER_IMAGE) + if not all((spUUID, sdUUID, imgUUID)): + self.send_error(httplib.BAD_REQUEST, + "missing or empty required header(s):" + " spUUID=%s sdUUID=%s imgUUID=%s" + % (spUUID, sdUUID, imgUUID)) + return + + # Optional headers + volUUID = self.headers.getheader(self.HEADER_VOLUME) + + uploadFinishedEvent = threading.Event() + + def upload_finished(): + uploadFinishedEvent.set() + + methodArgs = {'fileObj': self.rfile, + 'contentLength': contentLength} + image = API.Image(imgUUID, spUUID, sdUUID) + response = image.downloadFromStream(methodArgs, + upload_finished, + volUUID) + + while not uploadFinishedEvent.is_set(): + uploadFinishedEvent.wait() + + json_response = json.dumps(response) + self.send_response(httplib.OK) + self.send_header(self.HEADER_CONTENT_TYPE, + 'application/json') + self.send_header(self.HEADER_CONTENT_LENGTH, + len(json_response)) + self.end_headers() + self.wfile.write(json_response) + + except socket.timeout: + self.send_error(httplib.REQUEST_TIMEOUT, + "request timeout") + + except Exception: + self.send_error(httplib.INTERNAL_SERVER_ERROR, + "error during execution", exc_info=True) + + def send_error(self, error, message, exc_info=False): + try: + self.log.error(message, exc_info=exc_info) + self.send_response(error) + self.end_headers() + except Exception: + self.log.error("failed to return response", + exc_info=True) def parse_request(self): r = (SecureXMLRPCServer.SecureXMLRPCRequestHandler. @@ -131,11 +218,11 @@ server_address, keyfile=KEYFILE, certfile=CERTFILE, ca_certs=CACERT, timeout=self.serverRespTimeout, - requestHandler=LoggingHandler) + requestHandler=RequestHandler) else: server = utils.SimpleThreadedXMLRPCServer( server_address, - requestHandler=LoggingHandler, logRequests=True) + requestHandler=RequestHandler, logRequests=True) utils.closeOnExec(server.socket.fileno()) return server diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 53c9dd0..5c7df0b 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1673,6 +1673,22 @@ self._spmSchedule(spUUID, "downloadImage", pool.downloadImage, methodArgs, sdUUID, imgUUID, volUUID) + @public + def downloadImageFromStream(self, methodArgs, callback, spUUID, sdUUID, + imgUUID, volUUID=None): + """ + Download an image from a stream. + + Warning: Internal use only. + """ + sdCache.produce(sdUUID) + pool = self.getPool(spUUID) + # NOTE: this could become an hsm task, in such case the LV extension + # required to prepare the destination should go through the mailbox. + self._spmSchedule(spUUID, "downloadImageFromStream", + pool.downloadImageFromStream, methodArgs, callback, + sdUUID, imgUUID, volUUID) + @deprecated @public def moveMultipleImages(self, spUUID, srcDomUUID, dstDomUUID, imgDict, diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index 70f21c4..a24bcc3 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -1173,3 +1173,22 @@ imageSharing.download(vol.getVolumePath(), methodArgs) finally: domain.deactivateImage(imgUUID) + + def downloadFromStream(self, methodArgs, callback, sdUUID, imgUUID, + volUUID=None): + try: + self._downloadFromStream(methodArgs, sdUUID, imgUUID, volUUID) + finally: + callback() + + def _downloadFromStream(self, methodArgs, sdUUID, imgUUID, volUUID=None): + domain = sdCache.produce(sdUUID) + + vol = self._activateVolumeForImportExport(domain, imgUUID, volUUID) + try: + # Extend the volume (if relevant) to the image size + vol.extend(imageSharing. + streamGetSize(methodArgs) / volume.BLOCK_SIZE) + imageSharing.streamDownloadImage(vol.getVolumePath(), methodArgs) + finally: + domain.deactivateImage(imgUUID) diff --git a/vdsm/storage/imageSharing.py b/vdsm/storage/imageSharing.py index 26f299a..7166293 100644 --- a/vdsm/storage/imageSharing.py +++ b/vdsm/storage/imageSharing.py @@ -18,11 +18,26 @@ # import logging +import signal +import socket import curlImgWrap +from vdsm import constants +from vdsm import utils +import storage_exception as se log = logging.getLogger("Storage.ImageSharing") +# Time to wait from finishing writing data to dd, until dd exists, +# Ensure that we don't keep the task active forever if dd cannot +# access the storage. +WAIT_TIMEOUT = 30 +# Number of bytes to read from the socket and write +# to dd stdin trough the pipe. Based on default socket buffer +# size(~80KB) and default pipe buffer size (64K), this should +# minimize system call overhead without consuming too much +# memory. +BUFFER_SIZE = 65536 def httpGetSize(methodArgs): @@ -46,6 +61,10 @@ return size +def streamGetSize(methodArgs): + return methodArgs['contentLength'] + + def httpDownloadImage(dstImgPath, methodArgs): curlImgWrap.download(methodArgs.get('url'), dstImgPath, methodArgs.get("headers", {})) @@ -56,6 +75,54 @@ methodArgs.get("headers", {})) +def streamDownloadImage(dstImgPath, methodArgs): + bytes_left = streamGetSize(methodArgs) + stream = methodArgs['fileObj'] + + cmd = [constants.EXT_DD, "of=%s" % dstImgPath, "bs=%s" % constants.MEGAB] + p = utils.execCmd(cmd, sudo=False, sync=False, + deathSignal=signal.SIGKILL) + try: + while bytes_left > 0: + to_read = min(BUFFER_SIZE, bytes_left) + + try: + data = stream.read(to_read) + except socket.timeout: + log.error("socket timeout") + raise se.MiscFileReadException() + + if not data: + total_size = streamGetSize(methodArgs) + log.error("partial data %s from %s", + total_size - bytes_left, total_size) + raise se.MiscFileReadException() + + p.stdin.write(data) + # Process stdin is not a real file object but a wrapper using + # StringIO buffer. To ensure that we don't use more memory if we + # get data faster then dd read it from the pipe, we flush on every + # write. We can remove flush() we can limit the buffer size used + # by this stdin wrapper. + p.stdin.flush() + bytes_left = bytes_left - len(data) + + p.stdin.close() + if not p.wait(WAIT_TIMEOUT): + log.error("timeout waiting for dd process") + raise se.StorageException() + + if p.returncode != 0: + log.error("dd error - code %s, stderr %s", + p.returncode, p.stderr.read(1000)) + raise se.MiscFileWriteException() + + except Exception: + if p.returncode is None: + p.kill() + raise + + _METHOD_IMPLEMENTATIONS = { 'http': (httpGetSize, httpDownloadImage, httpUploadImage), } diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index a020e1e..550419c 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -1618,6 +1618,20 @@ return image.Image(self.poolPath) \ .download(methodArgs, sdUUID, imgUUID, volUUID) + def downloadImageFromStream(self, methodArgs, callback, sdUUID, imgUUID, + volUUID=None): + """ + Download an image from a stream. + """ + imgResourceLock = rmanager.acquireResource( + sd.getNamespace(sdUUID, IMAGE_NAMESPACE), imgUUID, + rm.LockType.exclusive) + + with imgResourceLock: + return image.Image(self.poolPath) \ + .downloadFromStream(methodArgs, callback, sdUUID, imgUUID, + volUUID) + def moveMultipleImages(self, srcDomUUID, dstDomUUID, imgDict, vmUUID, force): """ -- To view, visit http://gerrit.ovirt.org/24597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>

2 5

Change in vdsm[master]: Add functions getNetworkList and getNetworkInfo to API
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has posted comments on this change. Change subject: Add functions getNetworkList and getNetworkInfo to API ...................................................................... Patch Set 4: ping -- To view, visit http://gerrit.ovirt.org/2664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: Schema: Typemap changes
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has posted comments on this change. Change subject: Schema: Typemap changes ...................................................................... Patch Set 1: ping? -- To view, visit http://gerrit.ovirt.org/23375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7af8f07e07450fda97819f64fd120536cb318717 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: netlink: fix pep8 for 1.4.5 (was fine for 1.4.6)
by asegurap＠redhat.com 17 Feb '14

17 Feb '14

Antoni Segura Puimedon has uploaded a new change for review. Change subject: netlink: fix pep8 for 1.4.5 (was fine for 1.4.6) ...................................................................... netlink: fix pep8 for 1.4.5 (was fine for 1.4.6) Change-Id: Ie0d16267e0ed7788c5a7190e1e7e2793fdd0ba1f Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com> --- M lib/vdsm/netlink.py 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/24602/1 diff --git a/lib/vdsm/netlink.py b/lib/vdsm/netlink.py index a22d6a4..eeb8e95 100644 --- a/lib/vdsm/netlink.py +++ b/lib/vdsm/netlink.py @@ -154,8 +154,7 @@ 'prefixlen': _rtnl_addr_get_prefixlen(addr), 'scope': _addr_scope(addr), 'flags': _rtnl_addr_get_flags(addr), - 'address': _addr_local(addr), - } + 'address': _addr_local(addr)} def _link_info(cache, link): -- To view, visit http://gerrit.ovirt.org/24602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0d16267e0ed7788c5a7190e1e7e2793fdd0ba1f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>

3 4

← Newer
1
...
34
35
36
37
38
39
40
...
53
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2014