vdsm-patches February 2014

vdsm-patches@lists.fedorahosted.org

42 participants
527 discussions

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Jenkins CI RO 20 Feb '14

20 Feb '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7331/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6429/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7213/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Alon Bar-Lev 20 Feb '14

20 Feb '14

Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 3: not sure I understand... have you disabled the plain password as argument? -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Alon Bar-Lev 20 Feb '14

20 Feb '14

Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 1: Code-Review-1 Hi, There is no need for base64. CLI should support the following options, by order (first wins): 1. get password from cli a. file, the file should contain plain password. b. argument, weak, encouraged but we do not enforce our-selves. 2. get password from environment. 3. get password interactively (optional). See a simple example at[1]. I kinda like the openssl[2] solution... to use --xxxx=file:xxx --xxxx=pass:xxx --xxxx=env:xxx but not that important, we can have two arguments. Anyway, the base64 is not required. Thanks! [1] http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=packaging/bin/en… [2] https://www.openssl.org/docs/apps/openssl.html -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by didi＠redhat.com 20 Feb '14

20 Feb '14

Yedidyah Bar David has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24733/1//COMMIT_MSG Commit Message: Line 9: Current method to provide password for vdsClient commands is typing it Line 10: in the command line. The BZ1032525 requests to provide safer way. Line 11: Line 12: This patch implements file based way of providing passwords which is Line 13: encoded using base64 and stored in the first line of the file. Each Why base64? Why not just plain text? IMO base64 adds no advantages and just complicates use for the common case. We want to make this as comfortable as possible so that people will actually use it if they care even a bit about security. Line 14: command using passwords now can accept old way password or path to the Line 15: file with a password. Line 16: Line 17: -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: jsonrpc: StoragePool connect missing default value
by Nir Soffer 19 Feb '14

19 Feb '14

Nir Soffer has posted comments on this change. Change subject: jsonrpc: StoragePool connect missing default value ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb5923e60314993834cf005af4ad89c21dd0dd76 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: test: ssl reactor not tested in jsonrpc tests
by Nir Soffer 19 Feb '14

19 Feb '14

Nir Soffer has posted comments on this change. Change subject: test: ssl reactor not tested in jsonrpc tests ...................................................................... Patch Set 3: Code-Review+1 You should be able to verify this by looking at the test output - expanding permutations creates two test methods and you should see their names in the test output. -- To view, visit http://gerrit.ovirt.org/24624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6dfa4d6324baa0b7091ad6713854d146ec999d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: test: declare unstable test as broken
by Dan Kenigsberg 19 Feb '14

19 Feb '14

Dan Kenigsberg has submitted this change and it was merged. Change subject: test: declare unstable test as broken ...................................................................... test: declare unstable test as broken Before making sure that provided fix [1] makes the test stable it will be marked as broken. [1] http://gerrit.ovirt.org/#/c/24624/ Change-Id: I0ef53ee34fdcc022c7f2984f4aad4b82ee06840a Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Reviewed-on: http://gerrit.ovirt.org/24645 Reviewed-by: Nir Soffer <nsoffer(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> Tested-by: Dan Kenigsberg <danken(a)redhat.com> --- M tests/jsonRpcTests.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ef53ee34fdcc022c7f2984f4aad4b82ee06840a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in vdsm[master]: test: declare unstable test as broken
by Dan Kenigsberg 19 Feb '14

19 Feb '14

Dan Kenigsberg has posted comments on this change. Change subject: test: declare unstable test as broken ...................................................................... Patch Set 1: Verified+1 Code-Review+2 If you say it's broken, it's broken. -- To view, visit http://gerrit.ovirt.org/24645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ef53ee34fdcc022c7f2984f4aad4b82ee06840a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vm: set self._dom to None after destroying vm
by Jarod.w 19 Feb '14

19 Feb '14

Jarod.w has uploaded a new change for review. Change subject: vm: set self._dom to None after destroying vm ...................................................................... vm: set self._dom to None after destroying vm When receiving 'vmDestory' command, we deal with it using the following steps: * invoke VM::releaseVm() in VM::destroy * invoke _dom.destroyFlags()/_dom.destroy() to destroy vm in VM::releaseVm() * When libvirt is done for destroying vm, it emits VIR_DOMAIN_EVENT_STOPPED _SHUTDOWN/DESTROYED(due to different flows) * VDSM receives the signal, it invokes VM::_onQemuDeath(). * invoke VM::releaseVm() in VM::_onQemuDeath(). Unfortunately, it doesn't set self._dom to None after destroying vm in VM::releaseVm(). So, it cause the following libvirterror when invoking VM::releaseVm() in VM::_onQemuDeath(): libvirtconnection::101::libvirtconnection::(wrapper) Unknown libvirterror: ecode: 42 edom: 10 level: 2 message: Domain not found: no domain with matching uuid '1813cf7d-d62b-4cc2-86fc-de469e0e37eb' (xxx) To ignore the libvirterror, the patch will set self._dom to None after destroying vm. Change-Id: I4eca4c14e44a2a95628bf8e45a7a0a64d56446b8 Signed-off-by: jarod.w <work.iec23801(a)gmail.com> --- M vdsm/vm.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/23014/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 9381ccf..cd7f3ee 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -4511,6 +4511,8 @@ "gracefully", self.conf['vmId']) time.sleep(30) self._dom.destroy() + finally: + self._dom = None except libvirt.libvirtError as e: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN: self.log.warning("libvirt domain not found", exc_info=True) -- To view, visit http://gerrit.ovirt.org/23014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4eca4c14e44a2a95628bf8e45a7a0a64d56446b8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Jarod.w <work.iec23801(a)gmail.com>

5 13

Change in vdsm[master]: test: ssl reactor not tested in jsonrpc tests
by Jenkins CI RO 19 Feb '14

19 Feb '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: test: ssl reactor not tested in jsonrpc tests ...................................................................... Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7321/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6419/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7203/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6dfa4d6324baa0b7091ad6713854d146ec999d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

← Newer
1
...
32
33
34
35
36
37
38
...
53
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2014