vdsm-patches February 2014

vdsm-patches@lists.fedorahosted.org

42 participants
527 discussions

Change in vdsm[master]: This is a test
by dkuznets＠redhat.com 20 Feb '14

20 Feb '14

Dima Kuznetsov has uploaded a new change for review. Change subject: This is a test ...................................................................... This is a test Change-Id: I79ab16d5d0bd6b7fdc860fd8dcc6331b23534690 Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com> --- M README 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/24828/1 diff --git a/README b/README index d1b4348..44b7ed1 100644 --- a/README +++ b/README @@ -1,6 +1,6 @@ VDSM: Virtual Desktop Server Manager ==================================== - +This is a test The VDSM service exposes an XML-RPC API for managing virtualization hosts running the KVM hypervisor technology. VDSM manages and monitors the host's storage, memory and networks as well as virtual machine -- To view, visit http://gerrit.ovirt.org/24828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I79ab16d5d0bd6b7fdc860fd8dcc6331b23534690 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com>

2 2

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Alon Bar-Lev 20 Feb '14

20 Feb '14

Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 3: please use examples anywhere you can... hard to understand what you are actually going to do. simple example of current state and new state will do. -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: Using egrep when greping conf files
by ybronhei＠redhat.com 20 Feb '14

20 Feb '14

Yaniv Bronhaim has uploaded a new change for review. Change subject: Using egrep when greping conf files ...................................................................... Using egrep when greping conf files The regex with \s* that searches for parameters in the conf file fails to return with latest grep if specified without [] (see [1]). [1] https://bbs.archlinux.org/viewtopic.php?pid=1345556 Change-Id: Ibf63316f4cec2ade80a6259a8ceb5b80f2537040 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M configure.ac M lib/vdsm/tool/libvirt_configure.sh.in 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/24741/1 diff --git a/configure.ac b/configure.ac index 55879e7..64eba71 100644 --- a/configure.ac +++ b/configure.ac @@ -202,6 +202,7 @@ AC_PATH_PROG([FENCE_AGENT_PATH], [fence_ilo], [/usr/sbin/fence_ilo]) AC_PATH_PROG([FUSER_PATH], [fuser], [/sbin/fuser]) AC_PATH_PROG([GREP_PATH], [grep], [/bin/grep]) +AC_PATH_PROG([EGREP_PATH], [egrep], [/bin/egrep]) AC_PATH_PROG([GRUBBY_PATH], [grubby], [/sbin/grubby]) AC_PATH_PROG([HOSTNAME_PATH], [hostname], [/usr/bin/hostname]) AC_PATH_PROG([HWCLOCK_PATH], [hwclock], [/usr/sbin/hwclock]) diff --git a/lib/vdsm/tool/libvirt_configure.sh.in b/lib/vdsm/tool/libvirt_configure.sh.in index 7bb5143..fae46da 100755 --- a/lib/vdsm/tool/libvirt_configure.sh.in +++ b/lib/vdsm/tool/libvirt_configure.sh.in @@ -47,7 +47,7 @@ get_libvirt_conf_item() { local cfile="$1" local key="$2" - @GREP_PATH@ "^\s*"${key}"\s*=" "${cfile}" | \ + @EGREP_PATH@ "^\s*"${key}"\s*=" "${cfile}" | \ tail -1 | @SED_PATH@ "s/\s*$key\s*=\s*//;s/\s*$#.*$\?$//" } -- To view, visit http://gerrit.ovirt.org/24741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf63316f4cec2ade80a6259a8ceb5b80f2537040 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>

4 11

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Alon Bar-Lev 20 Feb '14

20 Feb '14

Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 3: this is the right direction. -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by ybronhei＠redhat.com 20 Feb '14

20 Feb '14

Yaniv Bronhaim has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 3: so leave password as it is, and add new field auth as I suggested. if auth exists ignore the password and user. auth will be the new form of validation and will contain the prefix syntax. next version the password\user fields will be deprecated -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Alon Bar-Lev 20 Feb '14

20 Feb '14

Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 3: once again... you cannot take plain password field and make it prefixed, what if password has file: ? you must think of a different solution. -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Alon Bar-Lev 20 Feb '14

20 Feb '14

Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 3: please describe solutions... so we can start focus... actual solutions not description... examples are preferred... -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Alon Bar-Lev 20 Feb '14

20 Feb '14

Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 3: you cannot reuse password and change the format, you must have different parameter for that. -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by ybronhei＠redhat.com 20 Feb '14

20 Feb '14

Yaniv Bronhaim has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 3: (1 comment) you must keep backward compatibility and add new field for generic authentication. add new field auth as alon suggests that can get auth=pass:user@pass or auth=env:[env-name] or auth=file:[filename]. if auth exists in command prefer that, if not, check for the old form with user password. http://gerrit.ovirt.org/#/c/24733/3/client/vdsClient.py File client/vdsClient.py: Line 23: import socket Line 24: import sys Line 25: import traceback Line 26: import xmlrpclib Line 27: import pprint as pp not related at all. please remove Line 28: Line 29: from vdsm import utils, vdscli Line 30: try: Line 31: import vdsClientGluster as ge -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Alon Bar-Lev 20 Feb '14

20 Feb '14

Alon Bar-Lev has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 3: I do not follow. just to make sure... you cannot keep implicit meaning. your options: 1. break backward compatibility, add prefix to password= 2. add a new variable password-source or any other name which receives a new generic format of what:value 3. add a new variable for password-file and have only file support as alternative to plain password. -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

← Newer
1
...
30
31
32
33
34
35
36
...
53
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2014