vdsm-patches February 2014

vdsm-patches@lists.fedorahosted.org

42 participants
527 discussions

Change in vdsm[master]: vdsClient: file based mechanism to provide password
by Jenkins CI RO 19 Feb '14

19 Feb '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsClient: file based mechanism to provide password ...................................................................... Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7320/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6418/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7202/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I363a16e6a7872ca05e19d5f520bdba90fb492374 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[master]: clientif: add initial tests
by fromani＠redhat.com 19 Feb '14

19 Feb '14

Francesco Romani has uploaded a new change for review. Change subject: clientif: add initial tests ...................................................................... clientif: add initial tests This patch adds the tests for prepareVolumePath, and laids the infrastructure for more clientIF tests. Relates-To: http://gerrit.ovirt.org/22928/ Change-Id: Iad652aed46b9fe985d7143052bd26320970502b5 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M tests/Makefile.am A tests/clientifTests.py 2 files changed, 198 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/24614/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index b7105ba..379e9fd 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -27,6 +27,7 @@ apiTests.py \ cPopenTests.py \ capsTests.py \ + clientifTests.py \ configNetworkTests.py \ fileVolumeTests.py \ fileUtilTests.py \ diff --git a/tests/clientifTests.py b/tests/clientifTests.py new file mode 100644 index 0000000..b35f517 --- /dev/null +++ b/tests/clientifTests.py @@ -0,0 +1,197 @@ +# +# Copyright 2014 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +import logging +from testrunner import VdsmTestCase as TestCaseBase +from testrunner import temporaryPath +from vm import VolumeError +import clientIF + + +INEXISTENT_PATH = '/this/path/should/not/exist' +FAKE_ISOFS_PATH = '/fake/path/to/isofs' +FAKE_FLOPPY_PATH = '/fake/path/to/floppy' +ISOFS_PATH = '/rhev/data-center/mnt/A.B.C.D:_ovirt_iso/XXX' \ + '/images/11111111-1111-1111-1111-111111111111/' \ + 'Fedora-Live-Desktop-x86_64-19.iso' + + +class FakeSuperVdsm: + def __init__(self, FakeCIF=None): + self.calls = [] + + def mkIsoFs(self, *args, **kwargs): + self.calls.append(('mkIsoFs', args, kwargs)) + return FAKE_ISOFS_PATH + + def mkFloppyFs(self, *args, **kwargs): + self.calls.append(('mkFloppyFs', args, kwargs)) + return FAKE_FLOPPY_PATH + + +class FakeClientIF(clientIF.clientIF): + def __init__(self, supervdsm): + self.supervdsm = supervdsm + self.irs = None # just to make sure nothing ever happens + self.log = logging.getLogger('ClientIFTests') + + +def fakeDrive(): + return { + 'index': '2', + 'iface': 'ide', + 'specParams': {}, + 'readonly': 'true', + 'deviceId': 'XXX', + 'path': ISOFS_PATH, + 'device': 'cdrom', + 'shared': 'false', + 'type': 'disk' + } + + +def fakePayloadDrive(): + return { + 'index': '3', + 'iface': 'ide', + 'specParams': { + 'vmPayload': { + 'volId': 'config-2', + 'file': { + 'openstack/latest/meta_data.json': '', + 'openstack/latest/user_data': '', + } + } + }, + 'readonly': 'true', + 'deviceId': 'YYY', + 'path': '', + 'device': 'cdrom', + 'shared': 'false', + 'type': 'disk' + } + + +class ClientIFTests(TestCaseBase): + + def setUp(self): + self.supervdsm = FakeSuperVdsm() + self.cif = FakeClientIF(self.supervdsm) + def getFakeProxy(): + return self.supervdsm + clientIF.supervdsm.getProxy = getFakeProxy + # the supervdsm module uses a global to implement the singleton + # pattern. We need to override the getter function. + + def assertCalled(self, funcName): + name, args, kwargs = self.supervdsm.calls[0] + self.assertEquals(name, funcName) + + def assertNotCalled(self, funcName): + for name, args, kwargs in self.supervdsm.calls: + if name == funcName: + raise self.failureException('%s was called' % (funcName)) + + def testNoneDrive(self): + volPath = self.cif.prepareVolumePath(None) + self.assertTrue(volPath is None) + + def testStringAsDrive(self): + with temporaryPath() as f: + volPath = self.cif.prepareVolumePath(f) + self.assertEquals(volPath, f) + + def testBadDrive(self): + self.assertRaises(VolumeError, + self.cif.prepareVolumePath, + INEXISTENT_PATH) + + def testCDRomFromPayload(self): + # bz1047356 + volPath = self.cif.prepareVolumePath(fakePayloadDrive()) + self.assertEquals(volPath, FAKE_ISOFS_PATH) + self.assertCalled("mkIsoFs") + + def testNoPayloadFileKey(self): + payloadDrive = fakePayloadDrive() + del payloadDrive['specParams']['vmPayload']['file'] + self.assertRaises(KeyError, + self.cif.prepareVolumePath, + payloadDrive) + + def testNoPayloadVolIdKey(self): + payloadDrive = fakePayloadDrive() + del payloadDrive['specParams']['vmPayload']['volId'] + volPath = self.cif.prepareVolumePath(payloadDrive) + self.assertEquals(volPath, FAKE_ISOFS_PATH) + self.assertCalled("mkIsoFs") + + def testDriveWithoutSpecParams(self): + drive = fakeDrive() + del drive['specParams'] + volPath = self.cif.prepareVolumePath(drive) + self.assertEquals(volPath, ISOFS_PATH) + # this is a fallback case explicitely marked + # as 'for Backward Compatibility sake' + # in the code + self.assertNotCalled("mkIsoFs") + + def testDriveWithoutSpecParamsAndPath(self): + drive = fakeDrive() + del drive['specParams'] + del drive['path'] + self.assertRaises(VolumeError, + self.cif.prepareVolumePath, + drive) + + def testCDRomEmpty(self): + drive = fakeDrive() + drive['specParams']['path'] = '' + drive['path'] = '' + volPath = self.cif.prepareVolumePath(drive) + self.assertEquals(volPath, '') + self.assertNotCalled("mkIsoFs") + + def testCDromPath(self): + volPath = self.cif.prepareVolumePath(fakeDrive()) + self.assertEquals(volPath, ISOFS_PATH) + self.assertNotCalled("mkIsoFs") + + def testDriveWithoutDeviceKey(self): + drive = fakeDrive() + del drive['device'] + self.assertRaises(KeyError, + self.cif.prepareVolumePath, + drive) + + def testDriveWithUnsupportedDeviceKey(self): + drive = fakeDrive() + drive['device'] = 'tape' + # fallback case: we must use the top-level key 'path' + volPath = self.cif.prepareVolumePath(drive) + self.assertEquals(volPath, ISOFS_PATH) + + def testSuperVdsmFailure(self): + def fail(*args): + raise RuntimeError("Injected fail") + self.supervdsm.mkIsoFs = fail + self.assertRaises(RuntimeError, + self.cif.prepareVolumePath, + fakePayloadDrive()) -- To view, visit http://gerrit.ovirt.org/24614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad652aed46b9fe985d7143052bd26320970502b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>

4 15

Change in vdsm[master]: caps: Collect numa information
by Dan Kenigsberg 19 Feb '14

19 Feb '14

Dan Kenigsberg has posted comments on this change. Change subject: caps: Collect numa information ...................................................................... Patch Set 5: Code-Review-1 (5 comments) Welcome, Xiaolei Shi. I believe that your suggested API needs more discussion. http://gerrit.ovirt.org/#/c/23703/5//COMMIT_MSG Commit Message: Line 17: Take the first item above to explain the meaning of each field: Line 18: 0 - The index of numa node Line 19: 0,1 - The index of cpus(core) which belong to this numa node Line 20: 10240 - The total memory of this numa node Line 21: 9500 - The free memory of this numa node Who is going to consume this information? I suppose that any client would have to parse the string you have described. Wouldn't it be nicer (albeit inefficient) to return a parsed structure such as a dictionary { numaNodeIndex : {'cpus': [0,1], totmem: 10240, freemem: 9500} } if you opt for a squashed, serialized api as the one you have proposed, please explain why a structured API is not preferable. Besides that, reporting the free memory in getCaps seems wrong - it may be free on Vdsm startup, but quickly used when VM starts to run. A third point worth considering is the extendibility of your API. libvirt provides more information - allocation of cpus to cores and sockets. I do not know if this is going to be useful to us, but it deserves thinking. In general, sticking to libvirt's modeling is better than inventing a completely new one. Please include the motivation for your chosen API in the commit message. Line 22: Line 23: Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd Line 24: Bug-Url: https://bugzilla.redhat.com/1010059 Line 20: 10240 - The total memory of this numa node Line 21: 9500 - The free memory of this numa node Line 22: Line 23: Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd Line 24: Bug-Url: https://bugzilla.redhat.com/1010059 This bug is currently private. Can you open it to the public? http://gerrit.ovirt.org/#/c/23703/5/vdsm/caps.py File vdsm/caps.py: Line 178: for cpu in cell.getElementsByTagName('cpu'): Line 179: cpus.append(cpu.getAttribute('id')) Line 180: cellInfo.append(','.join(cpus)) Line 181: memInfo = _getMemoryStatsByNumaCell(int(cellInfo[0]), 0, memStats) Line 182: cellInfo.append(str(memInfo['total']/1024)) I do not know why pep8 did not cry, but please separate operator with spaces. Line 183: cellInfo.append(str(memInfo['free']/1024)) Line 184: cellsInfo.append(':'.join(cellInfo)) Line 185: return ';'.join(cellsInfo) Line 186: Line 181: memInfo = _getMemoryStatsByNumaCell(int(cellInfo[0]), 0, memStats) Line 182: cellInfo.append(str(memInfo['total']/1024)) Line 183: cellInfo.append(str(memInfo['free']/1024)) Line 184: cellsInfo.append(':'.join(cellInfo)) Line 185: return ';'.join(cellsInfo) > I feel this can be improved somehow but I don't have any suggestion here. O I share Francesco's feeling: the serialization of the data into a string is better left as a task for the transport. Typical clients would like to have direct access to the data fields. Line 186: Line 187: Line 188: def _getMemoryStatsByNumaCell(cell, flags=0, memStats=None): Line 189: if memStats is None: Line 184: cellsInfo.append(':'.join(cellInfo)) Line 185: return ';'.join(cellsInfo) Line 186: Line 187: Line 188: def _getMemoryStatsByNumaCell(cell, flags=0, memStats=None): typically, memory usage is a volatile measure. As such, freemem does not fit well into getCaps, which is polled very seldom. Line 189: if memStats is None: Line 190: memStats = libvirtconnection.get().getMemoryStats(int(cell), flags) Line 191: return memStats Line 192: -- To view, visit http://gerrit.ovirt.org/23703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: sampling: avoid needless modulu
by Dan Kenigsberg 18 Feb '14

18 Feb '14

Dan Kenigsberg has uploaded a new change for review. Change subject: sampling: avoid needless modulu ...................................................................... sampling: avoid needless modulu Since Linux jiffies counters wrap at 32 bits, we take modulu 2 ** 32 when we calculate the difference between two consecustive samples. Taking another modulu, after dividing by the time interval, is harmless but also needless and confusing. Change-Id: I31ec567836a4c9b59c113eff45e4baa653e399fa Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/sampling.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/24193/1 diff --git a/vdsm/sampling.py b/vdsm/sampling.py index 6b55f87..54b6381 100644 --- a/vdsm/sampling.py +++ b/vdsm/sampling.py @@ -431,9 +431,9 @@ hs0, hs1 = self._samples[0], self._samples[-1] interval = hs1.timestamp - hs0.timestamp jiffies = (hs1.pidcpu.user - hs0.pidcpu.user) % (2 ** 32) - stats['cpuUserVdsmd'] = (jiffies / interval) % (2 ** 32) - jiffies = hs1.pidcpu.sys - hs0.pidcpu.sys - stats['cpuSysVdsmd'] = (jiffies / interval) % (2 ** 32) + stats['cpuUserVdsmd'] = (jiffies / interval) + jiffies = hs1.pidcpu.sys - hs0.pidcpu.sys % (2 ** 32) + stats['cpuSysVdsmd'] = (jiffies / interval) jiffies = (hs1.totcpu.user - hs0.totcpu.user) % (2 ** 32) stats['cpuUser'] = jiffies / interval / self._ncpus -- To view, visit http://gerrit.ovirt.org/24193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I31ec567836a4c9b59c113eff45e4baa653e399fa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

5 9

Change in vdsm[master]: avoid redundant domain produce() in createStoragePool
by lvroyce＠linux.vnet.ibm.com 18 Feb '14

18 Feb '14

Royce Lv has uploaded a new change for review. Change subject: avoid redundant domain produce() in createStoragePool ...................................................................... avoid redundant domain produce() in createStoragePool Change-Id: If1c236aa3043068ca8f3f376cb340e986cd484bb Signed-off-by: Royce Lv<lvroyce(a)linux.vnet.ibm.com> --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 4 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/7347/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 2227c03..b2c20c0 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -765,19 +765,6 @@ if msdType in sd.BLOCK_DOMAIN_TYPES and msdVersion in blockSD.VERS_METADATA_LV and len(domList) > sp.MAX_DOMAINS: raise se.TooManyDomainsInStoragePoolError() - for sdUUID in domList: - try: - dom = sdCache.produce(sdUUID=sdUUID) - # TODO: consider removing validate() from here, as the domains - # are going to be accessed much later, and may loose validity - # until then. - dom.validate() - except: - raise se.StorageDomainAccessError(sdUUID) - #If you remove this condition, remove it from StoragePool.attachSD() too. - if dom.isData() and (dom.getVersion() != msdVersion): - raise se.MixedSDVersionError(dom.sdUUID, dom.getVersion(), msd.sdUUID, msdVersion) - vars.task.getExclusiveLock(STORAGE, spUUID) for dom in sorted(domList): vars.task.getExclusiveLock(STORAGE, dom) diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index ee45151..a5b65c7 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -549,6 +549,7 @@ domain.validate() if sdUUID == msdUUID: msd = domain + msdVersion = msd.getVersion() except se.StorageException: self.log.error("Unexpected error", exc_info=True) raise se.StorageDomainAccessError(sdUUID) @@ -560,6 +561,9 @@ # Non ISO domains have only 1 pool if len(spUUIDs) > 0: raise se.StorageDomainAlreadyAttached(spUUIDs[0], sdUUID) + + if domain.isData() and (domain.getVersion() != msdVersion): + raise se.MixedSDVersionError(domain.sdUUID, domain.getVersion(), msd.sdUUID, msdVersion) fileUtils.createdir(self.poolPath) self._acquireTemporaryClusterLock(msdUUID, safeLease) -- To view, visit http://gerrit.ovirt.org/7347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If1c236aa3043068ca8f3f376cb340e986cd484bb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>

7 12

Change in vdsm[ovirt-3.4]: Fix defaultRoute handling
by Dan Kenigsberg 18 Feb '14

18 Feb '14

Hello Antoni Segura Puimedon, Assaf Muller, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/24677 to review the following change. Change subject: Fix defaultRoute handling ...................................................................... Fix defaultRoute handling defaultRoute wasn't being past correctly to objectivizeNetwork, so that defaultRoute was always None inside the function, no matter what was past to it. This meant that DEFROUTE=yes/no was never written to ifcfg files, and 'ip route add default...' never applied by the iproute2 configurator. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015009 Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d Signed-off-by: Assaf Muller <amuller(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/24631 Reviewed-by: Antoni Segura Puimedon <asegurap(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> Tested-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/configNetwork.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/24677/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 2be811c..78b5012 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -279,7 +279,7 @@ netEnt = objectivizeNetwork(network if bridged else None, vlan, bonding, bondingOptions, nics, mtu, ipaddr, netmask, gateway, bootproto, ipv6addr, ipv6gateway, - defaultRoute, _netinfo=_netinfo, + defaultRoute=defaultRoute, _netinfo=_netinfo, configurator=configurator, **options) netEnt.configure(**options) -- To view, visit http://gerrit.ovirt.org/24677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>

3 4

Change in vdsm[master]: test: unstable jsonrpc tests
by Nir Soffer 18 Feb '14

18 Feb '14

Nir Soffer has posted comments on this change. Change subject: test: unstable jsonrpc tests ...................................................................... Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24624/2/tests/jsonRpcTests.py File tests/jsonRpcTests.py: Line 103: except Exception as e: Line 104: self.log.error("Reactor died unexpectedly", exc_info=True) Line 105: self.fail("Reactor died: (%s) %s" % (type(e), e)) Line 106: Line 107: with constructReactor(rt, ssl) as \ How this can create rare random failures? Line 108: (reactor, clientReactor, laddr): Line 109: Line 110: t = threading.Thread(target=echosrv.serve) Line 111: t.setDaemon(True) -- To view, visit http://gerrit.ovirt.org/24624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6dfa4d6324baa0b7091ad6713854d146ec999d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: Fix defaultRoute handling
by amuller＠redhat.com 18 Feb '14

18 Feb '14

Assaf Muller has uploaded a new change for review. Change subject: Fix defaultRoute handling ...................................................................... Fix defaultRoute handling defaultRoute wasn't being past correctly to objectivizeNetwork, so that defaultRoute was always None inside the function, no matter what was past to it. This meant that DEFROUTE=yes/no was never written to ifcfg files, and 'ip route add default...' never applied by the iproute2 configurator. Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d Signed-off-by: Assaf Muller <amuller(a)redhat.com> --- M vdsm/configNetwork.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/24631/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 7a2206a..5bf9838 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -279,7 +279,7 @@ netEnt = objectivizeNetwork(network if bridged else None, vlan, bonding, bondingOptions, nics, mtu, ipaddr, netmask, gateway, bootproto, ipv6addr, ipv6gateway, - defaultRoute, _netinfo=_netinfo, + defaultRoute=defaultRoute, _netinfo=_netinfo, configurator=configurator, **options) netEnt.configure(**options) -- To view, visit http://gerrit.ovirt.org/24631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>

5 7

Change in vdsm[master]: Add functions getNetworkList and getNetworkInfo to API
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has abandoned this change. Change subject: Add functions getNetworkList and getNetworkInfo to API ...................................................................... Abandoned no activity - revive if still relevant -- To view, visit http://gerrit.ovirt.org/2664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in vdsm[master]: test: unstable jsonrpc tests
by Jenkins CI RO 18 Feb '14

18 Feb '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: test: unstable jsonrpc tests ...................................................................... Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7314/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6412/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7196/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6dfa4d6324baa0b7091ad6713854d146ec999d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

← Newer
1
...
33
34
35
36
37
38
39
...
53
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2014