Change in vdsm[master]: caps: Modify numa functions to public
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: Modify numa functions to public
......................................................................
caps: Modify numa functions to public
Modify numa related functions in caps module to be public since they
are called in other modules.
Change-Id: I7f23f294ea5759473acc33fb00dd20eadf5708a5
Signed-off-by: Bruce Shi <xiao-lei.shi(a)hp.com>
Reviewed-on: http://gerrit.ovirt.org/27515
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/capsTests.py
M vdsm/caps.py
2 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Xiaolei Shi: Verified
--
To view, visit http://gerrit.ovirt.org/27515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f23f294ea5759473acc33fb00dd20eadf5708a5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in vdsm[master]: caps: Modify numa functions to public
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: caps: Modify numa functions to public
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f23f294ea5759473acc33fb00dd20eadf5708a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years
Change in vdsm[master]: vm: Modify memory units of numa node
by Jenkins CI RO
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Modify memory units of numa node
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1262/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d53406796c8080adba581b5588c6edcd5b4ce4c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years
Change in vdsm[master]: sampling: Collect numa related statistics
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: sampling: Collect numa related statistics
......................................................................
Patch Set 6: Code-Review+1
I'm ok with this code, and makes sense to address my remaining remarks in future patches, which I look forward to see.
--
To view, visit http://gerrit.ovirt.org/26876
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8d2edd74b8b5d5d3d3e508afc3f675037a86597
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years
Change in vdsm[master]: vm: Modify memory units of numa node
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: Modify memory units of numa node
......................................................................
vm: Modify memory units of numa node
This patch is based on http://gerrit.ovirt.org/#/c/25254/ to modify the
memory units. Since there is a limitation in xmlrpc to transfer large
integer, this patch modify the memory value to string format in MB unit.
Change-Id: I1d53406796c8080adba581b5588c6edcd5b4ce4c
Signed-off-by: Bruce Shi <xiao-lei.shi(a)hp.com>
Reviewed-on: http://gerrit.ovirt.org/27403
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/vdsClientTests.py
M tests/vmTests.py
M vdsm/virt/vm.py
M vdsm_api/vdsmapi-schema.json
4 files changed, 11 insertions(+), 10 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Xiaolei Shi: Verified
--
To view, visit http://gerrit.ovirt.org/27403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d53406796c8080adba581b5588c6edcd5b4ce4c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years
Change in vdsm[master]: vm: Modify memory units of numa node
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Modify memory units of numa node
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d53406796c8080adba581b5588c6edcd5b4ce4c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years
Change in vdsm[master]: vm: Modify memory units of numa node
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: vm: Modify memory units of numa node
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d53406796c8080adba581b5588c6edcd5b4ce4c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years
Change in vdsm[master]: caps: Modify numa functions to public
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: caps: Modify numa functions to public
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f23f294ea5759473acc33fb00dd20eadf5708a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10 years